RE: [PATCH] ARM: OMAP4 clock domain: Add check for avoiding dependency related update.
Paul,
>-Original Message-
>From: Paul Walmsley [mailto:p...@pwsan.com]
>Sent: Thursday, February 11, 2010 5:44 AM
>To: Pagare, Abhijit
>Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org
>Subject: Re: [PATCH] ARM: OMAP4 clock domain: Add check for avoiding
>dependency related update.
>
>Hi Abhijit,
>
>On Wed, 10 Feb 2010, Abhijit Pagare wrote:
>
>> A check is added for avoiding the sleep/wakeup dependency updates
>> for OMAP4 as the structures for the dependencies are currently absent.
>>
>> Signed-off-by: Abhijit Pagare
>> Cc: Paul Walmsley
>
>Thanks, I've made the following changes to the patch to try to ensure that
>this doesn't slip through the cracks, and queued it for 2.6.34. If you
>have any comments on the revised patch, please let me know.
Looks neat. Thanks.
-Abhijit
>
>
>- Paul
>
>From: Abhijit Pagare
>Date: Wed, 10 Feb 2010 13:42:03 +0530
>Subject: [PATCH] ARM: OMAP4 clock domain: Add check for avoiding dependency
>related update.
>
>A check is added for avoiding the sleep/wakeup dependency updates
>for OMAP4 as the structures for the dependencies are currently absent.
>
>Signed-off-by: Abhijit Pagare
>[p...@pwsan.com: added warnings, explanatory comment, copyright update]
>Signed-off-by: Paul Walmsley
>---
> arch/arm/mach-omap2/clockdomain.c | 30 --
> 1 files changed, 24 insertions(+), 6 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-
>omap2/clockdomain.c
>index a38a615..de4278c 100644
>--- a/arch/arm/mach-omap2/clockdomain.c
>+++ b/arch/arm/mach-omap2/clockdomain.c
>@@ -1,8 +1,8 @@
> /*
> * OMAP2/3/4 clockdomain framework functions
> *
>- * Copyright (C) 2008-2009 Texas Instruments, Inc.
>- * Copyright (C) 2008-2009 Nokia Corporation
>+ * Copyright (C) 2008-2010 Texas Instruments, Inc.
>+ * Copyright (C) 2008-2010 Nokia Corporation
> *
> * Written by Paul Walmsley and Jouni Högander
> * Added OMAP4 specific support by Abhijit Pagare
>@@ -891,8 +891,17 @@ void omap2_clkdm_allow_idle(struct clockdomain *clkdm)
> pr_debug("clockdomain: enabling automatic idle transitions for %s\n",
>clkdm->name);
>
>- if (atomic_read(&clkdm->usecount) > 0)
>- _clkdm_add_autodeps(clkdm);
>+ /*
>+ * XXX This should be removed once TI adds wakeup/sleep
>+ * dependency code and data for OMAP4.
>+ */
>+ if (cpu_is_omap44xx()) {
>+ WARN_ONCE(1, "clockdomain: OMAP4 wakeup/sleep dependency "
>+"support is not yet implemented\n");
>+ } else {
>+ if (atomic_read(&clkdm->usecount) > 0)
>+ _clkdm_add_autodeps(clkdm);
>+ }
>
> _omap2_clkdm_set_hwsup(clkdm, 1);
>
>@@ -924,8 +933,17 @@ void omap2_clkdm_deny_idle(struct clockdomain *clkdm)
>
> _omap2_clkdm_set_hwsup(clkdm, 0);
>
>- if (atomic_read(&clkdm->usecount) > 0)
>- _clkdm_del_autodeps(clkdm);
>+ /*
>+ * XXX This should be removed once TI adds wakeup/sleep
>+ * dependency code and data for OMAP4.
>+ */
>+ if (cpu_is_omap44xx()) {
>+ WARN_ONCE(1, "clockdomain: OMAP4 wakeup/sleep dependency "
>+"support is not yet implemented\n");
>+ } else {
>+ if (atomic_read(&clkdm->usecount) > 0)
>+ _clkdm_del_autodeps(clkdm);
>+ }
> }
>
>
>--
>1.6.6.GIT
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP CPU ID: fix OMAP4 build failure
Hello Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, January 21, 2010 8:50 AM > To: Pagare, Abhijit > Cc: t...@atomide.com; linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: RE: [PATCH] OMAP CPU ID: fix OMAP4 build failure > > Hello Abhijit, > > On Wed, 20 Jan 2010, Pagare, Abhijit wrote: > > > I think the latest patch-set that I had posted has this change in it. > > You can refer to the patch in the link below > > > > http://marc.info/?l=linux-omap&m=126088474831309&w=2 > > Looks like this patch had somehow not made it into the for_2.6.34 branch; > this has now been fixed, which resolves the problem. But this part we > should discuss further: > > > I had used this flag earlier as there was nothing fixed as to name it as > > ES1 that time. > > Yep, I understand. > > > So now it can be migrated from CHIP_IS_OMAP4430 to CHIP_IS_OMAP4430ES1. > > I think CHIP_IS_OMAP4430 would be redundant in that case and should be > > removed. A patch would be essential to take care of that in the places > > where it is used. If you feel the same I can send a patch for fixing > > this. > > In the past, there have been some clock, clockdomain, powerdomain, IP > block, etc. changes going from ES1 to ES2 revisions. But most clocks, > etc. stay the same. So it seems best to keep the actual CHIP_IS_* bits > ES-level sensitive, then define a rollup macro like CHIP_IS_OMAP4430 for > what stays the same. Until ES2 details are available, this shouldn't > require any further changes to the codebase aside from id.c. Sounds okay. > > We don't currently define a rollup macro for CHIP_IS_OMAP3430, but it's > planned for 2.6.34 to include all of the individual CHIP_IS_OMAP* bits. > We'd do the same thing for OMAP2xxx but most of the 2xxx data in the > kernel tree has no ES-level information, so we'll probably leave those > as-is. We'll probably add in a Sitara CHIP_IS_* bit in there also. > > Anyway, there's no need for you to change your patch, now that it's > included in the for_2.6.34 branch. But keep in mind that we'll probably > post another id.c cleanup patch to change things around as described > above, unless you or others have some strong reason not to... Yes a patch will be essential for cleaning the id.c as we would have to also match up to the changes made by Tony for OMAP3 in his recently posted "OMAP3: Fix cpu detection" patch. I can send the patch when we need to push that change in for OMAP4. Thanks & Regards, Abhijit > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP CPU ID: fix OMAP4 build failure
Santosh, > -Original Message- > From: Shilimkar, Santosh > Sent: Wednesday, January 20, 2010 12:52 PM > To: Pagare, Abhijit; Paul Walmsley; Pagare, Abhijit > Cc: t...@atomide.com; linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: RE: [PATCH] OMAP CPU ID: fix OMAP4 build failure > > Abhijit, > > > > > I had used this flag earlier as there was nothing fixed as to name it as > ES1 that time. So now it can > > be migrated from CHIP_IS_OMAP4430 to CHIP_IS_OMAP4430ES1. I think > CHIP_IS_OMAP4430 would be redundant > > in that case and should be removed. A patch would be essential to take > care of that in the places > > where it is used. If you feel the same I can send a patch for fixing > this. > > > > Tony has already created the patch. Please use that and test it on OMAP4. I will test it on OMAP4 but my point was as follows, The patch that is sent has both the definitions of CHIP_IS_OMAP4430 and CHIP_IS_OMAP4430ES1 where the later is initialized with the former's value. I was actually wondering why the former is required anyways. It is a redundant thing and can be replaced totally. > > Regards, > Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP CPU ID: fix OMAP4 build failure
Hello Paul,
> -Original Message-
> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
> ow...@vger.kernel.org] On Behalf Of Paul Walmsley
> Sent: Wednesday, January 20, 2010 2:44 AM
> To: abhijit.pag...@ti.com
> Cc: t...@atomide.com; linux-omap@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org
> Subject: [PATCH] OMAP CPU ID: fix OMAP4 build failure
>
>
> Hello Abhijit,
>
> it seems that my for_2.6.34 branch does not build unless the following
> patch, or one like it, is included. Any comments?
>
>
> - Paul
>
>
> From: Paul Walmsley
>
>
> omap_4430sdp_defconfig currently does not build due to some missing CPU
> IDs:
>
> In file included from arch/arm/mach-omap2/powerdomains.h:59,
> from arch/arm/mach-omap2/io.c:42:
> arch/arm/mach-omap2/powerdomains44xx.h:39: error: 'CHIP_IS_OMAP4430'
> undeclared here (not in a function)
>
> ... so add CHIP_IS_OMAP4430ES1. Note that this is not yet set by
> mach-omap2/id.c; this is for TI to fix.
>
> Signed-off-by: Paul Walmsley
> Cc: Tony Lindgren
> Cc: Abhijit Pagare
> ---
> arch/arm/plat-omap/include/plat/cpu.h |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-
> omap/include/plat/cpu.h
> index 9a028bd..8ada0ef 100644
> --- a/arch/arm/plat-omap/include/plat/cpu.h
> +++ b/arch/arm/plat-omap/include/plat/cpu.h
> @@ -44,7 +44,7 @@
> int omap_type(void);
>
> struct omap_chip_id {
> - u8 oc;
> + u16 oc;
I think the latest patch-set that I had posted has this change in it. You can
refer to the patch in the link below
http://marc.info/?l=linux-omap&m=126088474831309&w=2
> u8 type;
> };
>
> @@ -470,8 +470,10 @@ IS_OMAP_TYPE(3517, 0x3517)
> #define CHIP_IS_OMAP3430ES3_0(1 << 5)
> #define CHIP_IS_OMAP3430ES3_1(1 << 6)
> #define CHIP_IS_OMAP3630ES1 (1 << 7)
> +#define CHIP_IS_OMAP4430ES1 (1 << 8)
>
> #define CHIP_IS_OMAP24XX (CHIP_IS_OMAP2420 | CHIP_IS_OMAP2430)
> +#define CHIP_IS_OMAP4430 CHIP_IS_OMAP4430ES1
I had used this flag earlier as there was nothing fixed as to name it as ES1
that time. So now it can be migrated from CHIP_IS_OMAP4430 to
CHIP_IS_OMAP4430ES1. I think CHIP_IS_OMAP4430 would be redundant in that case
and should be removed. A patch would be essential to take care of that in the
places where it is used. If you feel the same I can send a patch for fixing
this.
Regards,
Abhijit
>
> /*
> * "GE" here represents "greater than or equal to" in terms of ES
> --
> 1.6.6.rc2.5.g49666
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: OMAP4: Power Domains: Remove the return as power domain framework is in place
Sergio,
I have taken care of that in my other patches, which I had posted
earlier. They are not in mainline yet but are lined up for the next release.
You can find the same here.
http://marc.info/?l=linux-omap&m=126088474831309&w=2
Do let me know if you have any further questions.
Best Regards,
Abhijit Pagare
> -Original Message-
> From: Aguirre, Sergio
> Sent: Friday, January 08, 2010 7:31 PM
> To: Pagare, Abhijit; linux-omap@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org
> Cc: Paul Walmsley
> Subject: RE: [PATCH] ARM: OMAP4: Power Domains: Remove the return as power
> domain framework is in place
>
> Abhijit,
>
> > -Original Message-
> > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
> > ow...@vger.kernel.org] On Behalf Of Pagare, Abhijit
> > Sent: Friday, January 08, 2010 5:59 AM
> > To: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> > Cc: Pagare, Abhijit; Paul Walmsley
> > Subject: [PATCH] ARM: OMAP4: Power Domains: Remove the return as power
> > domain framework is in place
> >
> > The return prevents the power domains from getting registered.
> > Hence removing it to allow the frameworks model to work.
> >
> > Signed-off-by: Abhijit Pagare
> > Cc: Paul Walmsley
> > ---
> >
> > Compiled and Boot Tested on OMAP4430 simulator and ES1 Chip
> > Compiled and Boot Tested on OMAP3430 SDP
> > Compiled for OMAP2430 and OMAP2420
> >
> > arch/arm/mach-omap2/id.c |1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index a779240..6d1e97b 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -362,7 +362,6 @@ void __init omap2_check_revision(void)
> > omap3_cpuinfo();
> > } else if (cpu_is_omap44xx()) {
> > omap4_check_revision();
> > - return;
> > } else {
> > pr_err("OMAP revision unknown, please fix!\n");
> > }
>
> I don't have an OMAP4 with me, but I found something weird in your
> reported behaviour...
>
> The code that was being skipped is:
>
> /*
>* OK, now we know the exact revision. Initialize omap_chip bits
>* for powerdowmain and clockdomain code.
>*/
> if (cpu_is_omap243x()) {
> /* Currently only supports 2430ES2.1 and 2430-all */
> omap_chip.oc |= CHIP_IS_OMAP2430;
> } else if (cpu_is_omap242x()) {
> /* Currently only supports 2420ES2.1.1 and 2420-all */
> omap_chip.oc |= CHIP_IS_OMAP2420;
> } else if (cpu_is_omap3505() || cpu_is_omap3517()) {
> omap_chip.oc = CHIP_IS_OMAP3430 | CHIP_IS_OMAP3430ES3_1;
> } else if (cpu_is_omap343x()) {
> omap_chip.oc = CHIP_IS_OMAP3430;
> if (omap_rev() == OMAP3430_REV_ES1_0)
> omap_chip.oc |= CHIP_IS_OMAP3430ES1;
> else if (omap_rev() >= OMAP3430_REV_ES2_0 &&
>omap_rev() <= OMAP3430_REV_ES2_1)
> omap_chip.oc |= CHIP_IS_OMAP3430ES2;
> else if (omap_rev() == OMAP3430_REV_ES3_0)
> omap_chip.oc |= CHIP_IS_OMAP3430ES3_0;
> else if (omap_rev() == OMAP3430_REV_ES3_1)
> omap_chip.oc |= CHIP_IS_OMAP3430ES3_1;
> else if (omap_rev() == OMAP3630_REV_ES1_0)
> omap_chip.oc |= CHIP_IS_OMAP3630ES1;
> } else {
> pr_err("Uninitialized omap_chip, please fix!\n");
> }
>
> And, in theory, in OMAP4 case, you SHOULDN'T be doing anything here, as
> there's no case for cpu_is_omap443x or similar. So you should be _only_
> seeing a print in console saying: "Uninitialized omap_chip, please fix!",
> right?
>
> Is OMAP4 chip giving positive on cpu_is_omap343x() test then??
>
> Regards,
> Sergio
> > --
> > 1.5.4.7
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hello Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, January 07, 2010 2:40 AM > To: Pagare, Abhijit > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency > related update. > > Hello Abhijit, > > On Wed, 6 Jan 2010, Pagare, Abhijit wrote: > > > I checked the dependency patch-set. The complete stuff looks really > > neat. Applying OMAP4 on top of this would be feasible. The only thing is > > that till the point the OMAP4 dependency patches go in the "autodeps" > > variable in arch/arm/clockdomain.c would not be initialized which will > > cause a kernel boot-crash for the functions _clkdm_add_autodeps(clkdm) > > and _clkdm_del_autodeps(clkdm). Hence the hack patch referred to in the > > subject above is essential. Should I re-post it with the missing FIXME > > indication that you had recommended? > > My concern is that we don't want to forget about the OMAP4 sleep and > wakeup dependencies. How long do you think it will take to add them? It shouldn't take all that long. I will internally send you the auto-generated file having the dependency details soon. Do let me know if you want any modification in it. If all that's done in a couple of days then the patch above can be skipped. Regards, Abhijit > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hello Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Wednesday, January 06, 2010 4:40 AM > To: Pagare, Abhijit > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency > related update. > > On Wed, 30 Dec 2009, Pagare, Abhijit wrote: > > > > -Original Message- > > > From: Paul Walmsley [mailto:p...@pwsan.com] > > > Sent: Wednesday, December 30, 2009 2:02 PM > > > > > But really, I'd rather not apply this patch. The best way forward is > to > > > apply a patch that adds the OMAP4 wakeup and sleep dependencies > > > themselves. Have you had a chance to look at the series that I sent > you a > > > few weeks ago off-list that reorganizes the wakeup and sleep > dependencies > > > to determine if it is adequate for you to add the OMAP4 wakeup/sleep > > > dependencies afterwards? > > > > I had a look at the dependency patches that you had sent to me earlier > > and it seems feasible to add the OMAP4 related dependency data on top of > > those patches. A small change exists but can be taken care of. > > Great, I've just cleaned those up, rebased them, and posted them to the > list. If you prefer, you can also get from the > 'move_wkdeps_sleepdeps_to_clkdm' branch at git://git.pwsan.com/linux-2.6 > I checked the dependency patch-set. The complete stuff looks really neat. Applying OMAP4 on top of this would be feasible. The only thing is that till the point the OMAP4 dependency patches go in the "autodeps" variable in arch/arm/clockdomain.c would not be initialized which will cause a kernel boot-crash for the functions _clkdm_add_autodeps(clkdm) and _clkdm_del_autodeps(clkdm). Hence the hack patch referred to in the subject above is essential. Should I re-post it with the missing FIXME indication that you had recommended? Thanks & Regards, Abhijit > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hi Paul,
> -Original Message-
> From: Paul Walmsley [mailto:p...@pwsan.com]
> Sent: Wednesday, December 30, 2009 2:02 PM
> To: Pagare, Abhijit
> Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency
> related update.
>
> Hello Abhijit,
>
> On Wed, 23 Dec 2009, Abhijit Pagare wrote:
>
> > A check is added for avoiding the sleep/wakeup dependency updates
> > for OMAP4 as the structures for the dependencies are currently absent.
>
> As a threshold matter, code and data added in temporary hack patches like
> this need to be marked with XXX or FIXME or something similar to indicate
> that these are not intended features, but rather, temporary lines that
> need to be removed in the near term.
I think I missed that. I will add the FIXME indication to the check below. I
think that this check is essential for OMAP4 kernel boot-up as long as the
dependency patches are not pushed in.
>
> But really, I'd rather not apply this patch. The best way forward is to
> apply a patch that adds the OMAP4 wakeup and sleep dependencies
> themselves. Have you had a chance to look at the series that I sent you a
> few weeks ago off-list that reorganizes the wakeup and sleep dependencies
> to determine if it is adequate for you to add the OMAP4 wakeup/sleep
> dependencies afterwards?
I had a look at the dependency patches that you had sent to me earlier and it
seems feasible to add the OMAP4 related dependency data on top of those
patches. A small change exists but can be taken care of.
Regards,
Abhijit
>
>
> - Paul
>
> >
> > Signed-off-by: Abhijit Pagare
> > Cc: Paul Walmsley
> > ---
> >
> > Compiled and Boot Tested on OMAP4430 simulator, ES1 Chip & OMAP3430 SDP.
> > And also Compiled for OMAP2430 and OMAP2420
> >
> > This patch has a dependency on the earlier set of OMAP4 clock-domain
> patches.
> >
> > arch/arm/mach-omap2/clockdomain.c | 10 ++
> > 1 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-
> omap2/clockdomain.c
> > index 8c9e78c..6ec25ee 100644
> > --- a/arch/arm/mach-omap2/clockdomain.c
> > +++ b/arch/arm/mach-omap2/clockdomain.c
> > @@ -507,8 +507,9 @@ void omap2_clkdm_allow_idle(struct clockdomain
> *clkdm)
> > pr_debug("clockdomain: enabling automatic idle transitions for
> %s\n",
> > clkdm->name);
> >
> > - if (atomic_read(&clkdm->usecount) > 0)
> > - _clkdm_add_autodeps(clkdm);
> > + if (!cpu_is_omap44xx())
> > + if (atomic_read(&clkdm->usecount) > 0)
> > + _clkdm_add_autodeps(clkdm);
> >
> > _omap2_clkdm_set_hwsup(clkdm, 1);
> >
> > @@ -540,8 +541,9 @@ void omap2_clkdm_deny_idle(struct clockdomain
> *clkdm)
> >
> > _omap2_clkdm_set_hwsup(clkdm, 0);
> >
> > - if (atomic_read(&clkdm->usecount) > 0)
> > - _clkdm_del_autodeps(clkdm);
> > + if (!cpu_is_omap44xx())
> > + if (atomic_read(&clkdm->usecount) > 0)
> > + _clkdm_del_autodeps(clkdm);
> > }
> >
> >
> > --
> > 1.5.4.7
> >
>
>
> - Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/5] ARM: OMAP4: PM: OMAP4 essential basic initialisations.
Tony,
> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Tuesday, December 29, 2009 5:04 AM
> To: abhijit.pag...@india.ti.com
> Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Paul
> Walmsley; Nayak, Rajendra; Pagare, Abhijit; Cousson, Benoit
> Subject: Re: [PATCH 1/5] ARM: OMAP4: PM: OMAP4 essential basic
> initialisations.
>
> * abhijit.pag...@india.ti.com [091211
> 02:50]:
> > From: Abhijit Pagare
> >
> > Some of the OMAP4 specific chip level initialisations are taken care of.
>
> Here's yet another series of patches with "PM" in the subject
> for no obvious reason.
>
> Please repost all with with sensible subjects.
I will re-post the patches with the necessary changes.
Best Regards,
Abhijit Pagare
>
> Tony
>
>
> > Signed-off-by: Abhijit Pagare
> > Cc: Paul Walmsley
> > Cc: Benoit Cousson
> > Cc: Rajendra Nayak
> > ---
> > arch/arm/mach-omap2/id.c |8 +++-
> > arch/arm/plat-omap/include/plat/cpu.h |6 +-
> > 2 files changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 4fad192..52aca5f 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -336,8 +336,12 @@ void __init omap2_check_revision(void)
> > omap3_check_features();
> > omap3_cpuinfo();
> > } else if (cpu_is_omap44xx()) {
> > + /*
> > +* omap44xx_check_revision() should
> > +* be defined above and then called
> > +* from here.
> > +*/
> > printk(KERN_INFO "FIXME: CPU revision = OMAP4430\n");
> > - return;
> > } else {
> > pr_err("OMAP revision unknown, please fix!\n");
> > }
> > @@ -367,6 +371,8 @@ void __init omap2_check_revision(void)
> > omap_chip.oc |= CHIP_IS_OMAP3430ES3_1;
> > else if (omap_rev() == OMAP3630_REV_ES1_0)
> > omap_chip.oc |= CHIP_IS_OMAP3630ES1;
> > + } else if (cpu_is_omap44xx()) {
> > + omap_chip.oc |= CHIP_IS_OMAP4430;
> > } else {
> > pr_err("Uninitialized omap_chip, please fix!\n");
> > }
> > diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-
> omap/include/plat/cpu.h
> > index 2e17890..6a296b8 100644
> > --- a/arch/arm/plat-omap/include/plat/cpu.h
> > +++ b/arch/arm/plat-omap/include/plat/cpu.h
> > @@ -154,6 +154,7 @@ unsigned int omap_rev(void);
> > * cpu_is_omap242x(): True for OMAP2420, OMAP2422, OMAP2423
> > * cpu_is_omap243x(): True for OMAP2430
> > * cpu_is_omap343x(): True for OMAP3430
> > + * cpu_is_omap443x(): True for OMAP4430
> > */
> > #define GET_OMAP_CLASS (omap_rev() & 0xff)
> >
> > @@ -284,6 +285,7 @@ IS_OMAP_SUBCLASS(363x, 0x363)
> > * cpu_is_omap2423(): True for OMAP2423
> > * cpu_is_omap2430(): True for OMAP2430
> > * cpu_is_omap3430(): True for OMAP3430
> > + * cpu_is_omap4430(): True for OMAP4430
> > * cpu_is_omap3505(): True for OMAP3505
> > * cpu_is_omap3517(): True for OMAP3517
> > */
> > @@ -332,6 +334,7 @@ IS_OMAP_TYPE(3517, 0x3517)
> > #define cpu_is_omap3505() 0
> > #define cpu_is_omap3517() 0
> > #define cpu_is_omap3430() 0
> > +#define cpu_is_omap4430() 0
> > #define cpu_is_omap3630() 0
> >
> > /*
> > @@ -443,7 +446,7 @@ IS_OMAP_TYPE(3517, 0x3517)
> > #define OMAP3505_REV(v)(OMAP35XX_CLASS | (0x3505 << 16) | (v
> << 12))
> > #define OMAP3517_REV(v)(OMAP35XX_CLASS | (0x3517 << 16) | (v
> << 12))
> >
> > -#define OMAP443X_CLASS 0x44300034
> > +#define OMAP443X_CLASS 0x44300044
> >
> > /*
> > * omap_chip bits
> > @@ -467,6 +470,7 @@ IS_OMAP_TYPE(3517, 0x3517)
> > #define CHIP_IS_OMAP3430ES3_0 (1 << 5)
> > #define CHIP_IS_OMAP3430ES3_1 (1 << 6)
> > #define CHIP_IS_OMAP3630ES1(1 << 7)
> > +#define CHIP_IS_OMAP4430 (1 << 8)
> >
> > #define CHIP_IS_OMAP24XX (CHIP_IS_OMAP2420 | CHIP_IS_OMAP2430)
> >
> > --
> > 1.5.4.7
> >
> >
> > ___
> > linux-arm-kernel mailing list
> > linux-arm-ker...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Remove the checks preventing OMAP4 clockdomain validation
Paul, While testing after the below change I found out that some sleep/wakeup dependency related checks have to be avoided for OMAP4 to boot up properly as the dependencies have not been populated currently for OMAP4. Also I was validating the clock->clockdomain registering and noticed that one of the clock-domains is missing in the auto-generated file. So along with the current patch in discussion I am sending two separate patches for fixing the above things as well. Best Regards, Abhijit Pagare > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Tuesday, December 22, 2009 9:43 PM > To: Pagare, Abhijit > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Cousson, Benoit; Nayak, Rajendra > Subject: Re: [PATCH 1/1] ARM: OMAP4: PM: Remove the checks preventing > OMAP4 clockdomain validation > > Hello Abhijit, > > On Mon, 21 Dec 2009, Abhijit Pagare wrote: > > > The clockdomain related code beng in place it is now not necessary to > have > > some of the clock code commented out. This would help the validation of > the > > clockdomain functions using the clock level interfaces. > > > > Signed-off-by: Abhijit Pagare > > Cc: Paul Walmsley > > Cc: Benoit Cousson > > Cc: Rajendra Nayak > > Could you also deal with the TODO in mach-omap2/clock44xx_data.c ? > > Also, has this patch been tested? If so, please list the platform it was > tested on in the commit message. > > thanks, > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: OMAP4 clock code needs some modifying now that clockdomains are present
Paul, Thanks for the update. I will take care of that, rebase on the suggested queue and send them soon. Best Regards, Abhijit Pagare > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Saturday, December 19, 2009 2:02 AM > To: Pagare, Abhijit > Cc: Nayak, Rajendra; linux-omap@vger.kernel.org > Subject: Re: OMAP4 clock code needs some modifying now that clockdomains > are present > > Hi Abhijit, > > On Fri, 18 Dec 2009, Paul Walmsley wrote: > > > going through the clock code, I noticed that it still has several > > > > #ifndef CONFIG_ARCH_OMAP4 /* FIXME: Remove this once clkdm f/w is in > place */ > > Just noticed this also in clock44xx_data.c: > > /* TODO > omap2_init_clk_clkdm(c->lk.clk); > */ > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [v2 PATCH 5/5] ARM: OMAP4: PM: Refine the APIs to support OMAP4 features.
Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Tuesday, December 15, 2009 10:23 PM > To: Pagare, Abhijit > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Cousson, Benoit; Nayak, Rajendra > Subject: Re: [v2 PATCH 5/5] ARM: OMAP4: PM: Refine the APIs to support > OMAP4 features. > > Hi Abhijit, > > just FYI, on this patch: > > On Tue, 15 Dec 2009, Abhijit Pagare wrote: > > > Port the APIs to support the OMAP4 clockdomain framework. > > Also take care of the compiling requirements for the same. > > ... > > > diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach- > omap2/clockdomain.c > > index 5366a10..f768d37 100644 > > --- a/arch/arm/mach-omap2/clockdomain.c > > +++ b/arch/arm/mach-omap2/clockdomain.c > > @@ -1,10 +1,11 @@ > > /* > > - * OMAP2/3 clockdomain framework functions > > + * OMAP2/3/4 clockdomain framework functions > > * > > * Copyright (C) 2008 Texas Instruments, Inc. > > * Copyright (C) 2008-2009 Nokia Corporation > > * > > * Written by Paul Walmsley and Jouni Hgander > > ... looks like something mangled the UTF-8 which causes this patch to > not apply cleanly. Fixed this up by hand. It's fine. Thanks..! > > > - Paul Regards, Abhijit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/5] OMAP4 Power Domain Framework Support
Paul, > thanks. One other thing that I noticed: in the first powerdomain patch,in > > arch/arm/plat-omap/include/plat/cpu.h, in struct omap_chip_id, the 'oc' > field needs to be a u16, rather than a u8. Thanks, it has been taken care of. > -Original Message- > From: Pagare, Abhijit > Sent: Tuesday, December 15, 2009 11:06 AM > To: 'Paul Walmsley' > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Cousson, Benoit; Nayak, Rajendra > Subject: RE: [PATCH 0/5] OMAP4 Power Domain Framework Support > > Paul, > There is one Fix patch for OMAP3 on top of which these patches > should go in cleanly. I will post the fix patch and the rebased and tested > patch-set soon. > > Best Regards, > Abhijit Pagare > > > -Original Message- > > From: Paul Walmsley [mailto:p...@pwsan.com] > > Sent: Tuesday, December 15, 2009 5:00 AM > > To: Pagare, Abhijit > > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > Cousson, Benoit; Nayak, Rajendra > > Subject: Re: [PATCH 0/5] OMAP4 Power Domain Framework Support > > > > Hello Abhijit, > > > > On Fri, 11 Dec 2009, Pagare, Abhijit wrote: > > > > > This patch series adds support for OMAP4 power domain framework. > > > > Just tried applying these -- looks like this series (and probably the > > clockdomain series also) needs to be refreshed to apply cleanly against > > the current linux-omap head. Could you please rebase, retest if needed, > > and repost? I have posted the patches rebased against the linux-omap head. Keep me updated with your inputs. > > > > > > thanks, > > > > - Paul Regards, Abhijit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[v2 PATCH 0/5] OMAP4 Clock Domain Framework Support
Hi, This is version two of the patch series which adds support for OMAP4 clock domain framework. It can be applied on top of the latest Mainline Kernel but has a dependency on the series of OMAP4 power domain framework patches sent by me earlier. http://marc.info/?l=linux-omap&m=126088465431181&w=2 It also has a dependency on the following fix patch: http://marc.info/?l=linux-omap&m=126088389030110&w=2 These patches have been boot-tested on the following platforms: -OMAP4 simulator -OMAP4430 ES1.0 silicon -OMAP3430 SDP In addition to this these patches have been compile-tested for the following platforms: -omap_2430sdp -omap_h4_2420sdp The complete omap4 clock domain structure is auto-generated using OMAP4 hardware database and is a joint effort of Paul Walmsley (p...@pwsan.com), Benoit Cousson (b-cous...@ti.com), Rajendra Nayak (rna...@ti.com) and me. Best Regards, Abhijit Pagare Abhijit Pagare (5): ARM: OMAP4: PM: Make OMAP3 Clock-domain framework compatible for OMAP4. ARM: OMAP4: PM: Modify Clock-domain interfaces for OMAP4 compatibility. ARM: OMAP4: PM: Add the Auto-generated OMAP4 specific clock domain framework. ARM: OMAP4: PM: Adapt the existing OMAP2/3 Clock Domain Frameworks. ARM: OMAP4: PM: Refine the APIs to support OMAP4 features. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[v2 PATCH 0/5] OMAP4 Power Domain Framework Support
Hi, This is version 2 of the patch series which adds support for OMAP4 power domain framework. It can be applied on top of the latest Mainline Kernel. These patches have been boot-tested on the following platforms: -OMAP4 simulator -OMAP4430 ES1.0 silicon -OMAP3430 SDP In addition to this these patches have been compile-tested for the following platforms: -omap_2430sdp -omap_h4_2420sdp The complete omap4 power domain structure is auto-generated using OMAP4 hardware database and is a joint effort of Paul Walmsley (p...@pwsan.com), Benoit Cousson (b-cous...@ti.com), Rajendra Nayak (rna...@ti.com) and me. Best Regards, Abhijit Pagare Abhijit Pagare (5): ARM: OMAP4: PM: OMAP4 essential basic initializations. ARM: OMAP4: PM: OMAP4 Power Domain Porting Related Clean-up. ARM: OMAP4: PM: Add the Auto-generated OMAP4 specific power domain framework. ARM: OMAP4: PM: Adapt the existing OMAP2/3 and common Power Domain Frameworks. ARM: OMAP4: PM: Refine the APIs to support OMAP4 features. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/5] OMAP4 Power Domain Framework Support
Paul, There is one Fix patch for OMAP3 on top of which these patches should go in cleanly. I will post the fix patch and the rebased and tested patch-set soon. Best Regards, Abhijit Pagare > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Tuesday, December 15, 2009 5:00 AM > To: Pagare, Abhijit > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Cousson, Benoit; Nayak, Rajendra > Subject: Re: [PATCH 0/5] OMAP4 Power Domain Framework Support > > Hello Abhijit, > > On Fri, 11 Dec 2009, Pagare, Abhijit wrote: > > > This patch series adds support for OMAP4 power domain framework. > > Just tried applying these -- looks like this series (and probably the > clockdomain series also) needs to be refreshed to apply cleanly against > the current linux-omap head. Could you please rebase, retest if needed, > and repost? > > > thanks, > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/5] OMAP4 Power Domain Framework Support
Paul, I will check that and repost them soon. Best Regards, Abhijit Pagare > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Tuesday, December 15, 2009 4:18 AM > To: Pagare, Abhijit > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Cousson, Benoit; Nayak, Rajendra > Subject: Re: [PATCH 0/5] OMAP4 Power Domain Framework Support > > Hello Abhijit, > > On Fri, 11 Dec 2009, Pagare, Abhijit wrote: > > > This patch series adds support for OMAP4 power domain framework. > > ... > > > Abhijit Pagare (5): > > ARM: OMAP4: PM: OMAP4 essential basic initializations. > > ARM: OMAP4: PM: OMAP4 Power Domain Porting Related Clean-up. > > ARM: OMAP4: PM: Add the Auto-generated OMAP4 specific power domain > framework. > > ARM: OMAP4: PM: Adapt the existing OMAP2/3 and common Power Domain > Frameworks. > > ARM: OMAP4: PM: Refine the APIs to support OMAP4 features. > > Looks like these patches didn't make it to the list. Could you check and > repost? > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] OMAP4 Clock Domain Framework Support
Hi, This patch series adds support for OMAP4 clock domain framework. It can be applied on top of the latest Mainline Kernel but has a dependency on OMAP4 power domain framework patches sent by me earlier. These patches have been boot-tested on the following platforms: -OMAP4 simulator -OMAP4430 ES1.0 silicon -OMAP3430 SDP In addition to this these patches have been compile-tested for the following platforms: -omap_2430sdp -omap_h4_2420sdp The complete omap4 clock domain structure is auto-generated using OMAP4 hardware database and is a joint effort of Paul Walmsley (p...@pwsan.com), Benoit Cousson (b-cous...@ti.com), Rajendra Nayak (rna...@ti.com) and me. Best Regards, Abhijit Pagare ARM: OMAP4: PM: Make OMAP3 Clock-domain framework compatible for OMAP4. ARM: OMAP4: PM: Modify Clock-domain interfaces for OMAP4 compatibility. ARM: OMAP4: PM: Add the Auto-generated OMAP4 specific clock domain framework. ARM: OMAP4: PM: Adapt the existing OMAP2/3 Clock Domain Frameworks. ARM: OMAP4: PM: Refine the APIs to support OMAP4 features. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] OMAP4 Power Domain Framework Support
Hi, This patch series adds support for OMAP4 power domain framework. It can be applied on top of the latest Mainline Kernel. These patches have been boot-tested on the following platforms: -OMAP4 simulator -OMAP4430 ES1.0 silicon -OMAP3430 SDP In addition to this these patches have been compile-tested for the following platforms: -omap_2430sdp -omap_h4_2420sdp The complete omap4 power domain structure is auto-generated using OMAP4 hardware database and is a joint effort of Paul Walmsley (p...@pwsan.com), Benoit Cousson (b-cous...@ti.com), Rajendra Nayak (rna...@ti.com) and me. Best Regards, Abhijit Pagare Abhijit Pagare (5): ARM: OMAP4: PM: OMAP4 essential basic initializations. ARM: OMAP4: PM: OMAP4 Power Domain Porting Related Clean-up. ARM: OMAP4: PM: Add the Auto-generated OMAP4 specific power domain framework. ARM: OMAP4: PM: Adapt the existing OMAP2/3 and common Power Domain Frameworks. ARM: OMAP4: PM: Refine the APIs to support OMAP4 features. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] OMAP4 Power Domain Framework
Paul, Have you framed the comments for the Power Domain Framework Patches that I had submitted? If yes then can you update me with the same? Best Regards, Abhijit Pagare -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, August 19, 2009 2:54 PM To: Pagare, Abhijit Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH 0/2] OMAP4 Power Domain Framework On Wed, 19 Aug 2009, Pagare, Abhijit wrote: > Paul, > > I am resending the patches with the suggested changes. > > This series contains patches which add the power domain framework support for > OMAP4. > > This series applies on top of v2.6.31-rc5. It applies on top of the patches > sent by Rajendra Nayak for the PRM/CM1/CM2 module register offsets and masks > initialization. > > http://www.mail-archive.com/linux-omap@vger.kernel.org/ Thanks. I have a few more comments that I've been working on and I plan to send them soon. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] OMAP4 Power Domain Framework
Paul, I am resending the patches with the suggested changes. This series contains patches which add the power domain framework support for OMAP4. This series applies on top of v2.6.31-rc5. It applies on top of the patches sent by Rajendra Nayak for the PRM/CM1/CM2 module register offsets and masks initialization. http://www.mail-archive.com/linux-omap@vger.kernel.org/ Abhijit Pagare (3): ARM: OMAP4: PM: Add power domain framework. ARM: OMAP4: PM: Refine API's for Power domain Framework Support. arch/arm/mach-omap2/Makefile | 1 + arch/arm/mach-omap2/io.c | 2 +- arch/arm/mach-omap2/powerdomain.c | 3 + arch/arm/mach-omap2/powerdomains.h | 53 +++--- arch/arm/mach-omap2/powerdomains24xx.h | 18 ++ arch/arm/mach-omap2/powerdomains34xx.h | 18 ++ arch/arm/mach-omap2/powerdomains44xx.h | 258 + arch/arm/mach-omap2/prcm.c | 2 + arch/arm/mach-omap2/prm.h | 24 ++- arch/arm/plat-omap/include/mach/cpu.h | 4 +- arch/arm/plat-omap/include/mach/powerdomain.h | 4 +- arch/arm/mach-omap2/powerdomain.c | 96 +++-- Best Regards, Abhijit Pagare -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] OMAP4 Power Domain Framework
Hi, This series contains patches which add the power domain framework support for OMAP4. This series applies on top of v2.6.31-rc5. It applies on top of the patches sent by Rajendra Nayak for the PRM/CM1/CM2 module register offsets and masks initialization. http://www.mail-archive.com/linux-omap@vger.kernel.org/ Abhijit Pagare (3): ARM: OMAP4: PM: Add power domain framework. ARM: OMAP4: PM: Upgrade the Makefile for power domain initializations. ARM: OMAP4: PM: Refine API's for Power domain Framework Support. arch/arm/mach-omap2/io.c | 2 +- arch/arm/mach-omap2/powerdomain.c | 3 + arch/arm/mach-omap2/powerdomains.h | 53 +++--- arch/arm/mach-omap2/powerdomains24xx.h | 18 ++ arch/arm/mach-omap2/powerdomains34xx.h | 18 ++ arch/arm/mach-omap2/powerdomains44xx.h | 259 + arch/arm/mach-omap2/prcm.c | 2 + arch/arm/mach-omap2/prm.h | 24 ++- arch/arm/plat-omap/include/mach/cpu.h | 4 +- arch/arm/plat-omap/include/mach/powerdomain.h | 4 +- ++ arch/arm/mach-omap2/Makefile | 2 +- arch/arm/mach-omap2/powerdomain.c | 96 +++-- Best Regards, Abhijit Pagare -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
