Pixel clock property from DT is not used in OMAP DRM

2014-07-02 Thread Tomas Novotny
Hi all,

I was trying to bring up parallel LCD on our custom board (similar to
BeagleBoard-xM) and I did it finally - but I needed to tweak hardcoded value
of 'Invert pixel clock'. Maybe I'm doing something wrong, but anyway:
According to the display-timing.txt doc the 'pixelclk-active' DT
optional property is here. But this is not honored (through IPC bit of
DISPC_POL_FREQ register). The problem is that this property is hardcoded in 
copy_timings_drm_to_omap() in file drivers/gpu/drm/omapdrm/omap_connector.c
on that line:
timings-data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
Other optional properties (ie. [hv]sync-active) are taken into the
account.
I'm using 3.16-rc1 kernel from Tony's OMAP tree.
Thanks and regards,

Tomas


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] mfd: twl-core: Fix accessibility of some twl4030 audio registers

2014-03-10 Thread Tomas Novotny
There are some unused registers in twl4030 at I2C address 0x49 and function
twl4030_49_nop_reg() is used to check accessibility of that registers. These
registers are written in decimal format but the values are correct in
hexadecimal format. (It can be checked few lines above the patched code -
these registers are marked as unused there.)

As a consequence three registers of audio submodule are treated as
inaccessible (preamplifier carkit right and both handsfree registers).

CC: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Tomas Novotny to...@novotny.cz
---
 drivers/mfd/twl-core.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index ed71832..e87140b 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -282,11 +282,11 @@ static struct reg_default twl4030_49_defaults[] = {
 static bool twl4030_49_nop_reg(struct device *dev, unsigned int reg)
 {
switch (reg) {
-   case 0:
-   case 3:
-   case 40:
-   case 41:
-   case 42:
+   case 0x00:
+   case 0x03:
+   case 0x40:
+   case 0x41:
+   case 0x42:
return false;
default:
return true;
-- 
1.8.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html