Re: [PATCH] ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)
* Sourav Poddar [131128 02:10]: > On Thursday 28 November 2013 02:58 PM, Peter Ujfalusi wrote: > >Since in DT booted kernel dummy regulators are no longer supported we need > >to provide valid phandle for the regulator needed by the backlight. > >On the board VBAT is used to power the LCD backlight(s). > > > >Signed-off-by: Peter Ujfalusi > >--- > >Hi, > > > >This patch is needed for 3.13 to get the LCD backlight to work again. > Is this usage of power supply a mandatory requirement? > > There is a thread which discusses this issue[1]: > http://www.spinics.net/lists/arm-kernel/msg288215.html > > According to the above, regulator framework have support in 3.13-rc1 > to returns > a dummy regulator if there is none specified in the dts data. > Thierry told that there seems to be a bug in regulator in handling > these case. > > Though, I also posted a patch on pwm a couple of days ago[2] > [2]: https://patchwork.kernel.org/patch/3246711/ > > I posted it without "power-supply" by testing it with the > solution proposed in [1]. > If I dont use the solution[1], it fails for me also. Hmm so if this is not needed, I'll mark this thread as read in my inbox. If you guys need it please repost. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)
On Thursday 28 November 2013 02:58 PM, Peter Ujfalusi wrote: Since in DT booted kernel dummy regulators are no longer supported we need to provide valid phandle for the regulator needed by the backlight. On the board VBAT is used to power the LCD backlight(s). Signed-off-by: Peter Ujfalusi --- Hi, This patch is needed for 3.13 to get the LCD backlight to work again. Is this usage of power supply a mandatory requirement? There is a thread which discusses this issue[1]: http://www.spinics.net/lists/arm-kernel/msg288215.html According to the above, regulator framework have support in 3.13-rc1 to returns a dummy regulator if there is none specified in the dts data. Thierry told that there seems to be a bug in regulator in handling these case. Though, I also posted a patch on pwm a couple of days ago[2] [2]: https://patchwork.kernel.org/patch/3246711/ I posted it without "power-supply" by testing it with the solution proposed in [1]. If I dont use the solution[1], it fails for me also. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)
Hi Benoit,
On 11/28/2013 11:35 AM, Benoit Cousson wrote:
> Hi Peter,
>
> On 28/11/2013 10:28, Peter Ujfalusi wrote:
>> Since in DT booted kernel dummy regulators are no longer supported we need
>> to provide valid phandle for the regulator needed by the backlight.
>> On the board VBAT is used to power the LCD backlight(s).
>>
>> Signed-off-by: Peter Ujfalusi
>> ---
>> Hi,
>>
>> This patch is needed for 3.13 to get the LCD backlight to work again.
>
> OK, so this is a fix for the next -rc?
Yes, it would be really great if this can make it to the next -rc.
>
> Regards,
> Benoit
>
>>
>> Regards,
>> Peter
>>
>> arch/arm/boot/dts/omap4-sdp.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts
>> b/arch/arm/boot/dts/omap4-sdp.dts
>> index 5fc3f43..6f86db2 100644
>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>> @@ -104,6 +104,7 @@
>> 100 110 120 127
>> >;
>> default-brightness-level = <13>;
>> +power-supply = <&vbat>;
>> };
>>
>> sound {
>>
>
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)
Hi Peter,
On 28/11/2013 10:28, Peter Ujfalusi wrote:
Since in DT booted kernel dummy regulators are no longer supported we need
to provide valid phandle for the regulator needed by the backlight.
On the board VBAT is used to power the LCD backlight(s).
Signed-off-by: Peter Ujfalusi
---
Hi,
This patch is needed for 3.13 to get the LCD backlight to work again.
OK, so this is a fix for the next -rc?
Regards,
Benoit
Regards,
Peter
arch/arm/boot/dts/omap4-sdp.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 5fc3f43..6f86db2 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -104,6 +104,7 @@
100 110 120 127
>;
default-brightness-level = <13>;
+ power-supply = <&vbat>;
};
sound {
--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)
Since in DT booted kernel dummy regulators are no longer supported we need
to provide valid phandle for the regulator needed by the backlight.
On the board VBAT is used to power the LCD backlight(s).
Signed-off-by: Peter Ujfalusi
---
Hi,
This patch is needed for 3.13 to get the LCD backlight to work again.
Regards,
Peter
arch/arm/boot/dts/omap4-sdp.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 5fc3f43..6f86db2 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -104,6 +104,7 @@
100 110 120 127
>;
default-brightness-level = <13>;
+ power-supply = <&vbat>;
};
sound {
--
1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
