Re: [PATCH] ARM: OMAP2+: gpmc: annotate exit sections properly

2012-10-08 Thread Tony Lindgren
* Afzal Mohammed af...@ti.com [121004 01:33]:
 compiler complained,
 `gpmc_remove' referenced in section `.data' of 
 arch/arm/mach-omap2/built-in.o: defined in discarded section `.exit.text' of 
 arch/arm/mach-omap2/built-in.o
 
 Annotate gpmc_remove function and dependents with __devexit.

Thanks applying into omap fixes.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] ARM: OMAP2+: gpmc: annotate exit sections properly

2012-10-04 Thread Afzal Mohammed
compiler complained,
`gpmc_remove' referenced in section `.data' of arch/arm/mach-omap2/built-in.o: 
defined in discarded section `.exit.text' of arch/arm/mach-omap2/built-in.o

Annotate gpmc_remove function and dependents with __devexit.

Reported-by: Tony Lindgren t...@atomide.com
Signed-off-by: Afzal Mohammed af...@ti.com
---

Hi,

Section mismatch occured due to my change,
ARM: OMAP2+: gpmc: minimal driver support.
As this change is not yet in vanilla, SHA1 has not been
mentioned in commit log. Original change that introduced the
above mentioned warning has as of now swimmed only till
linux-omap and linux-next.

This has been generated against linux-next (next-20121003)

Regards
Afzal

 arch/arm/mach-omap2/gpmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 8ab1e1b..5ac5cf3 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -838,7 +838,7 @@ static int gpmc_setup_irq(void)
return request_irq(gpmc_irq, gpmc_handle_irq, 0, gpmc, NULL);
 }
 
-static __exit int gpmc_free_irq(void)
+static __devexit int gpmc_free_irq(void)
 {
int i;
 
@@ -944,7 +944,7 @@ static __devinit int gpmc_probe(struct platform_device 
*pdev)
return 0;
 }
 
-static __exit int gpmc_remove(struct platform_device *pdev)
+static __devexit int gpmc_remove(struct platform_device *pdev)
 {
gpmc_free_irq();
gpmc_mem_exit();
-- 
1.7.12

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html