Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
* Chen Gang gang.c...@asianux.com [130204 18:22]: 于 2013年02月05日 02:18, Tony Lindgren 写道: * Peter Ujfalusi peter.ujfal...@ti.com [130204 01:04]: Hi Tony, I can create a branch for you in our gitorious tree (git://gitorious.org/omap-audio/linux-audio.git) for this patch. But I think for now it would be best if you could take this via linux-omap (the file is under arch/arm/mach-omap2 anyways) OK thanks I'll apply with your ack to omap-for-v3.9/fixes-noncritical. Tony Does it mean: we need not sync MAINTAINERS file for twl-*, recently ? :-) No we should still do it. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
于 2013年02月06日 02:56, Tony Lindgren 写道: * Chen Gang gang.c...@asianux.com [130204 18:22]: Does it mean: we need not sync MAINTAINERS file for twl-*, recently ? :-) No we should still do it. Tony ok, thanks. if necessary (no other members do it), I should perform. if really should I do: requirements: A) I should succeed provide at least 3 valuable patches to twl-* (or I am not qualified to provide the sync MAINTAINERS patch) B) relative member need give strictly checking for the patch. (so can evaluate whether I have been qualified) C) it is necessary to be monitored by the relative mailing lists. I should try: A) need mainly focus on the omap2, specially for twl-* B) the patch type should be for bug fixing: (I am not familiar with omap2, so can not for new features) i. memory override. ii. resource management. iii. others (compiling issue, type cast, ...) C) should provide 3 twl-* valuable patches within 1 month. (have finished one: strlcpy, in Jan 30 2013) (so need finish the other 2 patches, before Feb 28 2013) hope I can succeed. welcome any members to provide suggestions and completions. thanks. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
On 01/30/2013 12:46 PM, Chen Gang wrote:
the fields must be null-terminated:
the caller may use it as null-terminted string, next.
Signed-off-by: Chen Gang gang.c...@asianux.com
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/twl-common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/twl-common.c
b/arch/arm/mach-omap2/twl-common.c
index e49b40b..6a7aec6 100644
--- a/arch/arm/mach-omap2/twl-common.c
+++ b/arch/arm/mach-omap2/twl-common.c
@@ -23,6 +23,7 @@
#include linux/i2c.h
#include linux/i2c/twl.h
#include linux/gpio.h
+#include linux/string.h
#include linux/regulator/machine.h
#include linux/regulator/fixed.h
@@ -56,7 +57,7 @@ void __init omap_pmic_init(int bus, u32 clkrate,
struct twl4030_platform_data *pmic_data)
{
omap_mux_init_signal(sys_nirq, OMAP_PIN_INPUT_PULLUP |
OMAP_PIN_OFF_WAKEUPENABLE);
- strncpy(pmic_i2c_board_info.type, pmic_type,
+ strlcpy(pmic_i2c_board_info.type, pmic_type,
sizeof(pmic_i2c_board_info.type));
pmic_i2c_board_info.irq = pmic_irq;
pmic_i2c_board_info.platform_data = pmic_data;
--
Péter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
Hi Tony,
On 02/01/2013 11:45 PM, Tony Lindgren wrote:
* Chen Gang gang.c...@asianux.com [130130 03:50]:
the fields must be null-terminated:
the caller may use it as null-terminted string, next.
Added Peter to cc on this one too, it's best that he queues
all the twl changes.
I can create a branch for you in our gitorious tree
(git://gitorious.org/omap-audio/linux-audio.git) for this patch. But I think
for now it would be best if you could take this via linux-omap (the file is
under arch/arm/mach-omap2 anyways)
Regards,
Péter
Tony
Signed-off-by: Chen Gang gang.c...@asianux.com
---
arch/arm/mach-omap2/twl-common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/twl-common.c
b/arch/arm/mach-omap2/twl-common.c
index e49b40b..6a7aec6 100644
--- a/arch/arm/mach-omap2/twl-common.c
+++ b/arch/arm/mach-omap2/twl-common.c
@@ -23,6 +23,7 @@
#include linux/i2c.h
#include linux/i2c/twl.h
#include linux/gpio.h
+#include linux/string.h
#include linux/regulator/machine.h
#include linux/regulator/fixed.h
@@ -56,7 +57,7 @@ void __init omap_pmic_init(int bus, u32 clkrate,
struct twl4030_platform_data *pmic_data)
{
omap_mux_init_signal(sys_nirq, OMAP_PIN_INPUT_PULLUP |
OMAP_PIN_OFF_WAKEUPENABLE);
-strncpy(pmic_i2c_board_info.type, pmic_type,
+strlcpy(pmic_i2c_board_info.type, pmic_type,
sizeof(pmic_i2c_board_info.type));
pmic_i2c_board_info.irq = pmic_irq;
pmic_i2c_board_info.platform_data = pmic_data;
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
* Peter Ujfalusi peter.ujfal...@ti.com [130204 01:04]: Hi Tony, On 02/01/2013 11:45 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130130 03:50]: the fields must be null-terminated: the caller may use it as null-terminted string, next. Added Peter to cc on this one too, it's best that he queues all the twl changes. I can create a branch for you in our gitorious tree (git://gitorious.org/omap-audio/linux-audio.git) for this patch. But I think for now it would be best if you could take this via linux-omap (the file is under arch/arm/mach-omap2 anyways) OK thanks I'll apply with your ack to omap-for-v3.9/fixes-noncritical. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
于 2013年02月05日 02:18, Tony Lindgren 写道: * Peter Ujfalusi peter.ujfal...@ti.com [130204 01:04]: Hi Tony, I can create a branch for you in our gitorious tree (git://gitorious.org/omap-audio/linux-audio.git) for this patch. But I think for now it would be best if you could take this via linux-omap (the file is under arch/arm/mach-omap2 anyways) OK thanks I'll apply with your ack to omap-for-v3.9/fixes-noncritical. Tony Does it mean: we need not sync MAINTAINERS file for twl-*, recently ? :-) thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
于 2013年02月03日 02:07, Tony Lindgren 写道: is it suitable to sync the MAINTAINER file for it ? if suitable, can you help to change it ? Yes I suggest we add Peter as the maintainer for all twl related things. Regards, Tony ok, thanks. by the way: if necessary (not find another suitable members to sync it), I should sync it (since I found it) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
* Chen Gang gang.c...@asianux.com [130201 18:29]: 于 2013年02月02日 06:45, Tony Lindgren 写道: Added Peter to cc on this one too, it's best that he queues all the twl changes. is it suitable to sync the MAINTAINER file for it ? if suitable, can you help to change it ? Yes I suggest we add Peter as the maintainer for all twl related things. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
* Chen Gang gang.c...@asianux.com [130130 03:50]:
the fields must be null-terminated:
the caller may use it as null-terminted string, next.
Added Peter to cc on this one too, it's best that he queues
all the twl changes.
Tony
Signed-off-by: Chen Gang gang.c...@asianux.com
---
arch/arm/mach-omap2/twl-common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/twl-common.c
b/arch/arm/mach-omap2/twl-common.c
index e49b40b..6a7aec6 100644
--- a/arch/arm/mach-omap2/twl-common.c
+++ b/arch/arm/mach-omap2/twl-common.c
@@ -23,6 +23,7 @@
#include linux/i2c.h
#include linux/i2c/twl.h
#include linux/gpio.h
+#include linux/string.h
#include linux/regulator/machine.h
#include linux/regulator/fixed.h
@@ -56,7 +57,7 @@ void __init omap_pmic_init(int bus, u32 clkrate,
struct twl4030_platform_data *pmic_data)
{
omap_mux_init_signal(sys_nirq, OMAP_PIN_INPUT_PULLUP |
OMAP_PIN_OFF_WAKEUPENABLE);
- strncpy(pmic_i2c_board_info.type, pmic_type,
+ strlcpy(pmic_i2c_board_info.type, pmic_type,
sizeof(pmic_i2c_board_info.type));
pmic_i2c_board_info.irq = pmic_irq;
pmic_i2c_board_info.platform_data = pmic_data;
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:omap2: using strlcpy instead of strncpy
于 2013年02月02日 06:45, Tony Lindgren 写道: Added Peter to cc on this one too, it's best that he queues all the twl changes. is it suitable to sync the MAINTAINER file for it ? if suitable, can you help to change it ? thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM:omap2: using strlcpy instead of strncpy
the fields must be null-terminated:
the caller may use it as null-terminted string, next.
Signed-off-by: Chen Gang gang.c...@asianux.com
---
arch/arm/mach-omap2/twl-common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
index e49b40b..6a7aec6 100644
--- a/arch/arm/mach-omap2/twl-common.c
+++ b/arch/arm/mach-omap2/twl-common.c
@@ -23,6 +23,7 @@
#include linux/i2c.h
#include linux/i2c/twl.h
#include linux/gpio.h
+#include linux/string.h
#include linux/regulator/machine.h
#include linux/regulator/fixed.h
@@ -56,7 +57,7 @@ void __init omap_pmic_init(int bus, u32 clkrate,
struct twl4030_platform_data *pmic_data)
{
omap_mux_init_signal(sys_nirq, OMAP_PIN_INPUT_PULLUP |
OMAP_PIN_OFF_WAKEUPENABLE);
- strncpy(pmic_i2c_board_info.type, pmic_type,
+ strlcpy(pmic_i2c_board_info.type, pmic_type,
sizeof(pmic_i2c_board_info.type));
pmic_i2c_board_info.irq = pmic_irq;
pmic_i2c_board_info.platform_data = pmic_data;
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
