[PATCH] ASoC: tlv320aic31xx: Fix off by one error in the loop stucture.

2014-11-24 Thread Jyri Sarha
Fix off by one read beyond the end of a table.

Reported-by: David Binderman dcb...@hotmail.com
Signed-off-by: Jyri Sarha jsa...@ti.com
---
 sound/soc/codecs/tlv320aic31xx.c |   13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
index 145fe5b..93de5dd 100644
--- a/sound/soc/codecs/tlv320aic31xx.c
+++ b/sound/soc/codecs/tlv320aic31xx.c
@@ -911,12 +911,13 @@ static int aic31xx_set_dai_sysclk(struct snd_soc_dai 
*codec_dai,
}
aic31xx-p_div = i;
 
-   for (i = 0; aic31xx_divs[i].mclk_p != freq/aic31xx-p_div; i++) {
-   if (i == ARRAY_SIZE(aic31xx_divs)) {
-   dev_err(aic31xx-dev, %s: Unsupported frequency %d\n,
-   __func__, freq);
-   return -EINVAL;
-   }
+   for (i = 0; i  ARRAY_SIZE(aic31xx_divs) 
+aic31xx_divs[i].mclk_p != freq/aic31xx-p_div; i++)
+   ;
+   if (i == ARRAY_SIZE(aic31xx_divs)) {
+   dev_err(aic31xx-dev, %s: Unsupported frequency %d\n,
+   __func__, freq);
+   return -EINVAL;
}
 
/* set clock on MCLK, BCLK, or GPIO1 as PLL input */
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] ASoC: tlv320aic31xx: Fix off by one error in the loop stucture.

2014-11-24 Thread Mark Brown
On Mon, Nov 24, 2014 at 08:37:12PM +0200, Jyri Sarha wrote:
 Fix off by one read beyond the end of a table.

Applied, thanks.


signature.asc
Description: Digital signature