Re: [PATCH] N900: add device tree

2013-07-04 Thread Aaro Koskinen
On Mon, Jul 01, 2013 at 11:17:54PM +0200, Pavel Machek wrote:
 This adds device tree with neccessary support to boot with functional
 video (on both emulator and real N900 device).

Is this really correct? You have commented out the USB, so there is no
way for a developer to interact with the device.

Some minor issue too:

 +/*
 + * Copyright (C) 2013 Pavel Machek pa...@ucw.cz
 + * Copyright 2013 Aaro Koskinen aaro.koski...@iki.fi
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 (or later) 
 as
 + * published by the Free Software Foundation.

Should be just GPLv2.

A.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] N900: add device tree

2013-07-04 Thread Pavel Machek
Hi!

  This adds device tree with neccessary support to boot with functional
  video (on both emulator and real N900 device).
 
 Is this really correct? You have commented out the USB, so there is no
 way for a developer to interact with the device.

Well... I do not have USB  SDcard set up, so my testing was does it
show failed to mount root message on screen. 

Now, if I do quick test of enabling it on 3.9, I get:

  DTC arch/arm/boot/dts/omap3-n900.dtb
Error: arch/arm/boot/dts/omap3-n900.dts:92.2-3 label or path,
'usb_otg_hs', not found
FATAL ERROR: Syntax error parsing input tree
make[1]: *** [arch/arm/boot/dts/omap3-n900.dtb] Error 1
make: *** [dtbs] Error 2

. If you could test the patches with the USB support uncommented, that
would be very good...

Thanks,

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] N900: add device tree

2013-07-04 Thread Aaro Koskinen
Hi,

On Thu, Jul 04, 2013 at 10:21:45PM +0200, Pavel Machek wrote:
   This adds device tree with neccessary support to boot with functional
   video (on both emulator and real N900 device).
  
  Is this really correct? You have commented out the USB, so there is no
  way for a developer to interact with the device.
 
 Well... I do not have USB  SDcard set up, so my testing was does it
 show failed to mount root message on screen. 
 
 Now, if I do quick test of enabling it on 3.9, I get:
 
   DTC arch/arm/boot/dts/omap3-n900.dtb
 Error: arch/arm/boot/dts/omap3-n900.dts:92.2-3 label or path,
 'usb_otg_hs', not found
 FATAL ERROR: Syntax error parsing input tree
 make[1]: *** [arch/arm/boot/dts/omap3-n900.dtb] Error 1
 make: *** [dtbs] Error 2

You need 3.10. It was added in ad871c10b55654910ba97af00a00e65725da5e40
(ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards).

3.9 is very old. :-)

 If you could test the patches with the USB support uncommented, that
 would be very good...

I can do that, but not before next week.

A.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] N900: add device tree

2013-07-01 Thread Pavel Machek

This adds device tree with neccessary support to boot with functional
video (on both emulator and real N900 device).

Signed-off-by: Pavel Machek pa...@ucw.cz

--- linux-delme-clean//arch/arm/boot/dts/Makefile   2013-07-01 
21:51:00.0 +0200
+++ linux-delme/arch/arm/boot/dts/Makefile  2013-07-01 22:53:06.0 
+0200
@@ -141,6 +141,7 @@
omap3-devkit8000.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
+   omap3-n900.dtb \
omap3-tobi.dtb \
omap3-igep0020.dtb \
omap3-igep0030.dtb \
--- linux-delme-clean//arch/arm/boot/dts/omap3-n900.dts 1970-01-01 
01:00:00.0 +0100
+++ linux-delme/arch/arm/boot/dts/omap3-n900.dts2013-07-01 
22:50:21.0 +0200
@@ -0,0 +1,94 @@
+/*
+ * Copyright (C) 2013 Pavel Machek pa...@ucw.cz
+ * Copyright 2013 Aaro Koskinen aaro.koski...@iki.fi
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 (or later) as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+
+/include/ omap34xx.dtsi
+
+/ {
+   model = Nokia N900;
+   compatible = nokia,omap3-n900, ti,omap3;
+
+   cpus {
+   cpu@0 {
+// cpu0-supply = vcc;
+   };
+   };
+
+   memory {
+   device_type = memory;
+   reg = 0x8000 0x1000; /* 256 MB */
+   };
+
+};
+
+i2c1 {
+   clock-frequency = 220;
+
+   twl: twl@48 {
+   reg = 0x48;
+   interrupts = 7; /* SYS_NIRQ cascaded to intc */
+   interrupt-parent = intc;
+   };
+};
+
+/include/ twl4030.dtsi
+
+twl_gpio {
+   ti,pullups  = 0x0;
+   ti,pulldowns= 0x03ff3f; /* BIT(0..5) | BIT(8..17) */
+};
+
+i2c2 {
+   clock-frequency = 40;
+};
+
+i2c3 {
+   clock-frequency = 10;
+};
+
+mmc1 {
+   status = disabled;
+};
+
+mmc2 {
+   status = disabled;
+};
+
+mmc3 {
+   status = disabled;
+};
+
+mcspi1 {
+   // For some reason, touchscreen is neccessary for screen to work at 
+   // all on real hw. It works well without it on emulator.
+   //
+   // Also... order in the device tree actually matters here.
+   tsc2005@0 {
+   compatible = tsc2005;
+   spi-max-frequency = 600;
+   reg = 0;
+   };
+   mipid@2 {
+   compatible = acx565akm;
+   spi-max-frequency = 600;
+   reg = 2;
+   // turbo_mode = 0,
+   // cs_per_word = 0
+   };
+};
+
+/*
+usb_otg_hs {
+   interface-type = 0;
+   usb-phy = usb2_phy;
+   mode = 2;
+   power = 50;
+};
+*/

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html