RE: [PATCH] OMAP: Remove IRQ hardcoding from serial.c

2009-05-18 Thread Shilimkar, Santosh 
> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com] 
> Sent: Tuesday, May 19, 2009 3:16 AM
> To: Shilimkar, Santosh
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] OMAP: Remove IRQ hardcoding from serial.c
> 
> * Shilimkar, Santosh  [090513 07:53]:
> > Tony,
> > Any comments on this patch.
> > http://patchwork.kernel.org/patch/19161/
> 
> We should just set the interrupts etc dynamically using the
> cpu_is_omap() functions.
That's indeed a good idea. But then are we going to remove this information 
from platform structures. If not then hardcoding is still bad and should be 
removed.

Regards,
Santosh
 --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP: Remove IRQ hardcoding from serial.c

2009-05-18 Thread Tony Lindgren 
* Shilimkar, Santosh  [090513 07:53]:
> Tony,
> Any comments on this patch.
> http://patchwork.kernel.org/patch/19161/

We should just set the interrupts etc dynamically using the
cpu_is_omap() functions.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re:[PATCH] OMAP: Remove IRQ hardcoding from serial.c

2009-05-15 Thread Govindraj.R 
Hi Santosh,

Where you will be defining INT_24XX_UART1_IRQ, INT_24XX_UART1_IRQ and
INT_24XX_UART3_IRQ ?

Is it in include/asm-arm/arch-omap/serial.h?
-- 
Regards,
Govindraj.R

> -- Forwarded message --
> From: Shilimkar, Santosh 
> Date: Wed, May 13, 2009 at 8:23 PM
> Subject: [PATCH] OMAP: Remove IRQ hardcoding from serial.c
> To: Tony Lindgren 
> Cc: "linux-omap@vger.kernel.org" 
>
>
> Tony,
> Any comments on this patch.
> http://patchwork.kernel.org/patch/19161/
>
> Regards
> Santosh
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] OMAP: Remove IRQ hardcoding from serial.c

2009-05-13 Thread Shilimkar, Santosh 
Tony,
Any comments on this patch.
http://patchwork.kernel.org/patch/19161/

Regards
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] OMAP: Remove IRQ hardcoding from serial.c

2009-04-21 Thread Santosh Shilimkar 
This patch removes hardcoding done for UART IRQ lines
from serial.c file.

Signed-off-by: Santosh Shilimkar 
---
 arch/arm/mach-omap2/serial.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index 4dcf39c..f7a3090 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -29,7 +29,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
{
.membase= IO_ADDRESS(OMAP_UART1_BASE),
.mapbase= OMAP_UART1_BASE,
-   .irq= 72,
+   .irq= INT_24XX_UART1_IRQ,
.flags  = UPF_BOOT_AUTOCONF,
.iotype = UPIO_MEM,
.regshift   = 2,
@@ -37,7 +37,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
}, {
.membase= IO_ADDRESS(OMAP_UART2_BASE),
.mapbase= OMAP_UART2_BASE,
-   .irq= 73,
+   .irq= INT_24XX_UART2_IRQ,
.flags  = UPF_BOOT_AUTOCONF,
.iotype = UPIO_MEM,
.regshift   = 2,
@@ -45,7 +45,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
}, {
.membase= IO_ADDRESS(OMAP_UART3_BASE),
.mapbase= OMAP_UART3_BASE,
-   .irq= 74,
+   .irq= INT_24XX_UART3_IRQ,
.flags  = UPF_BOOT_AUTOCONF,
.iotype = UPIO_MEM,
.regshift   = 2,
-- 
1.5.4.7

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html