Re: [PATCH] OMAP3: PM: Remove duplicate code blocks
Sanjeev Premi writes: > This patch removes code blocks that are repeated > in function prcm_setup_regs(). > > Signed-off-by: Sanjeev Premi Thanks, pulling into PM branch, queueing for pm-fixes. Kevin > --- > arch/arm/mach-omap2/pm34xx.c | 18 -- > 1 files changed, 0 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index fd103a1..11cfe59 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -957,24 +957,6 @@ static void __init prcm_setup_regs(void) > /* Clear any pending PRCM interrupts */ > prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); > > - /* Don't attach IVA interrupts */ > - prm_write_mod_reg(0, WKUP_MOD, OMAP3430_PM_IVAGRPSEL); > - prm_write_mod_reg(0, CORE_MOD, OMAP3430_PM_IVAGRPSEL1); > - prm_write_mod_reg(0, CORE_MOD, OMAP3430ES2_PM_IVAGRPSEL3); > - prm_write_mod_reg(0, OMAP3430_PER_MOD, OMAP3430_PM_IVAGRPSEL); > - > - /* Clear any pending 'reset' flags */ > - prm_write_mod_reg(0x, MPU_MOD, RM_RSTST); > - prm_write_mod_reg(0x, CORE_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_PER_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_EMU_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_NEON_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_DSS_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430ES2_USBHOST_MOD, RM_RSTST); > - > - /* Clear any pending PRCM interrupts */ > - prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); > - > omap3_iva_idle(); > omap3_d2d_idle(); > } > -- > 1.6.2.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] OMAP3: PM: Remove duplicate code blocks
This patch removes code blocks that are repeated in function prcm_setup_regs(). Signed-off-by: Sanjeev Premi --- arch/arm/mach-omap2/pm34xx.c | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index fd103a1..11cfe59 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -957,24 +957,6 @@ static void __init prcm_setup_regs(void) /* Clear any pending PRCM interrupts */ prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); - /* Don't attach IVA interrupts */ - prm_write_mod_reg(0, WKUP_MOD, OMAP3430_PM_IVAGRPSEL); - prm_write_mod_reg(0, CORE_MOD, OMAP3430_PM_IVAGRPSEL1); - prm_write_mod_reg(0, CORE_MOD, OMAP3430ES2_PM_IVAGRPSEL3); - prm_write_mod_reg(0, OMAP3430_PER_MOD, OMAP3430_PM_IVAGRPSEL); - - /* Clear any pending 'reset' flags */ - prm_write_mod_reg(0x, MPU_MOD, RM_RSTST); - prm_write_mod_reg(0x, CORE_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_PER_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_EMU_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_NEON_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_DSS_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430ES2_USBHOST_MOD, RM_RSTST); - - /* Clear any pending PRCM interrupts */ - prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); - omap3_iva_idle(); omap3_d2d_idle(); } -- 1.6.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP3: PM: Remove duplicate code
Roger Quadros writes: > Signed-off-by: Roger Quadros Hmm, you don't think I need to be so careful as to do it twice. ;) I'll drop these duplicates when I rebase onto latest omap/master. Thanks, Kevin > --- > arch/arm/mach-omap2/pm34xx.c | 18 -- > 1 files changed, 0 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index 7a4a525..d45295d 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -913,24 +913,6 @@ static void __init prcm_setup_regs(void) > /* Clear any pending PRCM interrupts */ > prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); > > - /* Don't attach IVA interrupts */ > - prm_write_mod_reg(0, WKUP_MOD, OMAP3430_PM_IVAGRPSEL); > - prm_write_mod_reg(0, CORE_MOD, OMAP3430_PM_IVAGRPSEL1); > - prm_write_mod_reg(0, CORE_MOD, OMAP3430ES2_PM_IVAGRPSEL3); > - prm_write_mod_reg(0, OMAP3430_PER_MOD, OMAP3430_PM_IVAGRPSEL); > - > - /* Clear any pending 'reset' flags */ > - prm_write_mod_reg(0x, MPU_MOD, RM_RSTST); > - prm_write_mod_reg(0x, CORE_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_PER_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_EMU_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_NEON_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430_DSS_MOD, RM_RSTST); > - prm_write_mod_reg(0x, OMAP3430ES2_USBHOST_MOD, RM_RSTST); > - > - /* Clear any pending PRCM interrupts */ > - prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); > - > omap3_iva_idle(); > omap3_d2d_idle(); > } > -- > 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] OMAP3: PM: Remove duplicate code
Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/pm34xx.c | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 7a4a525..d45295d 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -913,24 +913,6 @@ static void __init prcm_setup_regs(void) /* Clear any pending PRCM interrupts */ prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); - /* Don't attach IVA interrupts */ - prm_write_mod_reg(0, WKUP_MOD, OMAP3430_PM_IVAGRPSEL); - prm_write_mod_reg(0, CORE_MOD, OMAP3430_PM_IVAGRPSEL1); - prm_write_mod_reg(0, CORE_MOD, OMAP3430ES2_PM_IVAGRPSEL3); - prm_write_mod_reg(0, OMAP3430_PER_MOD, OMAP3430_PM_IVAGRPSEL); - - /* Clear any pending 'reset' flags */ - prm_write_mod_reg(0x, MPU_MOD, RM_RSTST); - prm_write_mod_reg(0x, CORE_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_PER_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_EMU_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_NEON_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430_DSS_MOD, RM_RSTST); - prm_write_mod_reg(0x, OMAP3430ES2_USBHOST_MOD, RM_RSTST); - - /* Clear any pending PRCM interrupts */ - prm_write_mod_reg(0, OCP_MOD, OMAP3_PRM_IRQSTATUS_MPU_OFFSET); - omap3_iva_idle(); omap3_d2d_idle(); } -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html