Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros
On Thu, Apr 28, 2011 at 12:47:25PM -0700, Greg KH wrote: On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote: From Sutharsan Ramamoorthy s...@cypress.com This patch replaces custom debug macros with Linux kernel's pr_...() macros. Why not use the dev_dbg() and other macros instead of these? You do have access to a struct device for all of these places in the code, right? As I never got a response from you, I'm dropping this from my patch-queue. Please resend when you have addressed this issue. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros
On Thu, 28 Apr 2011 20:48:41 +0200, Sutharsan sutharsan.t...@gmail.com
wrote:
@@ -2121,7 +2121,7 @@ static int cyasgadget_initialize(void)
cy_as_dev-dev_handle = cyasdevice_getdevhandle();
if (0 == cy_as_dev-dev_handle) {
#ifndef NDEBUG
- cy_as_hal_print_message(1 cy_as_gadget:
+ pr_debug(1 cy_as_gadget:
no west bridge device\n);
#endif
retval = -EFAULT;
That's actually incorrect. You should not have 1 in the
string. Not only that, 1 means that the message was actually
KERN_ALERT not KERN_DEBUG -- it looks like that is a mistake though.
At any rate, though, if you are using pr_debug() you don't need to
check for NDEBUG macro.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal mina86 Nazarewicz(o o)
ooo +-email/xmpp: mnazarew...@google.com-ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros
On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote: From Sutharsan Ramamoorthy s...@cypress.com This patch replaces custom debug macros with Linux kernel's pr_...() macros. Why not use the dev_dbg() and other macros instead of these? You do have access to a struct device for all of these places in the code, right? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
