Re: [PATCH] arm: dts: AM43x: Add usb_otg_hs node

2013-07-07 Thread George Cherian 

On 7/7/2013 2:05 PM, Felipe Balbi wrote:

Hi,

On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote:

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index ddc1df7..e4f5eb8 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -64,5 +64,24 @@
compatible = 
"ti,am4372-counter32k","ti,omap-counter32k";
reg = <0x44e86000 0x40>;
};
+
+   usb_otg_hs1: am4372_dwc3@4838 {
+   compatible = "ti,am437x-dwc3";
+   reg = <0x4838 0x1ff>;
+   interrupts = ;
+   #address-cells = <1>;
+   #size-cells = <1>;
+   utmi-mode = <1>;
+   ranges;
+
+   dwc3@4839 {
+   compatible = "synopsys,dwc3";

let's us snps,dwc3. I recently posted a patch converting synopsys to
snps like all other DesignWare drivers. Support for synopsys,dwc3 is
still there, but shouldn't be used.

okay



+   reg = <0x4839 0xcfff>;
+   interrupts = ;
+   tx-fifo-resize;

is this flag *really* necessary, I asked you and didn't get an answer.
We will not be needing this flag , since each EP has 3K tx fifo size. 
Also given the fact that we will be operating only

in 2.0 mode the default values are only sufficient.
I will re-send the patch with above changes.

Regards,
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm: dts: AM43x: Add usb_otg_hs node

2013-07-07 Thread Felipe Balbi 
Hi,

On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote:
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index ddc1df7..e4f5eb8 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -64,5 +64,24 @@
>   compatible = 
> "ti,am4372-counter32k","ti,omap-counter32k";
>   reg = <0x44e86000 0x40>;
>   };
> +
> + usb_otg_hs1: am4372_dwc3@4838 {
> + compatible = "ti,am437x-dwc3";
> + reg = <0x4838 0x1ff>;
> + interrupts = ;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + utmi-mode = <1>;
> + ranges;
> +
> + dwc3@4839 {
> + compatible = "synopsys,dwc3";

let's us snps,dwc3. I recently posted a patch converting synopsys to
snps like all other DesignWare drivers. Support for synopsys,dwc3 is
still there, but shouldn't be used.

> + reg = <0x4839 0xcfff>;
> + interrupts = ;
> + tx-fifo-resize;

is this flag *really* necessary, I asked you and didn't get an answer.

-- 
balbi


signature.asc
Description: Digital signature

[PATCH] arm: dts: AM43x: Add usb_otg_hs node

2013-06-27 Thread George Cherian 
Adds device node for HS USB Host module for AM437x

Signed-off-by: George Cherian 
---
 This patch is on top of 
 git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git 
for_3.11/dts

 arch/arm/boot/dts/am4372.dtsi | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index ddc1df7..e4f5eb8 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -64,5 +64,24 @@
compatible = 
"ti,am4372-counter32k","ti,omap-counter32k";
reg = <0x44e86000 0x40>;
};
+
+   usb_otg_hs1: am4372_dwc3@4838 {
+   compatible = "ti,am437x-dwc3";
+   reg = <0x4838 0x1ff>;
+   interrupts = ;
+   #address-cells = <1>;
+   #size-cells = <1>;
+   utmi-mode = <1>;
+   ranges;
+
+   dwc3@4839 {
+   compatible = "synopsys,dwc3";
+   reg = <0x4839 0xcfff>;
+   interrupts = ;
+   tx-fifo-resize;
+   };
+
+   };
+
};
 };
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html