Re: [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register(v1)
Tony, On Wed, Jan 05, 2011 at 10:03:21PM +0800, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com Panda uses both twl6030 otg phy(vbus, id) and internal phy(data lines, DP/DM), so removes usb_nop_xceiv_register to make twl6030 otg driver working since current otg code only supports one global transceiver. Otherwise, musb doesn't work without the remove. Reviewd-by: Felipe Balbi ba...@ti.com Signed-off-by: Ming Lei tom.leim...@gmail.com Care to queue this together with your fixes -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register(v1)
On Wed, Feb 02, 2011 at 01:37:17PM +0200, Felipe Balbi wrote: Tony, On Wed, Jan 05, 2011 at 10:03:21PM +0800, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com Panda uses both twl6030 otg phy(vbus, id) and internal phy(data lines, DP/DM), so removes usb_nop_xceiv_register to make twl6030 otg driver working since current otg code only supports one global transceiver. Otherwise, musb doesn't work without the remove. Reviewd-by: Felipe Balbi ba...@ti.com Signed-off-by: Ming Lei tom.leim...@gmail.com Care to queue this together with your fixes Without this patch, MUSB doesn't work on pandaboard. if you want in a pull request form, here it is: The following changes since commit ebf53826e105f488f4f628703a108e98940d1dc5: Linux 2.6.38-rc3 (2011-02-01 13:05:49 +1000) are available in the git repository at: git://gitorious.org/usb/usb.git for-tony Ming Lei (1): arm: omap4: panda: remove usb_nop_xceiv_register(v1) arch/arm/mach-omap2/board-omap4panda.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register(v1)
* Felipe Balbi ba...@ti.com [110202 03:56]: On Wed, Feb 02, 2011 at 01:37:17PM +0200, Felipe Balbi wrote: Tony, On Wed, Jan 05, 2011 at 10:03:21PM +0800, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com Panda uses both twl6030 otg phy(vbus, id) and internal phy(data lines, DP/DM), so removes usb_nop_xceiv_register to make twl6030 otg driver working since current otg code only supports one global transceiver. Otherwise, musb doesn't work without the remove. Reviewd-by: Felipe Balbi ba...@ti.com Signed-off-by: Ming Lei tom.leim...@gmail.com Care to queue this together with your fixes Without this patch, MUSB doesn't work on pandaboard. Thanks, applied it to devel-fixes. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] arm: omap4: panda: remove usb_nop_xceiv_register(v1)
From: Ming Lei tom.leim...@gmail.com Panda uses both twl6030 otg phy(vbus, id) and internal phy(data lines, DP/DM), so removes usb_nop_xceiv_register to make twl6030 otg driver working since current otg code only supports one global transceiver. Otherwise, musb doesn't work without the remove. Reviewd-by: Felipe Balbi ba...@ti.com Signed-off-by: Ming Lei tom.leim...@gmail.com --- v1: fix commit log pointed by Felipe. --- arch/arm/mach-omap2/board-omap4panda.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c index 1ecd0a6..802ae20 100644 --- a/arch/arm/mach-omap2/board-omap4panda.c +++ b/arch/arm/mach-omap2/board-omap4panda.c @@ -374,8 +374,6 @@ static void __init omap4_panda_init(void) platform_add_devices(panda_devices, ARRAY_SIZE(panda_devices)); omap_serial_init(); omap4_twl6030_hsmmc_init(mmc); - /* OMAP4 Panda uses internal transceiver so register nop transceiver */ - usb_nop_xceiv_register(); omap4_ehci_init(); /* FIXME: allow multi-omap to boot until musb is updated for omap4 */ if (!cpu_is_omap44xx()) -- 1.7.3 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
