Re: [PATCH] clk: ti: dra7-atl-clock: fix a memory leak

2014-09-29 Thread Tero Kristo 

On 09/15/2014 12:05 PM, Peter Ujfalusi wrote:

On 09/12/2014 04:39 PM, Tero Kristo wrote:

of_clk_add_provider makes an internal copy of the parent_names property
while its called, thus it is no longer needed after this call and can
be freed.


Thanks Tero, indeed this was overlooked in the original driver.

Acked-by: Peter Ujfalusi 


Applied to for-v3.18/ti-clk-driver.

-Tero





Signed-off-by: Tero Kristo 
Cc: Mike Turquette 
Cc: Peter Ujfalusi 
---
  drivers/clk/ti/clk-dra7-atl.c |1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 4a65b41..3f9308a 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -199,6 +199,7 @@ static void __init of_dra7_atl_clock_setup(struct 
device_node *node)

if (!IS_ERR(clk)) {
of_clk_add_provider(node, of_clk_src_simple_get, clk);
+   kfree(parent_names);
return;
}
  cleanup:






--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] clk: ti: dra7-atl-clock: fix a memory leak

2014-09-15 Thread Peter Ujfalusi 
On 09/12/2014 04:39 PM, Tero Kristo wrote:
> of_clk_add_provider makes an internal copy of the parent_names property
> while its called, thus it is no longer needed after this call and can
> be freed.

Thanks Tero, indeed this was overlooked in the original driver.

Acked-by: Peter Ujfalusi 


> Signed-off-by: Tero Kristo 
> Cc: Mike Turquette 
> Cc: Peter Ujfalusi 
> ---
>  drivers/clk/ti/clk-dra7-atl.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index 4a65b41..3f9308a 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -199,6 +199,7 @@ static void __init of_dra7_atl_clock_setup(struct 
> device_node *node)
>  
>   if (!IS_ERR(clk)) {
>   of_clk_add_provider(node, of_clk_src_simple_get, clk);
> + kfree(parent_names);
>   return;
>   }
>  cleanup:
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] clk: ti: dra7-atl-clock: fix a memory leak

2014-09-12 Thread Tero Kristo 
of_clk_add_provider makes an internal copy of the parent_names property
while its called, thus it is no longer needed after this call and can
be freed.

Signed-off-by: Tero Kristo 
Cc: Mike Turquette 
Cc: Peter Ujfalusi 
---
 drivers/clk/ti/clk-dra7-atl.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 4a65b41..3f9308a 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -199,6 +199,7 @@ static void __init of_dra7_atl_clock_setup(struct 
device_node *node)
 
if (!IS_ERR(clk)) {
of_clk_add_provider(node, of_clk_src_simple_get, clk);
+   kfree(parent_names);
return;
}
 cleanup:
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html