Re: [PATCH] omap: 3630: update is_chip variable
2009/10/20 Vikram Pandita vikram.pand...@ti.com: 3630 is getting treated like next rev of 3430 omap_chip.oc variable has to be updated for 3630 version Otherwise the Core power domain is not getting registered. This gets used in the registration of power domains in: arch/arm/mach-omap2/powerdomains34xx.h core_34xx_es3_1_pwrdm OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1) Core power doman will get registered for 3630 only when .oc is pouplated correctly. Tested on Zoom3(3630) board Signed-off-by: Vikram Pandita vikram.pand...@ti.com FWIW, Signed-off-by: Alexander Shishkin virtu...@slind.org This version seems to be the common consensus (per discussion in v2 thread). Regards, -- Alex -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] omap: 3630: update is_chip variable
On Mon, Nov 02, 2009 at 07:05:49PM +0200, Alexander Shishkin wrote: 2009/10/20 Vikram Pandita vikram.pand...@ti.com: 3630 is getting treated like next rev of 3430 omap_chip.oc variable has to be updated for 3630 version Otherwise the Core power domain is not getting registered. This gets used in the registration of power domains in: arch/arm/mach-omap2/powerdomains34xx.h core_34xx_es3_1_pwrdm OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1) Core power doman will get registered for 3630 only when .oc is pouplated correctly. Tested on Zoom3(3630) board Signed-off-by: Vikram Pandita vikram.pand...@ti.com FWIW, Signed-off-by: Alexander Shishkin virtu...@slind.org Please excuse me, I obviously wanted to say Acked-by: Alexander Shishkin virtu...@slind.org Regards, -- Alex -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] omap: 3630: update is_chip variable
-Original Message- From: Alexander Shishkin [mailto:virtu...@slind.org] Sent: Monday, November 02, 2009 12:29 PM To: Pandita, Vikram Cc: linux-omap@vger.kernel.org; Menon, Nishanth Subject: Re: [PATCH] omap: 3630: update is_chip variable On Mon, Nov 02, 2009 at 07:05:49PM +0200, Alexander Shishkin wrote: 2009/10/20 Vikram Pandita vikram.pand...@ti.com: 3630 is getting treated like next rev of 3430 omap_chip.oc variable has to be updated for 3630 version Otherwise the Core power domain is not getting registered. This gets used in the registration of power domains in: arch/arm/mach-omap2/powerdomains34xx.h core_34xx_es3_1_pwrdm OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1) Core power doman will get registered for 3630 only when .oc is pouplated correctly. Tested on Zoom3(3630) board Signed-off-by: Vikram Pandita vikram.pand...@ti.com FWIW, Signed-off-by: Alexander Shishkin virtu...@slind.org Please excuse me, I obviously wanted to say Acked-by: Alexander Shishkin virtu...@slind.org Posting Ver 3 of the patch as the current patch [1] does not apply because of header file changes. Regards, Vikram [1] http://patchwork.kernel.org/patch/54847/ Regards, -- Alex -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] omap: 3630: update is_chip variable
3630 is getting treated like next rev of 3430
omap_chip.oc variable has to be updated for 3630 version
Otherwise the Core power domain is not getting registered.
This gets used in the registration of power domains in:
arch/arm/mach-omap2/powerdomains34xx.h
core_34xx_es3_1_pwrdm
OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1)
Core power doman will get registered for 3630 only when .oc is pouplated
correctly.
Tested on Zoom3(3630) board
Signed-off-by: Vikram Pandita vikram.pand...@ti.com
---
arch/arm/mach-omap2/id.c |2 ++
arch/arm/plat-omap/include/mach/cpu.h |7 +--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 71d5568..ebf3654 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -359,6 +359,8 @@ void __init omap2_check_revision(void)
omap_chip.oc |= CHIP_IS_OMAP3430ES3_0;
else if (omap_rev() == OMAP3430_REV_ES3_1)
omap_chip.oc |= CHIP_IS_OMAP3430ES3_1;
+ else if (omap_rev() == OMAP3630_REV_ES1_0)
+ omap_chip.oc |= CHIP_IS_OMAP3630ES1;
} else {
pr_err(Uninitialized omap_chip, please fix!\n);
}
diff --git a/arch/arm/plat-omap/include/mach/cpu.h
b/arch/arm/plat-omap/include/mach/cpu.h
index 7cb0556..05a0a33 100644
--- a/arch/arm/plat-omap/include/mach/cpu.h
+++ b/arch/arm/plat-omap/include/mach/cpu.h
@@ -454,6 +454,7 @@ IS_OMAP_TYPE(3430, 0x3430)
#define CHIP_IS_OMAP3430ES2(1 4)
#define CHIP_IS_OMAP3430ES3_0 (1 5)
#define CHIP_IS_OMAP3430ES3_1 (1 6)
+#define CHIP_IS_OMAP3630ES1(1 7)
#define CHIP_IS_OMAP24XX (CHIP_IS_OMAP2420 | CHIP_IS_OMAP2430)
@@ -465,8 +466,10 @@ IS_OMAP_TYPE(3430, 0x3430)
*/
#define CHIP_GE_OMAP3430ES2(CHIP_IS_OMAP3430ES2 | \
CHIP_IS_OMAP3430ES3_0 | \
-CHIP_IS_OMAP3430ES3_1)
-#define CHIP_GE_OMAP3430ES3_1 (CHIP_IS_OMAP3430ES3_1)
+CHIP_IS_OMAP3430ES3_1 | \
+CHIP_IS_OMAP3630ES1)
+#define CHIP_GE_OMAP3430ES3_1 (CHIP_IS_OMAP3430ES3_1 | \
+CHIP_IS_OMAP3630ES1)
int omap_chip_is(struct omap_chip_id oci);
--
1.6.5.rc1.19.g8426
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] omap: 3630: update is_chip variable
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Pandita, Vikram Sent: Monday, October 19, 2009 4:58 PM diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat- omap/include/mach/cpu.h index 7cb0556..05a0a33 100644 --- a/arch/arm/plat-omap/include/mach/cpu.h +++ b/arch/arm/plat-omap/include/mach/cpu.h @@ -454,6 +454,7 @@ IS_OMAP_TYPE(3430, 0x3430) #define CHIP_IS_OMAP3430ES2 (1 4) #define CHIP_IS_OMAP3430ES3_0(1 5) #define CHIP_IS_OMAP3430ES3_1(1 6) Should we add a little space for 3430 to grow? Current TRM already defines a 3.1.2. For this version changes are transparent to software. IIRC mostly internal cell tweaks to allow for expanded operating range. The CONTROL.CONTROL_IDCODE value is 0x0B6D 602F for OMAP34xx ES1.0. The CONTROL.CONTROL_IDCODE value is 0x1B7A E02F for OMAP34xx ES2.0. The CONTROL.CONTROL_IDCODE value is 0x2B7A E02F for OMAP34xx ES2.1. The CONTROL.CONTROL_IDCODE value is 0x3B7A E02F for OMAP34xx ES3.0. The CONTROL.CONTROL_IDCODE value is 0x4B7A E02F for OMAP34xx ES3.1. The CONTROL.CONTROL_IDCODE value is 0x7B7A E02F for OMAP34xx ES3.1.2. +#define CHIP_IS_OMAP3630ES1 (1 7) Its hard to guess how many more will come. Ideally it will be 3630 which is growing from this point on. It is faster/smaller/cheaper along with some bug fixes. Regards, Richard W. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] omap: 3630: update is_chip variable
-Original Message-
From: Woodruff, Richard
Sent: Monday, October 19, 2009 5:18 PM
To: Pandita, Vikram; linux-omap@vger.kernel.org
Cc: Menon, Nishanth
Subject: RE: [PATCH] omap: 3630: update is_chip variable
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Pandita, Vikram
Sent: Monday, October 19, 2009 4:58 PM
diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat-
omap/include/mach/cpu.h
index 7cb0556..05a0a33 100644
--- a/arch/arm/plat-omap/include/mach/cpu.h
+++ b/arch/arm/plat-omap/include/mach/cpu.h
@@ -454,6 +454,7 @@ IS_OMAP_TYPE(3430, 0x3430)
#define CHIP_IS_OMAP3430ES2 (1 4)
#define CHIP_IS_OMAP3430ES3_0 (1 5)
#define CHIP_IS_OMAP3430ES3_1 (1 6)
Should we add a little space for 3430 to grow? Current TRM already defines a
3.1.2. For this version
changes are transparent to software. IIRC mostly internal cell tweaks to
allow for expanded
operating range.
The CONTROL.CONTROL_IDCODE value is 0x0B6D 602F for OMAP34xx ES1.0.
The CONTROL.CONTROL_IDCODE value is 0x1B7A E02F for OMAP34xx ES2.0.
The CONTROL.CONTROL_IDCODE value is 0x2B7A E02F for OMAP34xx ES2.1.
The CONTROL.CONTROL_IDCODE value is 0x3B7A E02F for OMAP34xx ES3.0.
The CONTROL.CONTROL_IDCODE value is 0x4B7A E02F for OMAP34xx ES3.1.
The CONTROL.CONTROL_IDCODE value is 0x7B7A E02F for OMAP34xx ES3.1.2.
+#define CHIP_IS_OMAP3630ES1 (1 7)
In that case we have to be careful.
arch/arm/plat-omap/include/mach/cpu.h
struct omap_chip_id {
u8 oc;
u8 type;
};
Type is u8 and we already are using the 8th bit now (17)
So a type u8 - u16 will also be needed.
Its hard to guess how many more will come. Ideally it will be 3630 which is
growing from this point
on. It is faster/smaller/cheaper along with some bug fixes.
Regards,
Richard W.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] omap: 3630: update is_chip variable
-Original Message-
From: Pandita, Vikram
Sent: Monday, October 19, 2009 5:25 PM
To: Woodruff, Richard; linux-omap@vger.kernel.org
From: Woodruff, Richard
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Pandita, Vikram
diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat-
omap/include/mach/cpu.h
index 7cb0556..05a0a33 100644
--- a/arch/arm/plat-omap/include/mach/cpu.h
+++ b/arch/arm/plat-omap/include/mach/cpu.h
@@ -454,6 +454,7 @@ IS_OMAP_TYPE(3430, 0x3430)
#define CHIP_IS_OMAP3430ES2 (1 4)
#define CHIP_IS_OMAP3430ES3_0 (1 5)
#define CHIP_IS_OMAP3430ES3_1 (1 6)
Should we add a little space for 3430 to grow? Current TRM already
defines a 3.1.2. For this version
changes are transparent to software. IIRC mostly internal cell tweaks to
allow for expanded
operating range.
The CONTROL.CONTROL_IDCODE value is 0x0B6D 602F for OMAP34xx ES1.0.
The CONTROL.CONTROL_IDCODE value is 0x1B7A E02F for OMAP34xx ES2.0.
The CONTROL.CONTROL_IDCODE value is 0x2B7A E02F for OMAP34xx ES2.1.
The CONTROL.CONTROL_IDCODE value is 0x3B7A E02F for OMAP34xx ES3.0.
The CONTROL.CONTROL_IDCODE value is 0x4B7A E02F for OMAP34xx ES3.1.
The CONTROL.CONTROL_IDCODE value is 0x7B7A E02F for OMAP34xx ES3.1.2.
+#define CHIP_IS_OMAP3630ES1 (1 7)
In that case we have to be careful.
arch/arm/plat-omap/include/mach/cpu.h
struct omap_chip_id {
u8 oc;
u8 type;
};
Type is u8 and we already are using the 8th bit now (17)
So a type u8 - u16 will also be needed.
Requesting a u32 to try future proofing?
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
