[PATCH] omap_hsmmc: Add missing probe handler hook

2009-10-08 Thread Tony Lindgren 
Andrew,

Here's a fix from Roger Quadros that was accidentally not posted
to linux-mmc as pointed out by Felipe Contreras on LKML.

Can you please pick it up?

For reference, this is the issue Uwe Kleine-König mentioned at:
http://www.mail-archive.com/linux-...@vger.kernel.org/msg00528.html

Felipe Contreras summarized how things broke at:
http://lkml.org/lkml/2009/10/8/334

Regards,

Tony
Content-Type: text/plain; charset=utf-8
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [v2] omap_hsmmc: Add missing probe handler hook
Date: Fri, 02 Oct 2009 12:22:40 -
From: Roger Quadros ext-roger.quad...@nokia.com
X-Patchwork-Id: 51344

The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.

We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
device.

Signed-off-by: Roger Quadros ext-roger.quad...@nokia.com
Tested-by: Felipe Contreras felipe.contre...@gmail.com
Tested-by: Tony Lindgren t...@atomide.com

---
drivers/mmc/host/omap_hsmmc.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..0aecaae 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
 static int __init omap_hsmmc_init(void)
 {
 	/* Register the MMC driver */
-	return platform_driver_register(omap_hsmmc_driver);
+	return platform_driver_probe(omap_hsmmc_driver, omap_hsmmc_probe);
 }
 
 static void __exit omap_hsmmc_cleanup(void)

Re: [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data

2009-10-02 Thread Roger Quadros 

ext Rok Markovič wrote:
This is not the correct way to do it. There was some conflict during merge in 
init function. Correct patch should look like this:


--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
 static int __init omap_hsmmc_init(void)
 {
/* Register the MMC driver */
-   return platform_driver_register(omap_hsmmc_driver);
+   return platform_driver_probe(omap_hsmmc_driver, omap_hsmmc_probe);
 }

 static void __exit omap_hsmmc_cleanup(void)

Rok



Oh yes. Since omap_hsmmc is not a hot-pluggable device.
Will send a v2.

Thanks Rok, for pointing this out.




Dne četrtek 1. oktobra 2009 ob 16:39:13 ste napisali:

The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.

Signed-off-by: Roger Quadros ext-roger.quad...@nokia.com
---
 drivers/mmc/host/omap_hsmmc.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..26abe1e 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2001,6 +2001,7 @@ clk_en_err:
 #endif

 static struct platform_driver omap_hsmmc_driver = {
+   .probe  = omap_hsmmc_probe,
.remove = omap_hsmmc_remove,
.suspend= omap_hsmmc_suspend,
.resume = omap_hsmmc_resume,



--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data

2009-10-01 Thread Roger Quadros 
The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.

Signed-off-by: Roger Quadros ext-roger.quad...@nokia.com
---
 drivers/mmc/host/omap_hsmmc.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..26abe1e 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2001,6 +2001,7 @@ clk_en_err:
 #endif
 
 static struct platform_driver omap_hsmmc_driver = {
+   .probe  = omap_hsmmc_probe,
.remove = omap_hsmmc_remove,
.suspend= omap_hsmmc_suspend,
.resume = omap_hsmmc_resume,
-- 
1.6.0.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[APPLIED] [PATCH] omap_hsmmc: Add missing probe handler hook to platform

2009-10-01 Thread Tony Lindgren 
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes-testing

Initial commit ID (Likely to change): ff50faceca4c78184af7087e2368a5c869688755

PatchWorks
http://patchwork.kernel.org/patch/50970/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=ff50faceca4c78184af7087e2368a5c869688755


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html