Re: [PATCH] rtc-twl: Switch to using threaded irq
On Mon, 2011-06-27 at 18:45 +0200, Sebastian Reichel wrote: > On Tue, May 31, 2011 at 10:51:39AM +0200, Sebastian Reichel wrote: > > > The driver is accessing to i2c bus in interrupt handler. > > > Therefore, it should use threaded irq. > > I think the patch should also remove the local_irq_enable() call in > > twl_rtc_interrupt, since it's no longer needed with threaded irq. At > > least on the Pandaboard the RTC is still working with the appended > > patch. > > ping. > > Currently the kernel prints a stacktrace for each rtc-twl interrupt, > because its interrupt handler enables interrupts. I've queued both changes. Thanks for the reminder. thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rtc-twl: Switch to using threaded irq
On Tue, May 31, 2011 at 10:51:39AM +0200, Sebastian Reichel wrote: > > The driver is accessing to i2c bus in interrupt handler. > > Therefore, it should use threaded irq. > I think the patch should also remove the local_irq_enable() call in > twl_rtc_interrupt, since it's no longer needed with threaded irq. At > least on the Pandaboard the RTC is still working with the appended > patch. ping. Currently the kernel prints a stacktrace for each rtc-twl interrupt, because its interrupt handler enables interrupts. -- Sebastian signature.asc Description: Digital signature
Re: [PATCH] rtc-twl: Switch to using threaded irq
Hi,
I think the patch should also remove the local_irq_enable() call in
twl_rtc_interrupt, since it's no longer needed with threaded irq. At
least on the Pandaboard the RTC is still working with the appended
patch.
-- Sebastian
> >> On Apr 13, 2011 Krishnamoorthy, Balaji T wrote:
> >>> On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
> >> wrote:
>
> The driver is accessing to i2c bus in interrupt handler.
> Therefore, it should use threaded irq.
> >>
> >>> Acked-by: Balaji T K
> >>
>
> Signed-off-by: Ilkka Koskinen
> ---
> drivers/rtc/rtc-twl.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> index ed1b868..2715b96 100644
> --- a/drivers/rtc/rtc-twl.c
> +++ b/drivers/rtc/rtc-twl.c
> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct
> platform_device *pdev)
> if (ret < 0)
> goto out1;
>
> - ret = request_irq(irq, twl_rtc_interrupt,
> + ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> IRQF_TRIGGER_RISING,
> dev_name(&rtc->dev), rtc);
> if (ret < 0) {
> --
> 1.7.0.4
--- a/drivers/rtc/rtc-twl.c 2011-05-19 06:06:34.0 +0200
+++ b/drivers/rtc/rtc-twl.c 2011-05-26 20:34:03.0 +0200
@@ -362,14 +362,6 @@
int res;
u8 rd_reg;
-#ifdef CONFIG_LOCKDEP
- /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which
-* we don't want and can't tolerate. Although it might be
-* friendlier not to borrow this thread context...
-*/
- local_irq_enable();
-#endif
-
res = twl_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG);
if (res)
goto out;
@@ -462,7 +454,7 @@
if (ret < 0)
goto out1;
- ret = request_irq(irq, twl_rtc_interrupt,
+ ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
IRQF_TRIGGER_RISING,
dev_name(&rtc->dev), rtc);
if (ret < 0) {
signature.asc
Description: Digital signature
Re: [PATCH] rtc-twl: Switch to using threaded irq
Hi,
Tony, would you mind taking the patch in your tree?
Btw, the nokia address doesn't work anymore, but
should probably still remain in s-o-b...
Cheers, Ilkka
13.5.2011 2:24, John Stultz kirjoitti:
> On Thu, 2011-05-05 at 07:51 +, ilkka.koski...@nokia.com wrote:
>> Hi,
>>
>> Tony and John: What would be the appropriate path for this patch?
>
> I'd probably push it through omap maintainer path, as its hardware
> specific and can be better tested there.
>
> thanks
> -john
>
>
>> On Apr 13, 2011 Krishnamoorthy, Balaji T wrote:
>>> On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
>> wrote:
The driver is accessing to i2c bus in interrupt handler.
Therefore, it should use threaded irq.
>>
>>> Acked-by: Balaji T K
>>
Signed-off-by: Ilkka Koskinen
---
drivers/rtc/rtc-twl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index ed1b868..2715b96 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct
platform_device *pdev)
if (ret < 0)
goto out1;
- ret = request_irq(irq, twl_rtc_interrupt,
+ ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
IRQF_TRIGGER_RISING,
dev_name(&rtc->dev), rtc);
if (ret < 0) {
--
1.7.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] rtc-twl: Switch to using threaded irq
On Thu, 2011-05-05 at 07:51 +, ilkka.koski...@nokia.com wrote:
> Hi,
>
> Tony and John: What would be the appropriate path for this patch?
I'd probably push it through omap maintainer path, as its hardware
specific and can be better tested there.
thanks
-john
> On Apr 13, 2011 Krishnamoorthy, Balaji T wrote:
> >On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
> wrote:
> >>
> >> The driver is accessing to i2c bus in interrupt handler.
> >> Therefore, it should use threaded irq.
>
> >Acked-by: Balaji T K
>
> >>
> >> Signed-off-by: Ilkka Koskinen
> >> ---
> >> drivers/rtc/rtc-twl.c |2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> >> index ed1b868..2715b96 100644
> >> --- a/drivers/rtc/rtc-twl.c
> >> +++ b/drivers/rtc/rtc-twl.c
> >> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct
> >> platform_device *pdev)
> >>if (ret < 0)
> >>goto out1;
> >>
> >> - ret = request_irq(irq, twl_rtc_interrupt,
> >> + ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> >>IRQF_TRIGGER_RISING,
> >>dev_name(&rtc->dev), rtc);
> >>if (ret < 0) {
> >> --
> >> 1.7.0.4
> >>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] rtc-twl: Switch to using threaded irq
Hi,
Tony and John: What would be the appropriate path for this patch?
Cheers, Ilkka
On Apr 13, 2011 Krishnamoorthy, Balaji T wrote:
>On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
wrote:
>>
>> The driver is accessing to i2c bus in interrupt handler.
>> Therefore, it should use threaded irq.
>Acked-by: Balaji T K
>>
>> Signed-off-by: Ilkka Koskinen
>> ---
>> drivers/rtc/rtc-twl.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
>> index ed1b868..2715b96 100644
>> --- a/drivers/rtc/rtc-twl.c
>> +++ b/drivers/rtc/rtc-twl.c
>> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct
>> platform_device *pdev)
>>if (ret < 0)
>>goto out1;
>>
>> - ret = request_irq(irq, twl_rtc_interrupt,
>> + ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
>>IRQF_TRIGGER_RISING,
>>dev_name(&rtc->dev), rtc);
>>if (ret < 0) {
>> --
>> 1.7.0.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rtc-twl: Switch to using threaded irq
On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
wrote:
>
> The driver is accessing to i2c bus in interrupt handler.
> Therefore, it should use threaded irq.
Acked-by: Balaji T K
>
> Signed-off-by: Ilkka Koskinen
> ---
> drivers/rtc/rtc-twl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> index ed1b868..2715b96 100644
> --- a/drivers/rtc/rtc-twl.c
> +++ b/drivers/rtc/rtc-twl.c
> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device
> *pdev)
> if (ret < 0)
> goto out1;
>
> - ret = request_irq(irq, twl_rtc_interrupt,
> + ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> IRQF_TRIGGER_RISING,
> dev_name(&rtc->dev), rtc);
> if (ret < 0) {
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] rtc-twl: Switch to using threaded irq
The driver is accessing to i2c bus in interrupt handler.
Therefore, it should use threaded irq.
Signed-off-by: Ilkka Koskinen
---
drivers/rtc/rtc-twl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index ed1b868..2715b96 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device
*pdev)
if (ret < 0)
goto out1;
- ret = request_irq(irq, twl_rtc_interrupt,
+ ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
IRQF_TRIGGER_RISING,
dev_name(&rtc->dev), rtc);
if (ret < 0) {
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
