RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
> == patch = > There is an issue with MUSB AUTOIDLE as reported by Niilo Minkkinen in > below commit. > > 9a4b5e36ce58febdd2039dd4d129ee7edf4f5536 > usb: musb: disable OTG AUTOIDLE only with omap3430 > > As OMAP35x is just a variant of OMAP34xx chip thus the fix is also > applicable for OMAP35x so updating it for OMAP35x. > > Signed-off-by: Ajay Kumar Gupta > --- > drivers/usb/musb/omap2430.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > index 453796c..ab8336d 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -233,7 +233,7 @@ int __init musb_platform_init(struct musb *musb) >* MUSB AUTOIDLE don't work in 3430. >* Workaround by Richard Woodruff/TI >*/ > - if (!cpu_is_omap3430()) > + if (!cpu_is_omap3430() && !cpu_is_omap35xx()) cpu_is_omap35xx() is not yet available so this fix has to wait until this definition makes its way to l-o or mainline. -Ajay > l |= AUTOIDLE; /* enable auto idle */ > omap_writel(l, OTG_SYSCONFIG); > > -- > 1.6.2.4 > == > > > > > Regards, > > Richard W. > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
>>> Signed-off-by: Richard Woodruff >>> >>> Yes this is needed for 34xx. Side note is this cost around 1mW of power >>> during active mode of MUSB. When device is not active cost is not >>> significant. System impact depends on duty cycle of MUSB in usecase. >> >> Richard/Niilo, >>This should also be applicable to 35xx (right?) and so we got to >> update the fix with below patch. >> >> Regards, >> Ajay >> > >Don't have access to spec/errata of 35xx just now ;). >Could Richard confirm, if this also applies (as original comment said) . > There is an official errata on MUSB auto-idle not to be set: > Errata 1.164 Vikram, This Errata is also applicable on 35xx and so we need to update the AUTOIDLE fix in musb for 35xx. -Ajay > There might be NDA issues with sharing the errata document, and so cannot > attach. > I have not come across a public omap errata document yet. > >-niilo- >> == patch = >> There is an issue with MUSB AUTOIDLE as reported by Niilo Minkkinen in below >> commit. >> >> 9a4b5e36ce58febdd2039dd4d129ee7edf4f5536 >> usb: musb: disable OTG AUTOIDLE only with omap3430 >> >> As OMAP35x is just a variant of OMAP34xx chip thus the fix is also >> applicable for OMAP35x so >updating it for OMAP35x. >> >> Signed-off-by: Ajay Kumar Gupta >> --- >> drivers/usb/musb/omap2430.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index >> 453796c..ab8336d >100644 >> --- a/drivers/usb/musb/omap2430.c >> +++ b/drivers/usb/musb/omap2430.c >> @@ -233,7 +233,7 @@ int __init musb_platform_init(struct musb *musb) >> * MUSB AUTOIDLE don't work in 3430. >> * Workaround by Richard Woodruff/TI >> */ >> - if (!cpu_is_omap3430()) >> + if (!cpu_is_omap3430() && !cpu_is_omap35xx()) >>l |= AUTOIDLE; /* enable auto idle */ >>omap_writel(l, OTG_SYSCONFIG); >> >> -- >> 1.6.2.4 >> == >> >>> >>> Regards, >>> Richard W. >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > >-- >- >Niilo Minkkinen >Kalhontie 69C >40950 MUURAME >+358407324526 >niilo.minkki...@iki.fi >-- >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
>-Original Message- >From: linux-omap-ow...@vger.kernel.org >[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Niilo >>> > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG >>> > register prevents the device from going into retention. >>> > This is a workaround (by Richard Woodruff/TI), as his comment : >>> > > A new MUSB bug which is a match to data below was identified very >>> > > recently (on hardware and in simulation). >>> > > This bug is in 3430 and not 3630. >>> > > As a priority test (and as new default) you should have engineers >>> > > disable autoidle for MUSB block. >>> > > This is the workaround which will show up in next errata. >>> > >>> > Signed-off-by: Niilo Minkkinen >>> >>> Signed-off-by: Richard Woodruff >>> >>> Yes this is needed for 34xx. Side note is this cost around 1mW of power >>> during active mode of MUSB. When device is not active cost is not >>> significant. System impact depends on duty cycle of MUSB in usecase. >> >> Richard/Niilo, >> This should also be applicable to 35xx (right?) and so we got to >> update the fix with below patch. >> >> Regards, >> Ajay >> > >Don't have access to spec/errata of 35xx just now ;). >Could Richard confirm, if this also applies (as original comment said) . There is an official errata on MUSB auto-idle not to be set: Errata 1.164 There might be NDA issues with sharing the errata document, and so cannot attach. I have not come across a public omap errata document yet. > >-niilo- >> == patch = >> There is an issue with MUSB AUTOIDLE as reported by Niilo Minkkinen in below >> commit. >> >> 9a4b5e36ce58febdd2039dd4d129ee7edf4f5536 >> usb: musb: disable OTG AUTOIDLE only with omap3430 >> >> As OMAP35x is just a variant of OMAP34xx chip thus the fix is also >> applicable for OMAP35x so >updating it for OMAP35x. >> >> Signed-off-by: Ajay Kumar Gupta >> --- >> drivers/usb/musb/omap2430.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index >> 453796c..ab8336d >100644 >> --- a/drivers/usb/musb/omap2430.c >> +++ b/drivers/usb/musb/omap2430.c >> @@ -233,7 +233,7 @@ int __init musb_platform_init(struct musb *musb) >> * MUSB AUTOIDLE don't work in 3430. >> * Workaround by Richard Woodruff/TI >> */ >> - if (!cpu_is_omap3430()) >> + if (!cpu_is_omap3430() && !cpu_is_omap35xx()) >> l |= AUTOIDLE; /* enable auto idle */ >> omap_writel(l, OTG_SYSCONFIG); >> >> -- >> 1.6.2.4 >> == >> >>> >>> Regards, >>> Richard W. >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > >-- >- >Niilo Minkkinen >Kalhontie 69C >40950 MUURAME >+358407324526 >niilo.minkki...@iki.fi >-- >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
On Wed, Aug 26, 2009 at 2:47 PM, Gupta, Ajay Kumar wrote: >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- >> ow...@vger.kernel.org] On Behalf Of Woodruff, Richard >> Sent: Tuesday, May 19, 2009 12:53 AM >> To: Niilo Minkkinen; linux-...@vger.kernel.org >> Cc: linux-omap@vger.kernel.org; t...@atomide.com >> Subject: RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430 >> >> >> > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- >> > ow...@vger.kernel.org] On Behalf Of Niilo Minkkinen >> > Sent: Monday, May 18, 2009 9:54 AM >> >> > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG >> > register prevents the device from going into retention. >> > This is a workaround (by Richard Woodruff/TI), as his comment : >> > > A new MUSB bug which is a match to data below was identified very >> > > recently (on hardware and in simulation). >> > > This bug is in 3430 and not 3630. >> > > As a priority test (and as new default) you should have engineers >> > > disable autoidle for MUSB block. >> > > This is the workaround which will show up in next errata. >> > >> > Signed-off-by: Niilo Minkkinen >> >> Signed-off-by: Richard Woodruff >> >> Yes this is needed for 34xx. Side note is this cost around 1mW of power >> during active mode of MUSB. When device is not active cost is not >> significant. System impact depends on duty cycle of MUSB in usecase. > > Richard/Niilo, > This should also be applicable to 35xx (right?) and so we got to > update the fix with below patch. > > Regards, > Ajay > Don't have access to spec/errata of 35xx just now ;). Could Richard confirm, if this also applies (as original comment said) . -niilo- > == patch = > There is an issue with MUSB AUTOIDLE as reported by Niilo Minkkinen in below > commit. > > 9a4b5e36ce58febdd2039dd4d129ee7edf4f5536 > usb: musb: disable OTG AUTOIDLE only with omap3430 > > As OMAP35x is just a variant of OMAP34xx chip thus the fix is also applicable > for OMAP35x so updating it for OMAP35x. > > Signed-off-by: Ajay Kumar Gupta > --- > drivers/usb/musb/omap2430.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index > 453796c..ab8336d 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -233,7 +233,7 @@ int __init musb_platform_init(struct musb *musb) > * MUSB AUTOIDLE don't work in 3430. > * Workaround by Richard Woodruff/TI > */ > - if (!cpu_is_omap3430()) > + if (!cpu_is_omap3430() && !cpu_is_omap35xx()) > l |= AUTOIDLE; /* enable auto idle */ > omap_writel(l, OTG_SYSCONFIG); > > -- > 1.6.2.4 > == > >> >> Regards, >> Richard W. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- - Niilo Minkkinen Kalhontie 69C 40950 MUURAME +358407324526 niilo.minkki...@iki.fi -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Woodruff, Richard > Sent: Tuesday, May 19, 2009 12:53 AM > To: Niilo Minkkinen; linux-...@vger.kernel.org > Cc: linux-omap@vger.kernel.org; t...@atomide.com > Subject: RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430 > > > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > ow...@vger.kernel.org] On Behalf Of Niilo Minkkinen > > Sent: Monday, May 18, 2009 9:54 AM > > > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG > > register prevents the device from going into retention. > > This is a workaround (by Richard Woodruff/TI), as his comment : > > > A new MUSB bug which is a match to data below was identified very > > > recently (on hardware and in simulation). > > > This bug is in 3430 and not 3630. > > > As a priority test (and as new default) you should have engineers > > > disable autoidle for MUSB block. > > > This is the workaround which will show up in next errata. > > > > Signed-off-by: Niilo Minkkinen > > Signed-off-by: Richard Woodruff > > Yes this is needed for 34xx. Side note is this cost around 1mW of power > during active mode of MUSB. When device is not active cost is not > significant. System impact depends on duty cycle of MUSB in usecase. Richard/Niilo, This should also be applicable to 35xx (right?) and so we got to update the fix with below patch. Regards, Ajay == patch = There is an issue with MUSB AUTOIDLE as reported by Niilo Minkkinen in below commit. 9a4b5e36ce58febdd2039dd4d129ee7edf4f5536 usb: musb: disable OTG AUTOIDLE only with omap3430 As OMAP35x is just a variant of OMAP34xx chip thus the fix is also applicable for OMAP35x so updating it for OMAP35x. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/omap2430.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 453796c..ab8336d 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -233,7 +233,7 @@ int __init musb_platform_init(struct musb *musb) * MUSB AUTOIDLE don't work in 3430. * Workaround by Richard Woodruff/TI */ - if (!cpu_is_omap3430()) + if (!cpu_is_omap3430() && !cpu_is_omap35xx()) l |= AUTOIDLE; /* enable auto idle */ omap_writel(l, OTG_SYSCONFIG); -- 1.6.2.4 == > > Regards, > Richard W. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
Things considering tranceiver suspend/wakeup are welcom, cause it seems to be mysteric, how to operate with. Sometimes clock aren't shutoff in suspend. Sometimes, wakeup is not succesfull. On 6/19/09, David Brownell wrote: > On Monday 18 May 2009, Woodruff, Richard wrote: >> >> > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- >> > ow...@vger.kernel.org] On Behalf Of Niilo Minkkinen >> > Sent: Monday, May 18, 2009 9:54 AM >> >> > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG >> > register prevents the device from going into retention. >> > This is a workaround (by Richard Woodruff/TI), as his comment : >> > > A new MUSB bug which is a match to data below was identified very >> > > recently (on hardware and in simulation). >> > > This bug is in 3430 and not 3630. >> > > As a priority test (and as new default) you should have engineers >> > > disable autoidle for MUSB block. >> > > This is the workaround which will show up in next errata. >> > >> > Signed-off-by: Niilo Minkkinen >> >> Signed-off-by: Richard Woodruff >> >> Yes this is needed for 34xx. Side note is this cost around 1mW of power >> during active mode of MUSB. When device is not active cost is not >> significant. System impact depends on duty cycle of MUSB in usecase. > > There's also some initialization goofiness in that code ... it's supposed > to set initialize the transceiver with several distinct writes, of which > setting AUTOIDLE (to auto-gate the L3 clock) is ISTR the last step. > > The goofiness shows up with OTG initialization, which is documented as > needing a slightly different sequence ... my notes have it as being > an extra write to set ENABLEFORCE. > > - Dave > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- - Niilo Minkkinen Kalhontie 69C 40950 MUURAME +358407324526 niilo.minkki...@iki.fi Arvokkainta ihmiselle on vapaus tehdä omia päätöksiä, jotka ovat joskus vääriäkin - Gottfried Leibniz (1646–1716) - -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
On Monday 18 May 2009, Woodruff, Richard wrote: > > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > ow...@vger.kernel.org] On Behalf Of Niilo Minkkinen > > Sent: Monday, May 18, 2009 9:54 AM > > > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG > > register prevents the device from going into retention. > > This is a workaround (by Richard Woodruff/TI), as his comment : > > > A new MUSB bug which is a match to data below was identified very > > > recently (on hardware and in simulation). > > > This bug is in 3430 and not 3630. > > > As a priority test (and as new default) you should have engineers > > > disable autoidle for MUSB block. > > > This is the workaround which will show up in next errata. > > > > Signed-off-by: Niilo Minkkinen > > Signed-off-by: Richard Woodruff > > Yes this is needed for 34xx. Side note is this cost around 1mW of power > during active mode of MUSB. When device is not active cost is not > significant. System impact depends on duty cycle of MUSB in usecase. There's also some initialization goofiness in that code ... it's supposed to set initialize the transceiver with several distinct writes, of which setting AUTOIDLE (to auto-gate the L3 clock) is ISTR the last step. The goofiness shows up with OTG initialization, which is documented as needing a slightly different sequence ... my notes have it as being an extra write to set ENABLEFORCE. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
"Woodruff, Richard" writes: >> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- >> ow...@vger.kernel.org] On Behalf Of Niilo Minkkinen >> Sent: Monday, May 18, 2009 9:54 AM > >> Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG >> register prevents the device from going into retention. >> This is a workaround (by Richard Woodruff/TI), as his comment : >> > A new MUSB bug which is a match to data below was identified very >> > recently (on hardware and in simulation). >> > This bug is in 3430 and not 3630. >> > As a priority test (and as new default) you should have engineers >> > disable autoidle for MUSB block. >> > This is the workaround which will show up in next errata. >> >> Signed-off-by: Niilo Minkkinen > > Signed-off-by: Richard Woodruff > > Yes this is needed for 34xx. Side note is this cost around 1mW of power > during active mode of MUSB. When device is not active cost is not > significant. System impact depends on duty cycle of MUSB in usecase. > While this makes its way upstream, I'll pull into PM branch. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Niilo Minkkinen > Sent: Monday, May 18, 2009 9:54 AM > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG > register prevents the device from going into retention. > This is a workaround (by Richard Woodruff/TI), as his comment : > > A new MUSB bug which is a match to data below was identified very > > recently (on hardware and in simulation). > > This bug is in 3430 and not 3630. > > As a priority test (and as new default) you should have engineers > > disable autoidle for MUSB block. > > This is the workaround which will show up in next errata. > > Signed-off-by: Niilo Minkkinen Signed-off-by: Richard Woodruff Yes this is needed for 34xx. Side note is this cost around 1mW of power during active mode of MUSB. When device is not active cost is not significant. System impact depends on duty cycle of MUSB in usecase. Regards, Richard W. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: disable OTG AUTOIDLE only with omap3430
Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG register prevents the device from going into retention. This is a workaround (by Richard Woodruff/TI), as his comment : > A new MUSB bug which is a match to data below was identified very > recently (on hardware and in simulation). > This bug is in 3430 and not 3630. > As a priority test (and as new default) you should have engineers > disable autoidle for MUSB block. > This is the workaround which will show up in next errata. Signed-off-by: Niilo Minkkinen --- drivers/usb/musb/omap2430.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 901dffd..396fc6d 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -241,7 +241,12 @@ int __init musb_platform_init(struct musb *musb) l &= ~AUTOIDLE; /* disable auto idle */ l &= ~NOIDLE; /* remove possible noidle */ l |= SMARTIDLE; /* enable smart idle */ - l |= AUTOIDLE; /* enable auto idle */ + /* +* MUSB AUTOIDLE don't work in 3430. +* Workaround by Richard Woodruff/TI +*/ + if (!cpu_is_omap3430()) + l |= AUTOIDLE; /* enable auto idle */ omap_writel(l, OTG_SYSCONFIG); l = omap_readl(OTG_INTERFSEL); -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
