Re: [PATCH] usb: musb: fix build break due to partial rename

2010-10-05 Thread Greg KH
On Sat, Oct 02, 2010 at 02:04:24AM +0530, Anand Gadiyar wrote:
 Patch usb gadget: don't save bind callback in struct usb_gadget_driver
 in Greg's USB queue missed one conversion of
 usb_gadget_register_driver to usb_gadget_probe_driver,
 causing a build break when MUSB is built in gadget mode.
 
 Fix this.
 
 Reported-by: Grazvydas Ignotas nota...@gmail.com
 Signed-off-by: Anand Gadiyar gadi...@ti.com
 Cc: Uwe Kleine-Koenigu.kleine-koe...@pengutronix.de
 Cc: Michal Nazarewicz m.nazarew...@samsung.com
 Cc: Felipe Balbi ba...@ti.com
 Cc: Greg Kroah-Hartman gre...@suse.de
 ---
 Greg,
 
 Since Uwe's original patch isn't yet in mainline, maybe you could
 fold this patch into the original.

I've folded it into the original, thanks.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] usb: musb: fix build break due to partial rename

2010-10-04 Thread Felipe Balbi

On Fri, Oct 01, 2010 at 03:34:24PM -0500, Gadiyar, Anand wrote:

Patch usb gadget: don't save bind callback in struct usb_gadget_driver
in Greg's USB queue missed one conversion of
usb_gadget_register_driver to usb_gadget_probe_driver,
causing a build break when MUSB is built in gadget mode.

Fix this.

Reported-by: Grazvydas Ignotas nota...@gmail.com
Signed-off-by: Anand Gadiyar gadi...@ti.com
Cc: Uwe Kleine-Koenigu.kleine-koe...@pengutronix.de
Cc: Michal Nazarewicz m.nazarew...@samsung.com
Cc: Felipe Balbi ba...@ti.com


wow, good catch :-)

Acked-by: Felipe Balbi ba...@ti.com


Cc: Greg Kroah-Hartman gre...@suse.de
---
Greg,

Since Uwe's original patch isn't yet in mainline, maybe you could
fold this patch into the original.


Fine by me to fold on original patch.

--
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] usb: musb: fix build break due to partial rename

2010-10-04 Thread Uwe Kleine-König
On Sat, Oct 02, 2010 at 02:04:24AM +0530, Anand Gadiyar wrote:
 Patch usb gadget: don't save bind callback in struct usb_gadget_driver
 in Greg's USB queue missed one conversion of
 usb_gadget_register_driver to usb_gadget_probe_driver,
 causing a build break when MUSB is built in gadget mode.
 
 Fix this.
 
 Reported-by: Grazvydas Ignotas nota...@gmail.com
 Signed-off-by: Anand Gadiyar gadi...@ti.com
 Cc: Uwe Kleine-Koenigu.kleine-koe...@pengutronix.de
 Cc: Michal Nazarewicz m.nazarew...@samsung.com
 Cc: Felipe Balbi ba...@ti.com
 Cc: Greg Kroah-Hartman gre...@suse.de
Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de

 ---
 Greg,
 
 Since Uwe's original patch isn't yet in mainline, maybe you could
 fold this patch into the original.
 
  drivers/usb/musb/musb_gadget.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 Index: linux-2.6/drivers/usb/musb/musb_gadget.c
 ===
 --- linux-2.6.orig/drivers/usb/musb/musb_gadget.c
 +++ linux-2.6/drivers/usb/musb/musb_gadget.c
 @@ -1786,7 +1786,7 @@ int usb_gadget_probe_driver(struct usb_g
  
   return retval;
  }
 -EXPORT_SYMBOL(usb_gadget_register_driver);
 +EXPORT_SYMBOL(usb_gadget_probe_driver);
  
  static void stop_activity(struct musb *musb, struct usb_gadget_driver 
 *driver)
  {
 

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] usb: musb: fix build break due to partial rename

2010-10-01 Thread Anand Gadiyar
Patch usb gadget: don't save bind callback in struct usb_gadget_driver
in Greg's USB queue missed one conversion of
usb_gadget_register_driver to usb_gadget_probe_driver,
causing a build break when MUSB is built in gadget mode.

Fix this.

Reported-by: Grazvydas Ignotas nota...@gmail.com
Signed-off-by: Anand Gadiyar gadi...@ti.com
Cc: Uwe Kleine-Koenigu.kleine-koe...@pengutronix.de
Cc: Michal Nazarewicz m.nazarew...@samsung.com
Cc: Felipe Balbi ba...@ti.com
Cc: Greg Kroah-Hartman gre...@suse.de
---
Greg,

Since Uwe's original patch isn't yet in mainline, maybe you could
fold this patch into the original.

 drivers/usb/musb/musb_gadget.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/usb/musb/musb_gadget.c
===
--- linux-2.6.orig/drivers/usb/musb/musb_gadget.c
+++ linux-2.6/drivers/usb/musb/musb_gadget.c
@@ -1786,7 +1786,7 @@ int usb_gadget_probe_driver(struct usb_g
 
return retval;
 }
-EXPORT_SYMBOL(usb_gadget_register_driver);
+EXPORT_SYMBOL(usb_gadget_probe_driver);
 
 static void stop_activity(struct musb *musb, struct usb_gadget_driver *driver)
 {
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html