Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
* Vimal Singh [091202 06:09]: > >> >> From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 > >> >> From: Vimal Singh > >> >> Date: Thu, 19 Nov 2009 19:28:11 +0530 > >> >> > >> >> This patch series adds flash support for NAND (in sdp, zoom and ldp), > >> >> OneNAND and NOR (in sdp) > >> >> > >> >> Tested on Zoom2 and 3430SDP > >> >> > >> >> Vimal Singh (4): > >> >> [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards > >> >> [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards > >> >> [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig > >> >> [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig > >> > > > I am going to re-post this patch series again and this time I have > divided this into 3 (for more convenience in reviewing) . Something > like this: > > 1st series: > This patch series will introduce generic gpmc-nand.c for nand device > related gpmc init. > > 2nd series: > This patch series will introduce 'board-sdp-flash.c', for flash > devices init on SDP > boards. And will give an example of using 'gpmc-nand.c' and > 'board-sdp-flash.c' by > adding flash support to 3430SDP board. > > 3rd: > This series introduces 'board-zoom-flash.c' for NAND init in ZOOM boards. > Other patches will add NAND support for ZOOM2, ZOOM3 and LDP. > > Tony, > Is it ok with you? Sounds pretty good to me. Also the patches you just posted look nice to me, will take a closer look. Thanks for doing the generic gpmc-nand.c, that should make it a lot easier to bring up new omap boards. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
>> >> From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 >> >> From: Vimal Singh >> >> Date: Thu, 19 Nov 2009 19:28:11 +0530 >> >> >> >> This patch series adds flash support for NAND (in sdp, zoom and ldp), >> >> OneNAND and NOR (in sdp) >> >> >> >> Tested on Zoom2 and 3430SDP >> >> >> >> Vimal Singh (4): >> >> [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards >> >> [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards >> >> [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig >> >> [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig >> > I am going to re-post this patch series again and this time I have divided this into 3 (for more convenience in reviewing) . Something like this: 1st series: This patch series will introduce generic gpmc-nand.c for nand device related gpmc init. 2nd series: This patch series will introduce 'board-sdp-flash.c', for flash devices init on SDP boards. And will give an example of using 'gpmc-nand.c' and 'board-sdp-flash.c' by adding flash support to 3430SDP board. 3rd: This series introduces 'board-zoom-flash.c' for NAND init in ZOOM boards. Other patches will add NAND support for ZOOM2, ZOOM3 and LDP. Tony, Is it ok with you? -- Regards, Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
On Tue, 2009-11-24 at 20:55 +0530, Vimal Singh wrote: > On Tue, Nov 24, 2009 at 8:36 PM, Artem Bityutskiy wrote: > > On Thu, 2009-11-19 at 19:38 +0530, Vimal Singh wrote: > >> Here is the v6 of this patch series. I am cc'ing mtd list too this time. > >> > >> > >> From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 > >> From: Vimal Singh > >> Date: Thu, 19 Nov 2009 19:28:11 +0530 > >> > >> This patch series adds flash support for NAND (in sdp, zoom and ldp), > >> OneNAND and NOR (in sdp) > >> > >> Tested on Zoom2 and 3430SDP > >> > >> Vimal Singh (4): > >> [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards > >> [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards > >> [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig > >> [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig > > > > Is it possible to separate the MTD and OMAP parts? > > 1st patch does migration of gpmc low level calls from omap2.c to gpmc-nand.c. > I am not sure how we can have separate patches for this. Ok. It looks like you intend to merge this stuff via linux-omap, which seems right. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
On Tue, Nov 24, 2009 at 8:36 PM, Artem Bityutskiy wrote: > On Thu, 2009-11-19 at 19:38 +0530, Vimal Singh wrote: >> Here is the v6 of this patch series. I am cc'ing mtd list too this time. >> >> >> From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 >> From: Vimal Singh >> Date: Thu, 19 Nov 2009 19:28:11 +0530 >> >> This patch series adds flash support for NAND (in sdp, zoom and ldp), >> OneNAND and NOR (in sdp) >> >> Tested on Zoom2 and 3430SDP >> >> Vimal Singh (4): >> [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards >> [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards >> [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig >> [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig > > Is it possible to separate the MTD and OMAP parts? 1st patch does migration of gpmc low level calls from omap2.c to gpmc-nand.c. I am not sure how we can have separate patches for this. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
On Thu, 2009-11-19 at 19:38 +0530, Vimal Singh wrote: > Here is the v6 of this patch series. I am cc'ing mtd list too this time. > > > From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 > From: Vimal Singh > Date: Thu, 19 Nov 2009 19:28:11 +0530 > > This patch series adds flash support for NAND (in sdp, zoom and ldp), > OneNAND and NOR (in sdp) > > Tested on Zoom2 and 3430SDP > > Vimal Singh (4): > [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards > [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards > [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig > [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig Is it possible to separate the MTD and OMAP parts? -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
On Thu, Nov 19, 2009 at 7:52 PM, Nishanth Menon wrote: > Vimal Singh had written, on 11/19/2009 08:11 AM, the following: > [...] > >>> >>> v4-v5: >>> [PATCH-v5 1/4] OMAP2/3: Add support for flash on SDP boards: >>> Implemented Tony's comments. >> >> arch/arm/configs/omap_3430sdp_defconfig | 140 +++ >> arch/arm/configs/omap_zoom2_defconfig | 344 >> +++--- > > how about zoom3 and sdp3630? I do not have these boards. Could someone test for these and drop a patch for same? > >> arch/arm/mach-omap2/Makefile | 8 + >> arch/arm/mach-omap2/board-2430sdp.c | 2 + >> arch/arm/mach-omap2/board-3430sdp.c | 2 + >> arch/arm/mach-omap2/board-ldp.c | 2 + >> arch/arm/mach-omap2/board-sdp-flash.c | 315 >> +++ >> arch/arm/mach-omap2/board-zoom-flash.c | 92 +++ >> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 + >> arch/arm/mach-omap2/gpmc-nand.c | 128 ++ >> arch/arm/plat-omap/include/plat/board-sdp.h | 15 ++ >> arch/arm/plat-omap/include/plat/board-zoom.h | 36 +++ >> arch/arm/plat-omap/include/plat/gpmc.h | 4 +- >> arch/arm/plat-omap/include/plat/nand.h | 6 + >> drivers/mtd/nand/omap2.c | 33 +-- >> 15 files changed, 969 insertions(+), 160 deletions(-) >> create mode 100644 arch/arm/mach-omap2/board-sdp-flash.c >> create mode 100644 arch/arm/mach-omap2/board-zoom-flash.c >> create mode 100644 arch/arm/mach-omap2/gpmc-nand.c >> create mode 100644 arch/arm/plat-omap/include/plat/board-sdp.h >> create mode 100644 arch/arm/plat-omap/include/plat/board-zoom.h >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > -- > Regards, > Nishanth Menon > -- Regards, Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
Vimal Singh had written, on 11/19/2009 08:11 AM, the following: [...] v4-v5: [PATCH-v5 1/4] OMAP2/3: Add support for flash on SDP boards: Implemented Tony's comments. arch/arm/configs/omap_3430sdp_defconfig | 140 +++ arch/arm/configs/omap_zoom2_defconfig| 344 +++--- how about zoom3 and sdp3630? arch/arm/mach-omap2/Makefile |8 + arch/arm/mach-omap2/board-2430sdp.c |2 + arch/arm/mach-omap2/board-3430sdp.c |2 + arch/arm/mach-omap2/board-ldp.c |2 + arch/arm/mach-omap2/board-sdp-flash.c| 315 +++ arch/arm/mach-omap2/board-zoom-flash.c | 92 +++ arch/arm/mach-omap2/board-zoom-peripherals.c |2 + arch/arm/mach-omap2/gpmc-nand.c | 128 ++ arch/arm/plat-omap/include/plat/board-sdp.h | 15 ++ arch/arm/plat-omap/include/plat/board-zoom.h | 36 +++ arch/arm/plat-omap/include/plat/gpmc.h |4 +- arch/arm/plat-omap/include/plat/nand.h |6 + drivers/mtd/nand/omap2.c | 33 +-- 15 files changed, 969 insertions(+), 160 deletions(-) create mode 100644 arch/arm/mach-omap2/board-sdp-flash.c create mode 100644 arch/arm/mach-omap2/board-zoom-flash.c create mode 100644 arch/arm/mach-omap2/gpmc-nand.c create mode 100644 arch/arm/plat-omap/include/plat/board-sdp.h create mode 100644 arch/arm/plat-omap/include/plat/board-zoom.h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
Sorry, forgot to append diffstat. Listing below this time. On Thu, Nov 19, 2009 at 7:38 PM, Vimal Singh wrote: > Here is the v6 of this patch series. I am cc'ing mtd list too this time. > > > From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 > From: Vimal Singh > Date: Thu, 19 Nov 2009 19:28:11 +0530 > > This patch series adds flash support for NAND (in sdp, zoom and ldp), > OneNAND and NOR (in sdp) > > Tested on Zoom2 and 3430SDP > > Vimal Singh (4): > [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards > [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards > [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig > [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig > > > v6 : > 1. Implemented Tony's comments on below threads: > > [PATCH-v5 1/4] OMAP2/3: Add support for flash on SDP boards > http://marc.info/?l=linux-omap&m=125805845217778&w=2 > > [PATCH-v5 2/4] OMAP3: Add support for NAND on ZOOM2/LDP boards > http://marc.info/?l=linux-omap&m=125805867318269&w=2 > > [PATCH 2/3]NAND: OMAP: Fixing omap nand driver, compiled as module > http://marc.info/?l=linux-omap&m=125787938923028&w=2 > > 2. Creating 'mach-omap2/gpmc-nand.c' to handle GPMC related setups for > the driver. > 3. Removed all 'gpmc_cs_read_reg' and 'gpmc_cs_write_reg' calls from > 'nand/omap2.c' > 4. Corrected macro 'GPMC_CONFIG1_DEVICETYPE_NAND' for NAND > 5. Removed 'nand unlock' routine in patch 2/4, will take this > discussion to mtd list. > > v4-v5: > [PATCH-v5 1/4] OMAP2/3: Add support for flash on SDP boards: > Implemented Tony's comments. arch/arm/configs/omap_3430sdp_defconfig | 140 +++ arch/arm/configs/omap_zoom2_defconfig| 344 +++--- arch/arm/mach-omap2/Makefile |8 + arch/arm/mach-omap2/board-2430sdp.c |2 + arch/arm/mach-omap2/board-3430sdp.c |2 + arch/arm/mach-omap2/board-ldp.c |2 + arch/arm/mach-omap2/board-sdp-flash.c| 315 +++ arch/arm/mach-omap2/board-zoom-flash.c | 92 +++ arch/arm/mach-omap2/board-zoom-peripherals.c |2 + arch/arm/mach-omap2/gpmc-nand.c | 128 ++ arch/arm/plat-omap/include/plat/board-sdp.h | 15 ++ arch/arm/plat-omap/include/plat/board-zoom.h | 36 +++ arch/arm/plat-omap/include/plat/gpmc.h |4 +- arch/arm/plat-omap/include/plat/nand.h |6 + drivers/mtd/nand/omap2.c | 33 +-- 15 files changed, 969 insertions(+), 160 deletions(-) create mode 100644 arch/arm/mach-omap2/board-sdp-flash.c create mode 100644 arch/arm/mach-omap2/board-zoom-flash.c create mode 100644 arch/arm/mach-omap2/gpmc-nand.c create mode 100644 arch/arm/plat-omap/include/plat/board-sdp.h create mode 100644 arch/arm/plat-omap/include/plat/board-zoom.h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH-v6 0/4] OMAP: Adding flash support to SDP, ZOOM2 and LDP boards
Here is the v6 of this patch series. I am cc'ing mtd list too this time. >From 8bc97108cf9c78216f1ea5407ccbd900e6b63dc2 Mon Sep 17 00:00:00 2001 From: Vimal Singh Date: Thu, 19 Nov 2009 19:28:11 +0530 This patch series adds flash support for NAND (in sdp, zoom and ldp), OneNAND and NOR (in sdp) Tested on Zoom2 and 3430SDP Vimal Singh (4): [PATCH-v6 1/4] OMAP2/3: Add support for flash on SDP boards [PATCH-v6 2/4] OMAP3: Add support for NAND on ZOOM/LDP boards [PATCH-v6 3/4] OMAP: Zoom2: Enable NAND and JFFS2 support in defconfig [PATCH-v6 4/4] OMAP: 3430SDP: Enable NAND in defconfig v6 : 1. Implemented Tony's comments on below threads: [PATCH-v5 1/4] OMAP2/3: Add support for flash on SDP boards http://marc.info/?l=linux-omap&m=125805845217778&w=2 [PATCH-v5 2/4] OMAP3: Add support for NAND on ZOOM2/LDP boards http://marc.info/?l=linux-omap&m=125805867318269&w=2 [PATCH 2/3]NAND: OMAP: Fixing omap nand driver, compiled as module http://marc.info/?l=linux-omap&m=125787938923028&w=2 2. Creating 'mach-omap2/gpmc-nand.c' to handle GPMC related setups for the driver. 3. Removed all 'gpmc_cs_read_reg' and 'gpmc_cs_write_reg' calls from 'nand/omap2.c' 4. Corrected macro 'GPMC_CONFIG1_DEVICETYPE_NAND' for NAND 5. Removed 'nand unlock' routine in patch 2/4, will take this discussion to mtd list. v4-v5: [PATCH-v5 1/4] OMAP2/3: Add support for flash on SDP boards: Implemented Tony's comments. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
