Re: [PATCH 0/0] Power domain and clock domain patches for omap
Hello Dmitry, On Tue, 19 Aug 2008, Dmitry Baryshkov wrote: There is one major flaw IMO in this code. Please correct me if I'm wrong: Driver A: powerdomain_register() Driver B: powerdomain_get() Driver A: powerdomain_unregister() Then Driver B has a reference to unregistered domain. And as powerdomains lack any type of refcounting this can lead to any type of memory access bugs if Driver A is unloaded from the kernel. At this point, only OMAP kernel init code registers powerdomains in arch/arm/mach-omap2/io.c. It's not intended that driver code will manipulate or even know about these. Thanks for the comments, - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/0] Power domain and clock domain patches for omap
On Wed, Jul 16, 2008 at 06:19:05PM +0300, Tony Lindgren wrote: This patch series contains power domain and clock domain specific patches for omap posted to linux-arm-kernel list during 2.6.25-rc5. I'm reposting the series to a wider audience as Russell King suspected that other archs may be interested in reviewing these too, or at least some parts of the code. Okay, I'll merge this set of 10 patches now. Could you update them for the new include layout please, and send me a pull request for them. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/0] Power domain and clock domain patches for omap
On Monday 21 July 2008, Russell King - ARM Linux wrote: On Wed, Jul 16, 2008 at 06:19:05PM +0300, Tony Lindgren wrote: I'm reposting the series to a wider audience as Russell King suspected that other archs may be interested in reviewing these too, or at least some parts of the code. It would be nice to have some comment on these patches from other people. My suspicions is that this infrastructure is solving a problem found on other SoCs in addition to OMAP, ISTR that DaVinci is similar ... but much simpler, with fewer power domains and more are always on. Not much of the DaVinci support is upstream yet though. I'm not sure how many non-TI parts will need similar software support. It's my understanding that not many vendors put that much energy into support for leakage current management. (Here, a key observation is that when a section of a chip has gated all its clocks off, that leaves leakage current as the top source of power wastage. Cooperative drivers could then let that section be powered down to eliminate leakage. So the first level of power management is clock gating, at least in part with software support. The power domain gating is a second level.) The regulator stuff is not unrelated ... except that this power domain stuff *only* needs on/off switches (like almost all power domains I've ever used), is tightly coupled to clocks, and unlike regulators is more oriented towards SOC-internal concerns than board-level ones. and, if this is useful to other people, it should become cross-SoC infrastructure. My two cents: merge the OMAP stuff first, then see what kinds of generalization would be needed before other chips could use it. Nobody wins by holding this back ... but everyone on OMAP2/OMAP3 loses. - Dave Since I don't know the answer to whether it would be useful, I'm trying to ensure that these patches have sufficient exposure to people who _may_ know the answer. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/0] Power domain and clock domain patches for omap
On Wed, Jul 16, 2008 at 06:19:05PM +0300, Tony Lindgren wrote: I'm reposting the series to a wider audience as Russell King suspected that other archs may be interested in reviewing these too, or at least some parts of the code. It would be nice to have some comment on these patches from other people. My suspicions is that this infrastructure is solving a problem found on other SoCs in addition to OMAP, and, if this is useful to other people, it should become cross-SoC infrastructure. Since I don't know the answer to whether it would be useful, I'm trying to ensure that these patches have sufficient exposure to people who _may_ know the answer. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/0] Power domain and clock domain patches for omap
Hi all, This patch series contains power domain and clock domain specific patches for omap posted to linux-arm-kernel list during 2.6.25-rc5. I'm reposting the series to a wider audience as Russell King suspected that other archs may be interested in reviewing these too, or at least some parts of the code. Please take a look and comment the code. Also please point out the pieces of code that may be suitable for your arch too! This patch series also available via git at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap2-clock Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
