Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting
On Wed, Nov 21, 2012 at 11:09:30AM -0800, Tony Lindgren wrote: > * Dmitry Torokhov [121120 00:23]: > > On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote: > > > Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the > > > pendown GPIO debounce time setting by the below sequence: > > > > > > gpio_request_one() > > > gpio_set_debounce() > > > gpio_free() > > > > > > It also revealed a bug in the OMAP GPIO handling code which prevented > > > the GPIO debounce clock to be disabled and CORE transition to low power > > > states. > > > > > > Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on > > > free/reset) fixes the OMAP GPIO handling code by making sure that the > > > GPIO debounce clock gets disabled if no GPIO is requested from current > > > bank. > > > > > > While fixing the OMAP GPIO handling code (in the right way), the above > > > commit makes the gpio_request->set_debounce->free sequence invalid as > > > after freeing the GPIO, the debounce settings are lost. > > > > > > This patch set: > > > 1) Adds the pendown GPIO debounce time setting to the platform data > > >structure of the ads7846 driver. > > > 2) Fixes the OMAP platform code to pass the debounce time value > > >to the driver instead of handling it by itself. > > > > > > Igor Grinberg (2): > > > ads7846: enable pendown GPIO debounce time setting > > > ARM: OMAP: ads7846: fix pendown debounce setting > > > > > > > Makes sense to me. Tony, I have some stuff to push for 3.7 final, mind > > if I pick OMAP change as well? > > No please go ahead, I just acked the related patch. Thanks Tony. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting
* Dmitry Torokhov [121120 00:23]: > On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote: > > Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the > > pendown GPIO debounce time setting by the below sequence: > > > > gpio_request_one() > > gpio_set_debounce() > > gpio_free() > > > > It also revealed a bug in the OMAP GPIO handling code which prevented > > the GPIO debounce clock to be disabled and CORE transition to low power > > states. > > > > Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on > > free/reset) fixes the OMAP GPIO handling code by making sure that the > > GPIO debounce clock gets disabled if no GPIO is requested from current > > bank. > > > > While fixing the OMAP GPIO handling code (in the right way), the above > > commit makes the gpio_request->set_debounce->free sequence invalid as > > after freeing the GPIO, the debounce settings are lost. > > > > This patch set: > > 1) Adds the pendown GPIO debounce time setting to the platform data > >structure of the ads7846 driver. > > 2) Fixes the OMAP platform code to pass the debounce time value > >to the driver instead of handling it by itself. > > > > Igor Grinberg (2): > > ads7846: enable pendown GPIO debounce time setting > > ARM: OMAP: ads7846: fix pendown debounce setting > > > > Makes sense to me. Tony, I have some stuff to push for 3.7 final, mind > if I pick OMAP change as well? No please go ahead, I just acked the related patch. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting
On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote: > Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the > pendown GPIO debounce time setting by the below sequence: > > gpio_request_one() > gpio_set_debounce() > gpio_free() > > It also revealed a bug in the OMAP GPIO handling code which prevented > the GPIO debounce clock to be disabled and CORE transition to low power > states. > > Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on > free/reset) fixes the OMAP GPIO handling code by making sure that the > GPIO debounce clock gets disabled if no GPIO is requested from current > bank. > > While fixing the OMAP GPIO handling code (in the right way), the above > commit makes the gpio_request->set_debounce->free sequence invalid as > after freeing the GPIO, the debounce settings are lost. > > This patch set: > 1) Adds the pendown GPIO debounce time setting to the platform data >structure of the ads7846 driver. > 2) Fixes the OMAP platform code to pass the debounce time value >to the driver instead of handling it by itself. > > Igor Grinberg (2): > ads7846: enable pendown GPIO debounce time setting > ARM: OMAP: ads7846: fix pendown debounce setting > Makes sense to me. Tony, I have some stuff to push for 3.7 final, mind if I pick OMAP change as well? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting
Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the pendown GPIO debounce time setting by the below sequence: gpio_request_one() gpio_set_debounce() gpio_free() It also revealed a bug in the OMAP GPIO handling code which prevented the GPIO debounce clock to be disabled and CORE transition to low power states. Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on free/reset) fixes the OMAP GPIO handling code by making sure that the GPIO debounce clock gets disabled if no GPIO is requested from current bank. While fixing the OMAP GPIO handling code (in the right way), the above commit makes the gpio_request->set_debounce->free sequence invalid as after freeing the GPIO, the debounce settings are lost. This patch set: 1) Adds the pendown GPIO debounce time setting to the platform data structure of the ads7846 driver. 2) Fixes the OMAP platform code to pass the debounce time value to the driver instead of handling it by itself. Igor Grinberg (2): ads7846: enable pendown GPIO debounce time setting ARM: OMAP: ads7846: fix pendown debounce setting arch/arm/mach-omap2/common-board-devices.c | 34 --- drivers/input/touchscreen/ads7846.c|6 - include/linux/spi/ads7846.h|5 ++- 3 files changed, 28 insertions(+), 17 deletions(-) -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html