Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Hi Florian, On 02/26/2013 05:07 PM, Florian Vaussard wrote: > Hi, > > On 02/07/2013 08:58 AM, Peter Ujfalusi wrote: >> Hi, >> >> On 02/06/2013 02:30 PM, Benoit Cousson wrote: So a patch is being merged to handle triggers in the case of pwm leds [1]. When done, we will be able to add back the default trigger. Do you want to wait on it to merge this series? >>> >>> What kind of dependency do we have between these two series? I mean what >>> will happen if the DTS is merged before the pwm subsystem? >>> >>> If that does not generate any regression / crash, then it is OK, if not, >>> we should take care of the order. >> >> In this series the 'linux,default-trigger' property is not added to the >> pwm-leds node, so it is safe to take this series. >> I'm sure Florian will send the update to add this flag back for 3.10 >> or for >> 3.9-rc (the needed patches for PWM and leds-pwm will be in 3.9). >> > > Yes, it is safe to take this series. I will provide a patch to add back > the trigger when it is safe to. OK, great, I'll take the series then. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Hi, On 02/07/2013 08:58 AM, Peter Ujfalusi wrote: Hi, On 02/06/2013 02:30 PM, Benoit Cousson wrote: So a patch is being merged to handle triggers in the case of pwm leds [1]. When done, we will be able to add back the default trigger. Do you want to wait on it to merge this series? What kind of dependency do we have between these two series? I mean what will happen if the DTS is merged before the pwm subsystem? If that does not generate any regression / crash, then it is OK, if not, we should take care of the order. In this series the 'linux,default-trigger' property is not added to the pwm-leds node, so it is safe to take this series. I'm sure Florian will send the update to add this flag back for 3.10 or for 3.9-rc (the needed patches for PWM and leds-pwm will be in 3.9). Yes, it is safe to take this series. I will provide a patch to add back the trigger when it is safe to. Regards, Florian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Hi, On 02/06/2013 02:30 PM, Benoit Cousson wrote: >> So a patch is being merged to handle triggers in the case of pwm leds [1]. >> When done, we will be able to add back the default trigger. Do you want >> to wait on it to merge this series? > > What kind of dependency do we have between these two series? I mean what > will happen if the DTS is merged before the pwm subsystem? > > If that does not generate any regression / crash, then it is OK, if not, > we should take care of the order. In this series the 'linux,default-trigger' property is not added to the pwm-leds node, so it is safe to take this series. I'm sure Florian will send the update to add this flag back for 3.10 or for 3.9-rc (the needed patches for PWM and leds-pwm will be in 3.9). I'm also waiting for 3.9-rc1 so I can finish up some of the pending things regarding to PWMs. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Hi all ! Le 06/02/2013 14:30, Benoit Cousson a écrit : Salut Florian, On 02/04/2013 10:14 AM, Florian Vaussard wrote: Hello Benoit, On 01/24/2013 01:21 PM, Benoit Cousson wrote: + Peter who did the original PWM Hi Florian, On 01/23/2013 06:56 PM, Florian Vaussard wrote: Hello Benoit, This patchset adds some new DT supports to the Overo products. The first patch converts the PMIC LEDB output to use the pwm-leds, newly merged in your branch for_3.9/dts. The second patch adds the audio support. Excellent, that looks very good to me, but I'd like to get the feedback from Peter before merging it. So a patch is being merged to handle triggers in the case of pwm leds [1]. When done, we will be able to add back the default trigger. Do you want to wait on it to merge this series? What kind of dependency do we have between these two series? I mean what will happen if the DTS is merged before the pwm subsystem? If that does not generate any regression / crash, then it is OK, if not, we should take care of the order. Florian is on holiday the next two weeks. AFAIK if the PWM/leds subsystem patches are not merged before this one then the kernel will panic if a trigger is used to change the led status. Regards, Philippe -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Salut Florian, On 02/04/2013 10:14 AM, Florian Vaussard wrote: > Hello Benoit, > > On 01/24/2013 01:21 PM, Benoit Cousson wrote: >> + Peter who did the original PWM >> >> Hi Florian, >> >> On 01/23/2013 06:56 PM, Florian Vaussard wrote: >>> Hello Benoit, >>> >>> This patchset adds some new DT supports to the Overo products. The >>> first patch converts the PMIC LEDB output to use the pwm-leds, >>> newly merged in your branch for_3.9/dts. The second patch adds the >>> audio support. >> >> Excellent, that looks very good to me, but I'd like to get the >> feedback from Peter before merging it. >> > > So a patch is being merged to handle triggers in the case of pwm leds [1]. > When done, we will be able to add back the default trigger. Do you want > to wait on it to merge this series? What kind of dependency do we have between these two series? I mean what will happen if the DTS is merged before the pwm subsystem? If that does not generate any regression / crash, then it is OK, if not, we should take care of the order. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Hello Benoit, On 01/24/2013 01:21 PM, Benoit Cousson wrote: + Peter who did the original PWM Hi Florian, On 01/23/2013 06:56 PM, Florian Vaussard wrote: Hello Benoit, This patchset adds some new DT supports to the Overo products. The first patch converts the PMIC LEDB output to use the pwm-leds, newly merged in your branch for_3.9/dts. The second patch adds the audio support. Excellent, that looks very good to me, but I'd like to get the feedback from Peter before merging it. So a patch is being merged to handle triggers in the case of pwm leds [1]. When done, we will be able to add back the default trigger. Do you want to wait on it to merge this series? Regards, Florian [1] https://patchwork.kernel.org/patch/2056191/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
+ Peter who did the original PWM Hi Florian, On 01/23/2013 06:56 PM, Florian Vaussard wrote: > Hello Benoit, > > This patchset adds some new DT supports to the Overo products. > The first patch converts the PMIC LEDB output to use the pwm-leds, > newly merged in your branch for_3.9/dts. The second patch > adds the audio support. Excellent, that looks very good to me, but I'd like to get the feedback from Peter before merging it. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support
Hello Benoit, This patchset adds some new DT supports to the Overo products. The first patch converts the PMIC LEDB output to use the pwm-leds, newly merged in your branch for_3.9/dts. The second patch adds the audio support. Best regards, Florian Florian Vaussard (2): ARM: dts: omap3-overo: Add support for pwm-leds ARM: dts: omap3-overo: Add audio support arch/arm/boot/dts/omap3-overo.dtsi | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
