Re: [PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-02-02 Thread Kadiyala, Kishore
Tony,

On Thu, Jan 20, 2011 at 11:12 PM, Tony Lindgren t...@atomide.com wrote:
 * Kishore Kadiyala kishore.kadiy...@ti.com [110118 09:19]:
 This patch series adds support for ADMA on MMC1  MMC2 controllers on OMAP4.
 There is no performance improvement observed using ADMA over SDMA.
 Advantage using ADMA could be reducing contention over SDMA.
 Also the series includes some cleanup.

 To me it seems that the only sane way to deal with multiple different
 DMA enginges is to implement them all with drivers/dma/dmaengine.c.
 Otherwise we'll end up with multiple custom ADMA implementations in
 each driver. We need to also make SDMA use the dmaengine code.

 If the current dmaengine code does not support this, we need to
 improve it to deal with cases like these.

Ok, I will check the feasibility of implementing ADMA through dmaengine .


-- 
Regards,
Kishore


 Regards,

 Tony

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-01-20 Thread Tony Lindgren
* Kishore Kadiyala kishore.kadiy...@ti.com [110118 09:19]:
 This patch series adds support for ADMA on MMC1  MMC2 controllers on OMAP4.
 There is no performance improvement observed using ADMA over SDMA.
 Advantage using ADMA could be reducing contention over SDMA.
 Also the series includes some cleanup.

To me it seems that the only sane way to deal with multiple different
DMA enginges is to implement them all with drivers/dma/dmaengine.c.
Otherwise we'll end up with multiple custom ADMA implementations in
each driver. We need to also make SDMA use the dmaengine code.

If the current dmaengine code does not support this, we need to
improve it to deal with cases like these.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-01-18 Thread Kishore Kadiyala
This patch series adds support for ADMA on MMC1  MMC2 controllers on OMAP4.
There is no performance improvement observed using ADMA over SDMA.
Advantage using ADMA could be reducing contention over SDMA.
Also the series includes some cleanup.

The series is based on 2.6.37-rc8 and tested on OMAP4430SDP  OMAP3430SDP.


Kishore Kadiyala (4):
  omap: hsmmc: Rename use_dma to xfer_type and define possible
transfers
  omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup
  omap4: hsmmc: Adding ADMA support for MMC1  MMC2 controllers
  omap4: hsmmc: enable ADMA for MMC1  MMC2

 arch/arm/mach-omap2/hsmmc.c   |   13 ++-
 arch/arm/plat-omap/include/plat/mmc.h |1 +
 drivers/mmc/host/omap_hsmmc.c |  241 +++--
 3 files changed, 210 insertions(+), 45 deletions(-)

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html