RE: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
> -Original Message- > From: Jean Pihet [mailto:jean.pi...@newoldbits.com] > Sent: Friday, December 17, 2010 3:48 PM > To: Santosh Shilimkar; khil...@deeprootsystems.com > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Jean > Pihet-XID > Subject: Re: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code > > Hi Santosh, Kevin, > > On Fri, Dec 17, 2010 at 6:05 AM, Santosh Shilimkar > wrote: > > Jean, > > > >> -Original Message- > >> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > >> ow...@vger.kernel.org] On Behalf Of jean.pi...@newoldbits.com > >> Sent: Thursday, December 16, 2010 11:21 PM > >> To: linux-omap@vger.kernel.org > >> Cc: khil...@deeprootsystems.com; linux-arm-ker...@lists.infradead.org; > >> Jean Pihet > >> Subject: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code > >> > >> From: Jean Pihet > >> > >> This patch only contains clean-ups and cosmetic changes, > >> no functional change. > >> > >> Clean-up of the ASM sleep code, for better readability and > >> easier maintenance. > >> > >> Applies on top of Nishant's latest idle path errata fixes step 2, > >> cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2 > >> > > Thanks for cleanup. Have few minor comments on these patches. > > Thanks for the review. > I fixed the issues and reposted the series as '[PATCH 0/7 v5] OMAP3: > clean up ASM sleep code'. > Thanks. I checked it. Will ack your patches -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
Hi Santosh, Kevin, On Fri, Dec 17, 2010 at 6:05 AM, Santosh Shilimkar wrote: > Jean, > >> -Original Message- >> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- >> ow...@vger.kernel.org] On Behalf Of jean.pi...@newoldbits.com >> Sent: Thursday, December 16, 2010 11:21 PM >> To: linux-omap@vger.kernel.org >> Cc: khil...@deeprootsystems.com; linux-arm-ker...@lists.infradead.org; >> Jean Pihet >> Subject: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code >> >> From: Jean Pihet >> >> This patch only contains clean-ups and cosmetic changes, >> no functional change. >> >> Clean-up of the ASM sleep code, for better readability and >> easier maintenance. >> >> Applies on top of Nishant's latest idle path errata fixes step 2, >> cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2 >> > Thanks for cleanup. Have few minor comments on these patches. Thanks for the review. I fixed the issues and reposted the series as '[PATCH 0/7 v5] OMAP3: clean up ASM sleep code'. Regards, Jean > >> Jean Pihet (7): >> OMAP2+: use global values for the SRAM PA addresses >> OMAP3: remove hardcoded values from the ASM sleep code >> OMAP3: re-organize the ASM sleep code >> OMAP3: rework of the ASM sleep code execution paths >> OMAP3: add comments for low power code errata >> OMAP3: ASM sleep code format rework >> OMAP3: remove unused code from the ASM sleep code >> >> arch/arm/mach-omap2/control.c | 10 +- >> arch/arm/mach-omap2/control.h | 2 + >> arch/arm/mach-omap2/pm.h | 1 - >> arch/arm/mach-omap2/pm34xx.c | 4 +- >> arch/arm/mach-omap2/sdrc.h | 7 + >> arch/arm/mach-omap2/sleep34xx.S | 714 > +- >> - >> arch/arm/plat-omap/sram.c | 7 +- >> 7 files changed, 401 insertions(+), 344 deletions(-) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
Jean, > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of jean.pi...@newoldbits.com > Sent: Thursday, December 16, 2010 11:21 PM > To: linux-omap@vger.kernel.org > Cc: khil...@deeprootsystems.com; linux-arm-ker...@lists.infradead.org; > Jean Pihet > Subject: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code > > From: Jean Pihet > > This patch only contains clean-ups and cosmetic changes, > no functional change. > > Clean-up of the ASM sleep code, for better readability and > easier maintenance. > > Applies on top of Nishant's latest idle path errata fixes step 2, > cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2 > Thanks for cleanup. Have few minor comments on these patches. > Jean Pihet (7): > OMAP2+: use global values for the SRAM PA addresses > OMAP3: remove hardcoded values from the ASM sleep code > OMAP3: re-organize the ASM sleep code > OMAP3: rework of the ASM sleep code execution paths > OMAP3: add comments for low power code errata > OMAP3: ASM sleep code format rework > OMAP3: remove unused code from the ASM sleep code > > arch/arm/mach-omap2/control.c | 10 +- > arch/arm/mach-omap2/control.h |2 + > arch/arm/mach-omap2/pm.h|1 - > arch/arm/mach-omap2/pm34xx.c|4 +- > arch/arm/mach-omap2/sdrc.h |7 + > arch/arm/mach-omap2/sleep34xx.S | 714 +- > - > arch/arm/plat-omap/sram.c |7 +- > 7 files changed, 401 insertions(+), 344 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
* jean.pi...@newoldbits.com [101216 09:51]: > From: Jean Pihet > > This patch only contains clean-ups and cosmetic changes, > no functional change. > > Clean-up of the ASM sleep code, for better readability and > easier maintenance. > > Applies on top of Nishant's latest idle path errata fixes step 2, > cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2 > > Jean Pihet (7): > OMAP2+: use global values for the SRAM PA addresses > OMAP3: remove hardcoded values from the ASM sleep code > OMAP3: re-organize the ASM sleep code > OMAP3: rework of the ASM sleep code execution paths > OMAP3: add comments for low power code errata > OMAP3: ASM sleep code format rework > OMAP3: remove unused code from the ASM sleep code Thanks for splitting it into several patches, looks good to me. Assuming Kevin will queue these, so: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/7 v4] OMAP3: clean up ASM sleep code
From: Jean Pihet This patch only contains clean-ups and cosmetic changes, no functional change. Clean-up of the ASM sleep code, for better readability and easier maintenance. Applies on top of Nishant's latest idle path errata fixes step 2, cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2 Jean Pihet (7): OMAP2+: use global values for the SRAM PA addresses OMAP3: remove hardcoded values from the ASM sleep code OMAP3: re-organize the ASM sleep code OMAP3: rework of the ASM sleep code execution paths OMAP3: add comments for low power code errata OMAP3: ASM sleep code format rework OMAP3: remove unused code from the ASM sleep code arch/arm/mach-omap2/control.c | 10 +- arch/arm/mach-omap2/control.h |2 + arch/arm/mach-omap2/pm.h|1 - arch/arm/mach-omap2/pm34xx.c|4 +- arch/arm/mach-omap2/sdrc.h |7 + arch/arm/mach-omap2/sleep34xx.S | 714 +-- arch/arm/plat-omap/sram.c |7 +- 7 files changed, 401 insertions(+), 344 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
