RE: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'
Hi, > -Original Message- > From: Sergei Shtylyov [mailto:sshtyl...@ru.mvista.com] > Sent: Wednesday, November 18, 2009 7:50 PM > To: Gupta, Ajay Kumar > Cc: linux-...@vger.kernel.org; > davinci-linux-open-sou...@linux.davincidsp.com; > coolo...@kernel.org; felipe.ba...@nokia.com; > linux-omap@vger.kernel.org; Gadiyar, Anand > Subject: Re: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data' > > Hello. > > Ajay Kumar Gupta wrote: > > > This patch set adds a new structure 'musb_hdrc_board_data' > to get all > > board specific data from board files. > > > It is actually done to accomodate ULPI_VBUSCONTROL programming > > required for OMAP3EVM Rev >=E which uses external Vbus > supply to support 500mA. > > It's not clear why it was necessary to create yet another > structure. You could your new field to 'struct > musb_hdrc_platfrom_data'... This a actually a simpler approach and would avoid changing Davinci/BLackFin Specific files. Felipe/Anand, Is it ok to add 'extvbus' in 'musb_hdrc_platform_data' and pass this data from all OMAP board files. Anyways we do have 'musb_config' which has all platform sepecific information. -Ajay > > > Regards, > > Ajay > > WBR, Sergei > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'
Hello. Ajay Kumar Gupta wrote: This patch set adds a new structure 'musb_hdrc_board_data' to get all board specific data from board files. It is actually done to accomodate ULPI_VBUSCONTROL programming required for OMAP3EVM Rev >=E which uses external Vbus supply to support 500mA. It's not clear why it was necessary to create yet another structure. You could your new field to 'struct musb_hdrc_platfrom_data'... Regards, Ajay WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'
Hi, This patch set adds a new structure 'musb_hdrc_board_data' to get all board specific data from board files. It is actually done to accomodate ULPI_VBUSCONTROL programming required for OMAP3EVM Rev >=E which uses external Vbus supply to support 500mA. Necessarly changes have been done in all the OMAP, Davinci and Blackfin platform based boards. [patches created against linus's tree and tested on OMAP3EVM] Regards, Ajay Ajay Kumar Gupta (8): musb: Add structure to get board specific data musb: Get power (mA) from board data musb: Update musb_init() call for all OMAP3 boards musb: Update setup_usb() call for all Davinci boards musb: Add 'extvbus' in musb_hdrc_board_data musb: set 'extvbus = 0' for OMAP3 boards musb: set 'extvbus = 0' for Davinci boards musb: set 'extvbus = 0' for Blackfin boards arch/arm/mach-davinci/board-dm355-evm.c | 10 +- arch/arm/mach-davinci/board-dm355-leopard.c | 10 +- arch/arm/mach-davinci/board-dm644x-evm.c|9 - arch/arm/mach-davinci/board-sffsdr.c| 10 +- arch/arm/mach-davinci/include/mach/common.h |7 +-- arch/arm/mach-davinci/usb.c |8 arch/arm/mach-omap2/board-2430sdp.c |8 +++- arch/arm/mach-omap2/board-3430sdp.c |9 - arch/arm/mach-omap2/board-ldp.c |8 +++- arch/arm/mach-omap2/board-omap3beagle.c |9 - arch/arm/mach-omap2/board-omap3evm.c|9 - arch/arm/mach-omap2/board-omap3pandora.c|9 - arch/arm/mach-omap2/board-overo.c |9 - arch/arm/mach-omap2/board-rx51.c|8 +++- arch/arm/mach-omap2/board-zoom2.c |8 +++- arch/arm/mach-omap2/usb-musb.c | 13 + arch/arm/plat-omap/include/mach/usb.h |3 ++- arch/blackfin/mach-bf527/boards/cm_bf527.c |6 ++ arch/blackfin/mach-bf527/boards/ezbrd.c |6 ++ arch/blackfin/mach-bf527/boards/ezkit.c |6 ++ arch/blackfin/mach-bf548/boards/cm_bf548.c |6 ++ arch/blackfin/mach-bf548/boards/ezkit.c |6 ++ drivers/usb/musb/musb_core.c| 14 +- drivers/usb/musb/musb_regs.h|5 + include/linux/usb/musb.h| 19 +-- 25 files changed, 180 insertions(+), 35 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
