Re: [PATCH 0/9] HDQ driver fixes

2008-09-25 Thread Madhusudhan Chikkature 
Hi Tony,

Somehow the mailer I am using seem to wrap the patch header and I dont have a 
immediate fix for the same.So Anand will repost the same patches again on 
behalf of me.I added one more patch to the series which fixed some minor 
comments that came in after I posted the patches.

Regards,
Madhu
- Original Message - 
From: Madhusudhan Chikkature [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-omap@vger.kernel.org
Sent: Wednesday, September 24, 2008 4:49 PM
Subject: [PATCH 0/9] HDQ driver fixes


 Hi Tony,
 
 I am posting a series of nine patches for the HDQ driver. The patch series
 provides cleanup of the driver pointed out by Filipe's diff file, use ioremap
 for HDQ base, replace usage of semaphore with mutex, fixes some commenting
 style and indentation.
 
 Regards,
 Madhu
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-omap in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/9] HDQ driver fixes

2008-09-24 Thread Madhusudhan Chikkature 
Hi Tony,

I am posting a series of nine patches for the HDQ driver. The patch series
provides cleanup of the driver pointed out by Filipe's diff file, use ioremap
for HDQ base, replace usage of semaphore with mutex, fixes some commenting
style and indentation.

Regards,
Madhu

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/9] HDQ driver fixes

2008-09-24 Thread Felipe Balbi 
On Wed, Sep 24, 2008 at 04:49:08PM +0530, ext Madhusudhan Chikkature wrote:
 Hi Tony,
 
 I am posting a series of nine patches for the HDQ driver. The patch series
 provides cleanup of the driver pointed out by Filipe's diff file, use ioremap
 for HDQ base, replace usage of semaphore with mutex, fixes some commenting
 style and indentation.

one more (and hopefully last) comment, hdq_reg_out should return void:

static inline void hdq_reg_out(struct hdq_data *hdq_data, u32 offset, u8 val)
{
__raw_writeb(val, hdq_data-hdq_base + offset);
}

If you fix the comments I gave now, I think the patches should be
applied unless someone else has any comments to them. After that, you
could also prepare a patch sending this particular driver to
Evgeniy Polyakov [EMAIL PROTECTED] Cc:ing
[EMAIL PROTECTED] and linux-omap@vger.kernel.org

-- 
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/9] HDQ driver fixes

2008-09-24 Thread Evgeniy Polyakov 
On Wed, Sep 24, 2008 at 02:55:35PM +0300, Felipe Balbi ([EMAIL PROTECTED]) 
wrote:
 If you fix the comments I gave now, I think the patches should be
 applied unless someone else has any comments to them. After that, you
 could also prepare a patch sending this particular driver to
 Evgeniy Polyakov [EMAIL PROTECTED] Cc:ing
 [EMAIL PROTECTED] and linux-omap@vger.kernel.org

I checked patches and do not see any objections, so feel free to add my
ack if you want.

-- 
Evgeniy Polyakov
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html