Re: [PATCH 05/17] OMAP:PM: Precedence fix

2009-10-20 Thread Kevin Hilman
Tero Kristo  writes:

> From: Carlos Chinea 
>
> Signed-off-by: Carlos Chinea 
> Signed-off-by: Jouni Hogander 

Patch looks good, but needs better subject and a changelog.

Kevin

> ---
>  arch/arm/mach-omap2/pm34xx.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 4addc41..588ab79 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -225,8 +225,8 @@ static void omap3_core_save_context(void)
>   control_padconf_off |= START_PADCONF_SAVE;
>   omap_ctrl_writel(control_padconf_off, OMAP343X_CONTROL_PADCONF_OFF);
>   /* wait for the save to complete */
> - while (!omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)
> - & PADCONF_SAVE_DONE)
> + while (!(omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)
> + & PADCONF_SAVE_DONE))
>   ;
>   /* Save the Interrupt controller context */
>   omap3_intc_save_context();
> -- 
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 05/17] OMAP:PM: Precedence fix

2009-10-16 Thread Tero Kristo
From: Carlos Chinea 

Signed-off-by: Carlos Chinea 
Signed-off-by: Jouni Hogander 
---
 arch/arm/mach-omap2/pm34xx.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 4addc41..588ab79 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -225,8 +225,8 @@ static void omap3_core_save_context(void)
control_padconf_off |= START_PADCONF_SAVE;
omap_ctrl_writel(control_padconf_off, OMAP343X_CONTROL_PADCONF_OFF);
/* wait for the save to complete */
-   while (!omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)
-   & PADCONF_SAVE_DONE)
+   while (!(omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)
+   & PADCONF_SAVE_DONE))
;
/* Save the Interrupt controller context */
omap3_intc_save_context();
-- 
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html