RE: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox.
Hi Hiroshi, > -Original Message- > From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] > Sent: Monday, September 07, 2009 2:03 PM > To: C.A, Subramaniam > Cc: linux-omap@vger.kernel.org; t...@atomide.com; > r...@arm.linux.org.uk; Kanigeri, Hari; Gupta, Ramesh > Subject: Re: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add > build specific changes to support OMAP4 mailbox. > > From: "ext C.A, Subramaniam" > Subject: RE: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add > build specific changes to support OMAP4 mailbox. > Date: Mon, 7 Sep 2009 10:27:22 +0200 > > > > > > > > > Signed-off-by: C A Subramaniam > > > > Signed-off-by: Ramesh Gupta G > > > > --- > > > > arch/arm/mach-omap2/Makefile |4 > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/Makefile > > > > b/arch/arm/mach-omap2/Makefile index 735bae5..4bb426d 100644 > > > > --- a/arch/arm/mach-omap2/Makefile > > > > +++ b/arch/arm/mach-omap2/Makefile > > > > @@ -39,6 +39,10 @@ endif > > > > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > > > > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > > > > > > > +# MAILBOX > > > > > > I think that the above line is not necessary since the > module names > > > are enough self-explanatory, a little bit nitpicky, though > > > > I have followed the existing convention present in the > Makefile (Power management, clock framework,etc.) as follows: > > > > # Power Management > > ifeq ($(CONFIG_PM),y) > > obj-$(CONFIG_ARCH_OMAP2)+= pm24xx.o > > obj-$(CONFIG_ARCH_OMAP24XX) += sleep24xx.o > > obj-$(CONFIG_ARCH_OMAP3)+= pm34xx.o sleep34xx.o > > obj-$(CONFIG_PM_DEBUG) += pm-debug.o > > endif > > > > # Clock framework > > obj-$(CONFIG_ARCH_OMAP2)+= clock24xx.o > > obj-$(CONFIG_ARCH_OMAP3)+= clock34xx.o > > > > Please let me know if you still believe that the line needs > to be removed. > > I understand that you followed kind of convention, but I > still think that these comments don't make so much sense > since these module names are apparently enough self-explanatory. > > Sure! I can remove that. I will send a patch with the changes you had mentioned.-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox.
From: "ext C.A, Subramaniam" Subject: RE: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox. Date: Mon, 7 Sep 2009 10:27:22 +0200 > > > > > > Signed-off-by: C A Subramaniam > > > Signed-off-by: Ramesh Gupta G > > > --- > > > arch/arm/mach-omap2/Makefile |4 > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > diff --git a/arch/arm/mach-omap2/Makefile > > > b/arch/arm/mach-omap2/Makefile index 735bae5..4bb426d 100644 > > > --- a/arch/arm/mach-omap2/Makefile > > > +++ b/arch/arm/mach-omap2/Makefile > > > @@ -39,6 +39,10 @@ endif > > > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > > > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > > > > > +# MAILBOX > > > > I think that the above line is not necessary since the module > > names are enough self-explanatory, a little bit nitpicky, though > > I have followed the existing convention present in the Makefile (Power > management, clock framework,etc.) as follows: > > # Power Management > ifeq ($(CONFIG_PM),y) > obj-$(CONFIG_ARCH_OMAP2) += pm24xx.o > obj-$(CONFIG_ARCH_OMAP24XX) += sleep24xx.o > obj-$(CONFIG_ARCH_OMAP3) += pm34xx.o sleep34xx.o > obj-$(CONFIG_PM_DEBUG)+= pm-debug.o > endif > > # Clock framework > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > Please let me know if you still believe that the line needs to be removed. I understand that you followed kind of convention, but I still think that these comments don't make so much sense since these module names are apparently enough self-explanatory. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox.
Hi Hiroshi, > -Original Message- > From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] > Sent: Saturday, September 05, 2009 1:34 PM > To: C.A, Subramaniam > Cc: linux-omap@vger.kernel.org; t...@atomide.com; > r...@arm.linux.org.uk; Kanigeri, Hari; Gupta, Ramesh > Subject: Re: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add > build specific changes to support OMAP4 mailbox. > > Hi Subramaniam, > > From: "ext C.A, Subramaniam" > Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build > specific changes to support OMAP4 mailbox. > Date: Fri, 4 Sep 2009 13:47:09 +0200 > > > From aa759db084be9a2893de5e61b11f6de6d05508d9 Mon Sep 17 > 00:00:00 2001 > > From: C A Subramaniam > > Date: Wed, 2 Sep 2009 17:52:22 +0530 > > Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add > build specific changes to support OMAP4 mailbox. > > > > This patch adds changes to the build related files of > mailbox driver > > to support OMAP4 mailbox > > The above comment doesn't match the this modification since > adding those module isn't just for OMAP4, but for other omap > architecutres(omap2/3/4). So I think that this explanation > should be changed as not only for omap4, but just for adding > common mailbox support in this Makefile. I agree on your comments. I will change the description accordingly. > > > > Signed-off-by: C A Subramaniam > > Signed-off-by: Ramesh Gupta G > > --- > > arch/arm/mach-omap2/Makefile |4 > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/Makefile > > b/arch/arm/mach-omap2/Makefile index 735bae5..4bb426d 100644 > > --- a/arch/arm/mach-omap2/Makefile > > +++ b/arch/arm/mach-omap2/Makefile > > @@ -39,6 +39,10 @@ endif > > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > > > +# MAILBOX > > I think that the above line is not necessary since the module > names are enough self-explanatory, a little bit nitpicky, though I have followed the existing convention present in the Makefile (Power management, clock framework,etc.) as follows: # Power Management ifeq ($(CONFIG_PM),y) obj-$(CONFIG_ARCH_OMAP2)+= pm24xx.o obj-$(CONFIG_ARCH_OMAP24XX) += sleep24xx.o obj-$(CONFIG_ARCH_OMAP3)+= pm34xx.o sleep34xx.o obj-$(CONFIG_PM_DEBUG) += pm-debug.o endif # Clock framework obj-$(CONFIG_ARCH_OMAP2)+= clock24xx.o obj-$(CONFIG_ARCH_OMAP3)+= clock34xx.o Please let me know if you still believe that the line needs to be removed. > > > +obj-$(CONFIG_OMAP_MBOX_FWK)+= mailbox_mach.o > > +mailbox_mach-objs := mailbox.o > > + > > iommu-y+= iommu2.o > > iommu-$(CONFIG_ARCH_OMAP3) += omap3-iommu.o > > \ > > -- > > 1.5.3.2 > > -- > > To unsubscribe from this list: send the line "unsubscribe > linux-omap" > > in the body of a message to majord...@vger.kernel.org More > majordomo > > info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox.
Hi Subramaniam, From: "ext C.A, Subramaniam" Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox. Date: Fri, 4 Sep 2009 13:47:09 +0200 > From aa759db084be9a2893de5e61b11f6de6d05508d9 Mon Sep 17 00:00:00 2001 > From: C A Subramaniam > Date: Wed, 2 Sep 2009 17:52:22 +0530 > Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific > changes to support OMAP4 mailbox. > > This patch adds changes to the build related files of mailbox > driver to support OMAP4 mailbox The above comment doesn't match the this modification since adding those module isn't just for OMAP4, but for other omap architecutres(omap2/3/4). So I think that this explanation should be changed as not only for omap4, but just for adding common mailbox support in this Makefile. > > Signed-off-by: C A Subramaniam > Signed-off-by: Ramesh Gupta G > --- > arch/arm/mach-omap2/Makefile |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile > index 735bae5..4bb426d 100644 > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -39,6 +39,10 @@ endif > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > +# MAILBOX I think that the above line is not necessary since the module names are enough self-explanatory, a little bit nitpicky, though > +obj-$(CONFIG_OMAP_MBOX_FWK) += mailbox_mach.o > +mailbox_mach-objs:= mailbox.o > + > iommu-y += iommu2.o > iommu-$(CONFIG_ARCH_OMAP3) += omap3-iommu.o > > -- > 1.5.3.2 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox.
>From aa759db084be9a2893de5e61b11f6de6d05508d9 Mon Sep 17 00:00:00 2001 From: C A Subramaniam Date: Wed, 2 Sep 2009 17:52:22 +0530 Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox. This patch adds changes to the build related files of mailbox driver to support OMAP4 mailbox Signed-off-by: C A Subramaniam Signed-off-by: Ramesh Gupta G --- arch/arm/mach-omap2/Makefile |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 735bae5..4bb426d 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -39,6 +39,10 @@ endif obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o +# MAILBOX +obj-$(CONFIG_OMAP_MBOX_FWK)+= mailbox_mach.o +mailbox_mach-objs := mailbox.o + iommu-y+= iommu2.o iommu-$(CONFIG_ARCH_OMAP3) += omap3-iommu.o -- 1.5.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
