Re: [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled

2014-08-28 Thread Tony Lindgren 
* Felipe Balbi ba...@ti.com [140827 19:21]:
 Hi,
 
 On Wed, Aug 27, 2014 at 04:28:07PM -0700, Tony Lindgren wrote:
  It's not being used any longer.
  
  Signed-off-by: Tony Lindgren t...@atomide.com
  ---
   drivers/phy/phy-twl4030-usb.c | 2 --
   drivers/usb/phy/phy-twl6030-usb.c | 2 --
   2 files changed, 4 deletions(-)
  
  diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
  index 9cd33a4..bc28ecc 100644
  --- a/drivers/phy/phy-twl4030-usb.c
  +++ b/drivers/phy/phy-twl4030-usb.c
  @@ -164,7 +164,6 @@ struct twl4030_usb {
  enum omap_musb_vbus_id_status linkstat;
  boolvbus_supplied;
  u8  asleep;
  -   boolirq_enabled;
   
  struct delayed_work id_workaround_work;
   };
  @@ -755,7 +754,6 @@ static int twl4030_usb_probe(struct platform_device 
  *pdev)
   * set_host() and/or set_peripheral() ... OTG_capable boards
   * need both handles, otherwise just one suffices.
   */
  -   twl-irq_enabled = true;
  status = devm_request_threaded_irq(twl-dev, twl-irq, NULL,
  twl4030_usb_irq, IRQF_TRIGGER_FALLING |
  IRQF_TRIGGER_RISING | IRQF_ONESHOT, twl4030_usb, twl);
 
 can you split this into two patches ? drivers/phy will be taken by
 Kishon and drivers/usb/phy by me. another possibility is that I get an
 Acked-by from Kishon and I can take $subject as is.

Oops yes sorry I already forgot I'm patching twl6030 too. Below
is the updated version of this patch for Kishon with just the
twl4030 changes. I will post the twl6030 changes separately.

Regards,

Tony

8 -
From: Tony Lindgren t...@atomide.com
Date: Mon, 18 Aug 2014 07:54:16 -0700
Subject: [PATCH] usb: phy: twl4030-usb: Remove unused irq_enabled

It's not being used any longer.

Signed-off-by: Tony Lindgren t...@atomide.com

--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -164,7 +164,6 @@ struct twl4030_usb {
enum omap_musb_vbus_id_status linkstat;
boolvbus_supplied;
u8  asleep;
-   boolirq_enabled;
 
struct delayed_work id_workaround_work;
 };
@@ -755,7 +754,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 * set_host() and/or set_peripheral() ... OTG_capable boards
 * need both handles, otherwise just one suffices.
 */
-   twl-irq_enabled = true;
status = devm_request_threaded_irq(twl-dev, twl-irq, NULL,
twl4030_usb_irq, IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT, twl4030_usb, twl);
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled

2014-08-27 Thread Tony Lindgren 
It's not being used any longer.

Signed-off-by: Tony Lindgren t...@atomide.com
---
 drivers/phy/phy-twl4030-usb.c | 2 --
 drivers/usb/phy/phy-twl6030-usb.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
index 9cd33a4..bc28ecc 100644
--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -164,7 +164,6 @@ struct twl4030_usb {
enum omap_musb_vbus_id_status linkstat;
boolvbus_supplied;
u8  asleep;
-   boolirq_enabled;
 
struct delayed_work id_workaround_work;
 };
@@ -755,7 +754,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 * set_host() and/or set_peripheral() ... OTG_capable boards
 * need both handles, otherwise just one suffices.
 */
-   twl-irq_enabled = true;
status = devm_request_threaded_irq(twl-dev, twl-irq, NULL,
twl4030_usb_irq, IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT, twl4030_usb, twl);
diff --git a/drivers/usb/phy/phy-twl6030-usb.c 
b/drivers/usb/phy/phy-twl6030-usb.c
index 04778cf..44ea082 100644
--- a/drivers/usb/phy/phy-twl6030-usb.c
+++ b/drivers/usb/phy/phy-twl6030-usb.c
@@ -104,7 +104,6 @@ struct twl6030_usb {
int irq2;
enum omap_musb_vbus_id_status linkstat;
u8  asleep;
-   boolirq_enabled;
boolvbus_enable;
const char  *regulator;
 };
@@ -373,7 +372,6 @@ static int twl6030_usb_probe(struct platform_device *pdev)
 
INIT_WORK(twl-set_vbus_work, otg_set_vbus_work);
 
-   twl-irq_enabled = true;
status = request_threaded_irq(twl-irq1, NULL, twl6030_usbotg_irq,
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | 
IRQF_ONESHOT,
twl6030_usb, twl);
-- 
1.8.1.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled

2014-08-27 Thread Felipe Balbi 
Hi,

On Wed, Aug 27, 2014 at 04:28:07PM -0700, Tony Lindgren wrote:
 It's not being used any longer.
 
 Signed-off-by: Tony Lindgren t...@atomide.com
 ---
  drivers/phy/phy-twl4030-usb.c | 2 --
  drivers/usb/phy/phy-twl6030-usb.c | 2 --
  2 files changed, 4 deletions(-)
 
 diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
 index 9cd33a4..bc28ecc 100644
 --- a/drivers/phy/phy-twl4030-usb.c
 +++ b/drivers/phy/phy-twl4030-usb.c
 @@ -164,7 +164,6 @@ struct twl4030_usb {
   enum omap_musb_vbus_id_status linkstat;
   boolvbus_supplied;
   u8  asleep;
 - boolirq_enabled;
  
   struct delayed_work id_workaround_work;
  };
 @@ -755,7 +754,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
* set_host() and/or set_peripheral() ... OTG_capable boards
* need both handles, otherwise just one suffices.
*/
 - twl-irq_enabled = true;
   status = devm_request_threaded_irq(twl-dev, twl-irq, NULL,
   twl4030_usb_irq, IRQF_TRIGGER_FALLING |
   IRQF_TRIGGER_RISING | IRQF_ONESHOT, twl4030_usb, twl);

can you split this into two patches ? drivers/phy will be taken by
Kishon and drivers/usb/phy by me. another possibility is that I get an
Acked-by from Kishon and I can take $subject as is.

-- 
balbi


signature.asc
Description: Digital signature