Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
On 19/10/15 19:01, Tony Lindgren wrote:
> * Roger Quadros [151014 03:48]:
>> Let's keep the SSI ports disabled in the omap3.dtsi to avoid
>> getting the following noise on the console for boards that don't
>> use the SSI ports.
>>
>> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
>>
>> As omap3-n900 uses one SSI port, mark it enabled there.
>
> This is the wrong way around.. The SSI ports are there on all omap3 SoCs,
> we do want to have the struct device created for them. It's best to have
> the driver probe and then idle SSI and bail out. Marking something with
> status = "disabled" should be only used if you really want to avoid kernel
> touching the device at all, for example, if something is managed from
> the start by a copropcessor.
Agreed. Please ignore this patch.
cheers,
-roger
>
>
>> Signed-off-by: Roger Quadros
>> ---
>> arch/arm/boot/dts/omap3-n900.dts | 1 +
>> arch/arm/boot/dts/omap3.dtsi | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-n900.dts
>> b/arch/arm/boot/dts/omap3-n900.dts
>> index 5f5e0f3..bdb72fb 100644
>> --- a/arch/arm/boot/dts/omap3-n900.dts
>> +++ b/arch/arm/boot/dts/omap3-n900.dts
>> @@ -949,6 +949,7 @@
>> };
>>
>> &ssi_port1 {
>> +status = "ok";
>> pinctrl-names = "default";
>> pinctrl-0 = <&ssi_pins>;
>>
>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>> index 8a2b253..25b0b37 100644
>> --- a/arch/arm/boot/dts/omap3.dtsi
>> +++ b/arch/arm/boot/dts/omap3.dtsi
>> @@ -815,6 +815,7 @@
>> interrupt-parent = <&intc>;
>> interrupts = <67>,
>> <68>;
>> +status = "disabled";
>> };
>>
>> ssi_port2: ssi-port@4805b000 {
>> @@ -828,6 +829,7 @@
>> interrupt-parent = <&intc>;
>> interrupts = <69>,
>> <70>;
>> +status = "disabled";
>> };
>> };
>> };
>> --
>> 2.1.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
* Roger Quadros [151014 03:48]:
> Let's keep the SSI ports disabled in the omap3.dtsi to avoid
> getting the following noise on the console for boards that don't
> use the SSI ports.
>
> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
>
> As omap3-n900 uses one SSI port, mark it enabled there.
This is the wrong way around.. The SSI ports are there on all omap3 SoCs,
we do want to have the struct device created for them. It's best to have
the driver probe and then idle SSI and bail out. Marking something with
status = "disabled" should be only used if you really want to avoid kernel
touching the device at all, for example, if something is managed from
the start by a copropcessor.
Regards,
Tony
> Signed-off-by: Roger Quadros
> ---
> arch/arm/boot/dts/omap3-n900.dts | 1 +
> arch/arm/boot/dts/omap3.dtsi | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts
> b/arch/arm/boot/dts/omap3-n900.dts
> index 5f5e0f3..bdb72fb 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -949,6 +949,7 @@
> };
>
> &ssi_port1 {
> + status = "ok";
> pinctrl-names = "default";
> pinctrl-0 = <&ssi_pins>;
>
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index 8a2b253..25b0b37 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -815,6 +815,7 @@
> interrupt-parent = <&intc>;
> interrupts = <67>,
><68>;
> + status = "disabled";
> };
>
> ssi_port2: ssi-port@4805b000 {
> @@ -828,6 +829,7 @@
> interrupt-parent = <&intc>;
> interrupts = <69>,
><70>;
> + status = "disabled";
> };
> };
> };
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
On 14/10/15 14:37, Sebastian Reichel wrote: > Hi, > > On Wed, Oct 14, 2015 at 02:27:27PM +0300, Roger Quadros wrote: >> On 14/10/15 14:19, Sebastian Reichel wrote: >>> On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote: Let's keep the SSI ports disabled in the omap3.dtsi to avoid getting the following noise on the console for boards that don't use the SSI ports. "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" As omap3-n900 uses one SSI port, mark it enabled there. >> >> Would it be preferable to disable the ssi-controller node as well in the >> omap3.dtsi file? > > If I remember it correctly, existing, but unused IP-Cores > should not be disabled in DT, so that hwmod picks them up > for power management. OK. > > Note, that it actually is disabled in omap3.dtsi and then enabled in > omap34xx/omap36xx dts files (the other variants do not have an ssi > module). Thanks for the info :) cheers, -roger signature.asc Description: OpenPGP digital signature
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Hi, On Wed, Oct 14, 2015 at 02:27:27PM +0300, Roger Quadros wrote: > On 14/10/15 14:19, Sebastian Reichel wrote: > > On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote: > >> Let's keep the SSI ports disabled in the omap3.dtsi to avoid > >> getting the following noise on the console for boards that don't > >> use the SSI ports. > >> > >> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" > >> > >> As omap3-n900 uses one SSI port, mark it enabled there. > > Would it be preferable to disable the ssi-controller node as well in the > omap3.dtsi file? If I remember it correctly, existing, but unused IP-Cores should not be disabled in DT, so that hwmod picks them up for power management. Note, that it actually is disabled in omap3.dtsi and then enabled in omap34xx/omap36xx dts files (the other variants do not have an ssi module). -- Sebastian signature.asc Description: PGP signature
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
On 14/10/15 14:19, Sebastian Reichel wrote: > Hi, > > On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote: >> Let's keep the SSI ports disabled in the omap3.dtsi to avoid >> getting the following noise on the console for boards that don't >> use the SSI ports. >> >> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" >> >> As omap3-n900 uses one SSI port, mark it enabled there. >> >> Signed-off-by: Roger Quadros > > Acked-By: Sebastian Reichel Would it be preferable to disable the ssi-controller node as well in the omap3.dtsi file? cheers, -roger signature.asc Description: OpenPGP digital signature
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Hi, On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote: > Let's keep the SSI ports disabled in the omap3.dtsi to avoid > getting the following noise on the console for boards that don't > use the SSI ports. > > "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" > > As omap3-n900 uses one SSI port, mark it enabled there. > > Signed-off-by: Roger Quadros Acked-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Hi Pali, On Wed, Oct 14, 2015 at 12:53:04PM +0200, Pali Rohár wrote: > On Wednesday 14 October 2015 13:44:16 Roger Quadros wrote: > > Let's keep the SSI ports disabled in the omap3.dtsi to avoid > > getting the following noise on the console for boards that don't > > use the SSI ports. > > > > "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" > > > > As omap3-n900 uses one SSI port, mark it enabled there. > > > > Sebastian, why is second SSI port disabled on N900? It is not used or > in DTS file are missing some definitions? Since the second SSI port is not used on the Nokia N900. It's pins are used for other things, e.g. as GPIO. It's easily verifiable by checking the mux data: $ grep -C1 "ssi2_" arch/arm/mach-omap2/mux34xx.c _OMAP3_MUXENTRY(CAM_D10, 109, "cam_d10", "ssi2_wake", NULL, NULL, "gpio_109", "hw_dbg8", NULL, "safe_mode"), _OMAP3_MUXENTRY(CAM_D2, 101, "cam_d2", "ssi2_rdy_tx", NULL, NULL, "gpio_101", "hw_dbg4", NULL, "safe_mode"), _OMAP3_MUXENTRY(CAM_D3, 102, "cam_d3", "ssi2_dat_rx", NULL, NULL, "gpio_102", "hw_dbg5", NULL, "safe_mode"), _OMAP3_MUXENTRY(CAM_D4, 103, "cam_d4", "ssi2_flag_rx", NULL, NULL, "gpio_103", "hw_dbg6", NULL, "safe_mode"), _OMAP3_MUXENTRY(CAM_D5, 104, "cam_d5", "ssi2_rdy_rx", NULL, NULL, "gpio_104", "hw_dbg7", NULL, "safe_mode"), _OMAP3_MUXENTRY(CAM_HS, 94, "cam_hs", "ssi2_dat_tx", NULL, NULL, "gpio_94", "hw_dbg0", NULL, "safe_mode"), _OMAP3_MUXENTRY(CAM_VS, 95, "cam_vs", "ssi2_flag_tx", NULL, NULL, "gpio_95", "hw_dbg1", NULL, "safe_mode"), At least gpio 104 is already used for resetting the tsc2005. -- Sebastian signature.asc Description: PGP signature
Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
On Wednesday 14 October 2015 13:44:16 Roger Quadros wrote: > Let's keep the SSI ports disabled in the omap3.dtsi to avoid > getting the following noise on the console for boards that don't > use the SSI ports. > > "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" > > As omap3-n900 uses one SSI port, mark it enabled there. > Sebastian, why is second SSI port disabled on N900? It is not used or in DTS file are missing some definitions? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Let's keep the SSI ports disabled in the omap3.dtsi to avoid
getting the following noise on the console for boards that don't
use the SSI ports.
"omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
As omap3-n900 uses one SSI port, mark it enabled there.
Signed-off-by: Roger Quadros
---
arch/arm/boot/dts/omap3-n900.dts | 1 +
arch/arm/boot/dts/omap3.dtsi | 2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 5f5e0f3..bdb72fb 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -949,6 +949,7 @@
};
&ssi_port1 {
+ status = "ok";
pinctrl-names = "default";
pinctrl-0 = <&ssi_pins>;
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index 8a2b253..25b0b37 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -815,6 +815,7 @@
interrupt-parent = <&intc>;
interrupts = <67>,
<68>;
+ status = "disabled";
};
ssi_port2: ssi-port@4805b000 {
@@ -828,6 +829,7 @@
interrupt-parent = <&intc>;
interrupts = <69>,
<70>;
+ status = "disabled";
};
};
};
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
