Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data
Hi, On Tue, Jul 17, 2012 at 6:06 PM, Sergei Shtylyov wrote: > Hello. > > > On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: > >> Add ocp2scp data node in omap4 device tree file. > > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/omap4.dtsi |8 >> 1 files changed, 8 insertions(+), 0 deletions(-) > > >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >> index 359c497..bda5df3 100644 >> --- a/arch/arm/boot/dts/omap4.dtsi >> +++ b/arch/arm/boot/dts/omap4.dtsi >> @@ -272,5 +272,13 @@ >> ti,hwmods = "mmc5"; >> ti,needs-special-reset; >> }; >> + >> + ocp2scp@4a0ad000 { > > >"reg" property is absent, so why do you give the node name an address > postfix? When I was initially developing, I had "reg" property populated. Those info is now obtained from *ti,hwmods*. I'll resend the patch removing it. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data
Hello. On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 359c497..bda5df3 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -272,5 +272,13 @@ ti,hwmods = "mmc5"; ti,needs-special-reset; }; + + ocp2scp@4a0ad000 { "reg" property is absent, so why do you give the node name an address postfix? + compatible = "ti,omap-ocp2scp"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + ti,hwmods = "ocp2scp_usb_phy"; + }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] arm/dts: omap4: Add ocp2scp data
Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 359c497..bda5df3 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -272,5 +272,13 @@ ti,hwmods = "mmc5"; ti,needs-special-reset; }; + + ocp2scp@4a0ad000 { + compatible = "ti,omap-ocp2scp"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + ti,hwmods = "ocp2scp_usb_phy"; + }; }; }; -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html