Re: [PATCH 2/3] OMAP: PM: use omap_device API for suspend/resume
Paul Walmsley writes:
> Hi Kevin,
>
> aside from these comments:
>
>http://marc.info/?l=linux-omap&m=127735008820992&w=2
>
> one other minor issue -
>
> On Wed, 23 Jun 2010, Kevin Hilman wrote:
>
>> Hook into the platform bus methods for suspend and resume and
>> use the omap_device API to automatically idle and enable the
>> device on suspend and resume.
>>
>> This allows device drivers to get rid of direct management of their
>> clocks in their suspend/resume paths, and let omap_device do it for
>> them.
>>
>> We currently use the _noirq (late suspend, early resume) versions of
>> the suspend/resume methods to ensure that the device is not disabled
>> too early for any drivers also using the _noirq methods.
>>
>> NOTE: only works for devices with omap_hwmod support.
>>
>> Signed-off-by: Kevin Hilman
>> ---
>> arch/arm/mach-omap2/pm_bus.c | 61
>> ++
>> 1 files changed, 61 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm_bus.c b/arch/arm/mach-omap2/pm_bus.c
>> index 69acaa5..3787da8 100644
>> --- a/arch/arm/mach-omap2/pm_bus.c
>> +++ b/arch/arm/mach-omap2/pm_bus.c
>> @@ -70,3 +70,64 @@ int platform_pm_runtime_idle(struct device *dev)
>> };
>> #endif /* CONFIG_PM_RUNTIME */
>>
>> +#ifdef CONFIG_SUSPEND
>> +int platform_pm_suspend_noirq(struct device *dev)
>> +{
>> +struct device_driver *drv = dev->driver;
>> +struct platform_device *pdev = to_platform_device(dev);
>> +struct omap_device *odev = to_omap_device(pdev);
>> +int ret = 0;
>> +
>> +if (!drv)
>> +return 0;
>> +
>> +if (drv->pm) {
>> +if (drv->pm->suspend_noirq)
>> +ret = drv->pm->suspend_noirq(dev);
>> +}
>> +
>> +if (omap_device_is_valid(odev)) {
>> +if (odev->flags & OMAP_DEVICE_NO_BUS_SUSPEND) {
>> +dev_dbg(dev, "no automatic bus-level system resume.\n");
>
> I guess this should read "suspend" above?
>
Yup, thanks.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] OMAP: PM: use omap_device API for suspend/resume
Hi Kevin,
aside from these comments:
http://marc.info/?l=linux-omap&m=127735008820992&w=2
one other minor issue -
On Wed, 23 Jun 2010, Kevin Hilman wrote:
> Hook into the platform bus methods for suspend and resume and
> use the omap_device API to automatically idle and enable the
> device on suspend and resume.
>
> This allows device drivers to get rid of direct management of their
> clocks in their suspend/resume paths, and let omap_device do it for
> them.
>
> We currently use the _noirq (late suspend, early resume) versions of
> the suspend/resume methods to ensure that the device is not disabled
> too early for any drivers also using the _noirq methods.
>
> NOTE: only works for devices with omap_hwmod support.
>
> Signed-off-by: Kevin Hilman
> ---
> arch/arm/mach-omap2/pm_bus.c | 61
> ++
> 1 files changed, 61 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm_bus.c b/arch/arm/mach-omap2/pm_bus.c
> index 69acaa5..3787da8 100644
> --- a/arch/arm/mach-omap2/pm_bus.c
> +++ b/arch/arm/mach-omap2/pm_bus.c
> @@ -70,3 +70,64 @@ int platform_pm_runtime_idle(struct device *dev)
> };
> #endif /* CONFIG_PM_RUNTIME */
>
> +#ifdef CONFIG_SUSPEND
> +int platform_pm_suspend_noirq(struct device *dev)
> +{
> + struct device_driver *drv = dev->driver;
> + struct platform_device *pdev = to_platform_device(dev);
> + struct omap_device *odev = to_omap_device(pdev);
> + int ret = 0;
> +
> + if (!drv)
> + return 0;
> +
> + if (drv->pm) {
> + if (drv->pm->suspend_noirq)
> + ret = drv->pm->suspend_noirq(dev);
> + }
> +
> + if (omap_device_is_valid(odev)) {
> + if (odev->flags & OMAP_DEVICE_NO_BUS_SUSPEND) {
> + dev_dbg(dev, "no automatic bus-level system resume.\n");
I guess this should read "suspend" above?
> + return 0;
> + }
> +
> + dev_dbg(dev, "%s\n", __func__);
> + omap_device_idle(pdev);
> + } else {
> + dev_dbg(dev, "not an omap_device\n");
> + }
> +
> + return ret;
> +}
> +
> +int platform_pm_resume_noirq(struct device *dev)
> +{
> + struct device_driver *drv = dev->driver;
> + struct platform_device *pdev = to_platform_device(dev);
> + struct omap_device *odev = to_omap_device(pdev);
> + int ret = 0;
> +
> + if (omap_device_is_valid(odev)) {
> + if (odev->flags & OMAP_DEVICE_NO_BUS_SUSPEND) {
> + dev_dbg(dev, "no automatic bus-level system resume.\n");
> + return 0;
> + }
> +
> + dev_dbg(dev, "%s\n", __func__);
> + omap_device_enable(pdev);
> + } else {
> + dev_dbg(dev, "not an omap_device\n");
> + }
> +
> + if (!drv)
> + return 0;
> +
> + if (drv->pm) {
> + if (drv->pm->resume_noirq)
> + ret = drv->pm->resume_noirq(dev);
> + }
> +
> + return ret;
> +}
> +#endif /* CONFIG_SUSPEND */
> --
> 1.7.0.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] OMAP: PM: use omap_device API for suspend/resume
Hook into the platform bus methods for suspend and resume and
use the omap_device API to automatically idle and enable the
device on suspend and resume.
This allows device drivers to get rid of direct management of their
clocks in their suspend/resume paths, and let omap_device do it for
them.
We currently use the _noirq (late suspend, early resume) versions of
the suspend/resume methods to ensure that the device is not disabled
too early for any drivers also using the _noirq methods.
NOTE: only works for devices with omap_hwmod support.
Signed-off-by: Kevin Hilman
---
arch/arm/mach-omap2/pm_bus.c | 61 ++
1 files changed, 61 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm_bus.c b/arch/arm/mach-omap2/pm_bus.c
index 69acaa5..3787da8 100644
--- a/arch/arm/mach-omap2/pm_bus.c
+++ b/arch/arm/mach-omap2/pm_bus.c
@@ -70,3 +70,64 @@ int platform_pm_runtime_idle(struct device *dev)
};
#endif /* CONFIG_PM_RUNTIME */
+#ifdef CONFIG_SUSPEND
+int platform_pm_suspend_noirq(struct device *dev)
+{
+ struct device_driver *drv = dev->driver;
+ struct platform_device *pdev = to_platform_device(dev);
+ struct omap_device *odev = to_omap_device(pdev);
+ int ret = 0;
+
+ if (!drv)
+ return 0;
+
+ if (drv->pm) {
+ if (drv->pm->suspend_noirq)
+ ret = drv->pm->suspend_noirq(dev);
+ }
+
+ if (omap_device_is_valid(odev)) {
+ if (odev->flags & OMAP_DEVICE_NO_BUS_SUSPEND) {
+ dev_dbg(dev, "no automatic bus-level system resume.\n");
+ return 0;
+ }
+
+ dev_dbg(dev, "%s\n", __func__);
+ omap_device_idle(pdev);
+ } else {
+ dev_dbg(dev, "not an omap_device\n");
+ }
+
+ return ret;
+}
+
+int platform_pm_resume_noirq(struct device *dev)
+{
+ struct device_driver *drv = dev->driver;
+ struct platform_device *pdev = to_platform_device(dev);
+ struct omap_device *odev = to_omap_device(pdev);
+ int ret = 0;
+
+ if (omap_device_is_valid(odev)) {
+ if (odev->flags & OMAP_DEVICE_NO_BUS_SUSPEND) {
+ dev_dbg(dev, "no automatic bus-level system resume.\n");
+ return 0;
+ }
+
+ dev_dbg(dev, "%s\n", __func__);
+ omap_device_enable(pdev);
+ } else {
+ dev_dbg(dev, "not an omap_device\n");
+ }
+
+ if (!drv)
+ return 0;
+
+ if (drv->pm) {
+ if (drv->pm->resume_noirq)
+ ret = drv->pm->resume_noirq(dev);
+ }
+
+ return ret;
+}
+#endif /* CONFIG_SUSPEND */
--
1.7.0.2
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
