Re: [PATCH 2/7] mailbox/omap: remove OMAP1 mailbox driver

2014-06-26 Thread Aaro Koskinen
Hi,

On Thu, Jun 26, 2014 at 03:28:14AM -0700, Tony Lindgren wrote:
> * Suman Anna  [140624 17:45]:
> > There are no existing users for OMAP1 mailbox driver
> > in kernel. Commit ab6f775 "Removing dead OMAP_DSP"
> > has cleaned up all the dead code related to the only
> > possible user, including the creation of the mailbox
> > platform device.
> > 
> > Remove this stale driver so that the OMAP mailbox
> > driver can be simplified and streamlined better for
> > converting to mailbox framework.
> > 
> > Cc: Aaro Koskinen 
> > Signed-off-by: Suman Anna 
> 
> For the omap1_defconfig change:
> 
> Acked-by: Tony Lindgren 

I'm also OK with this change.

Acked-by: Aaro Koskinen 

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/7] mailbox/omap: remove OMAP1 mailbox driver

2014-06-26 Thread Tony Lindgren
* Suman Anna  [140624 17:45]:
> There are no existing users for OMAP1 mailbox driver
> in kernel. Commit ab6f775 "Removing dead OMAP_DSP"
> has cleaned up all the dead code related to the only
> possible user, including the creation of the mailbox
> platform device.
> 
> Remove this stale driver so that the OMAP mailbox
> driver can be simplified and streamlined better for
> converting to mailbox framework.
> 
> Cc: Aaro Koskinen 
> Signed-off-by: Suman Anna 

For the omap1_defconfig change:

Acked-by: Tony Lindgren 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 2/7] mailbox/omap: remove OMAP1 mailbox driver

2014-06-24 Thread Suman Anna
There are no existing users for OMAP1 mailbox driver
in kernel. Commit ab6f775 "Removing dead OMAP_DSP"
has cleaned up all the dead code related to the only
possible user, including the creation of the mailbox
platform device.

Remove this stale driver so that the OMAP mailbox
driver can be simplified and streamlined better for
converting to mailbox framework.

Cc: Aaro Koskinen 
Signed-off-by: Suman Anna 
---
 arch/arm/configs/omap1_defconfig |   2 -
 drivers/mailbox/Kconfig  |  15 +--
 drivers/mailbox/Makefile |   2 -
 drivers/mailbox/mailbox-omap1.c  | 203 ---
 4 files changed, 3 insertions(+), 219 deletions(-)
 delete mode 100644 drivers/mailbox/mailbox-omap1.c

diff --git a/arch/arm/configs/omap1_defconfig b/arch/arm/configs/omap1_defconfig
index ce541bb..115cda9 100644
--- a/arch/arm/configs/omap1_defconfig
+++ b/arch/arm/configs/omap1_defconfig
@@ -26,8 +26,6 @@ CONFIG_ARCH_OMAP=y
 CONFIG_ARCH_OMAP1=y
 CONFIG_OMAP_RESET_CLOCKS=y
 # CONFIG_OMAP_MUX is not set
-CONFIG_MAILBOX=y
-CONFIG_OMAP1_MBOX=y
 CONFIG_OMAP_32K_TIMER=y
 CONFIG_OMAP_DM_TIMER=y
 CONFIG_ARCH_OMAP730=y
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index c8b5c13..1ec8f4e 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -20,17 +20,8 @@ config OMAP_MBOX
tristate
help
  This option is selected by any OMAP architecture specific mailbox
- driver such as CONFIG_OMAP1_MBOX or CONFIG_OMAP2PLUS_MBOX. This
- enables the common OMAP mailbox framework code.
-
-config OMAP1_MBOX
-   tristate "OMAP1 Mailbox framework support"
-   depends on ARCH_OMAP1
-   select OMAP_MBOX
-   help
- Mailbox implementation for OMAP chips with hardware for
- interprocessor communication involving DSP in OMAP1. Say Y here
- if you want to use OMAP1 Mailbox framework support.
+ driver such as CONFIG_OMAP2PLUS_MBOX. This enables the common OMAP
+ mailbox framework code.
 
 config OMAP2PLUS_MBOX
tristate "OMAP2+ Mailbox framework support"
@@ -44,7 +35,7 @@ config OMAP2PLUS_MBOX
 
 config OMAP_MBOX_KFIFO_SIZE
int "Mailbox kfifo default buffer size (bytes)"
-   depends on OMAP2PLUS_MBOX || OMAP1_MBOX
+   depends on OMAP2PLUS_MBOX
default 256
help
  Specify the default size of mailbox's kfifo buffers (bytes).
diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile
index e0facb3..d023feb 100644
--- a/drivers/mailbox/Makefile
+++ b/drivers/mailbox/Makefile
@@ -1,7 +1,5 @@
 obj-$(CONFIG_PL320_MBOX)   += pl320-ipc.o
 
 obj-$(CONFIG_OMAP_MBOX)+= omap-mailbox.o
-obj-$(CONFIG_OMAP1_MBOX)   += mailbox_omap1.o
-mailbox_omap1-objs := mailbox-omap1.o
 obj-$(CONFIG_OMAP2PLUS_MBOX)   += mailbox_omap2.o
 mailbox_omap2-objs := mailbox-omap2.o
diff --git a/drivers/mailbox/mailbox-omap1.c b/drivers/mailbox/mailbox-omap1.c
deleted file mode 100644
index 9001b76..000
--- a/drivers/mailbox/mailbox-omap1.c
+++ /dev/null
@@ -1,203 +0,0 @@
-/*
- * Mailbox reservation modules for OMAP1
- *
- * Copyright (C) 2006-2009 Nokia Corporation
- * Written by: Hiroshi DOYU 
- *
- * This file is subject to the terms and conditions of the GNU General Public
- * License.  See the file "COPYING" in the main directory of this archive
- * for more details.
- */
-
-#include 
-#include 
-#include 
-#include 
-
-#include "omap-mbox.h"
-
-#define MAILBOX_ARM2DSP1   0x00
-#define MAILBOX_ARM2DSP1b  0x04
-#define MAILBOX_DSP2ARM1   0x08
-#define MAILBOX_DSP2ARM1b  0x0c
-#define MAILBOX_DSP2ARM2   0x10
-#define MAILBOX_DSP2ARM2b  0x14
-#define MAILBOX_ARM2DSP1_Flag  0x18
-#define MAILBOX_DSP2ARM1_Flag  0x1c
-#define MAILBOX_DSP2ARM2_Flag  0x20
-
-static void __iomem *mbox_base;
-
-struct omap_mbox1_fifo {
-   unsigned long cmd;
-   unsigned long data;
-   unsigned long flag;
-};
-
-struct omap_mbox1_priv {
-   struct omap_mbox1_fifo tx_fifo;
-   struct omap_mbox1_fifo rx_fifo;
-};
-
-static inline int mbox_read_reg(size_t ofs)
-{
-   return __raw_readw(mbox_base + ofs);
-}
-
-static inline void mbox_write_reg(u32 val, size_t ofs)
-{
-   __raw_writew(val, mbox_base + ofs);
-}
-
-/* msg */
-static mbox_msg_t omap1_mbox_fifo_read(struct omap_mbox *mbox)
-{
-   struct omap_mbox1_fifo *fifo =
-   &((struct omap_mbox1_priv *)mbox->priv)->rx_fifo;
-   mbox_msg_t msg;
-
-   msg = mbox_read_reg(fifo->data);
-   msg |= ((mbox_msg_t) mbox_read_reg(fifo->cmd)) << 16;
-
-   return msg;
-}
-
-static void
-omap1_mbox_fifo_write(struct omap_mbox *mbox, mbox_msg_t msg)
-{
-   struct omap_mbox1_fifo *fifo =
-   &((struct omap_mbox1_priv *)mbox->priv)->tx_fifo;
-
-   mbox_write_reg(msg & 0x, fifo->data);
-   mbox_write_reg(msg >> 16, fifo->cmd);
-}
-
-static int omap1_m