Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
On 03/14/2011 05:42 PM, Somebody in the thread at some point said: Hi - It looks like this series can be rebased on v2.6.38-rc8 and should merge just fine with what we have queued in omap-for-linus. I guess I forgot we already did the i2c-omap hwmod conversion last merge window :) Andy, please repost the related patches against v2.6.38-rc8 with the acks posted earlier. Alright, I will do that with the reordered patch from Benoit and the change to BIT() instead of constants. Thanks. -Andy -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
Hi Ben & Andy, * Tony Lindgren [110309 11:09]: > * Cousson, Benoit [110309 06:00]: > > Hi Tony, > > > > On 3/9/2011 12:38 AM, Tony Lindgren wrote: > > >* Cousson, Benoit [110308 13:34]: > > >>Hi Andy, > > >> > > >>Thanks for that really fast update. That looks pretty good at first > > >>glance. I still have to review in details. > > > > > >Yes nice job! > > > > > >>And we need to find some volunteers for OMAP1& 2 testing. > > > > > >I gave it a quick try on osk5912, seems to work just fine. > > >Will apply these for testing purposes to linux-omap tree while > > >waiting for the minor fixes. > > > > > >Looks like Benoit should take the arch/arm/*omap*/*hwmod* > > >patches, the rest should go throug Ben. So for all of them: > > > > Paul and I already acked the hwmod data, but the whole series should > > maybe go through Ben, because the hwmod files will need some defines > > added in the i2c header file. So we cannot separate the hwmod* > > patches from the driver files patches. > > Unfortunately the hwmod patches depend on omap-for-linus branch.. > > Considering this, it's probably best that I queue the whole series > assuming we get acks from Ben for the driver related changes. After looking at this again, I've changed my mind. It looks like this series can be rebased on v2.6.38-rc8 and should merge just fine with what we have queued in omap-for-linus. I guess I forgot we already did the i2c-omap hwmod conversion last merge window :) Andy, please repost the related patches against v2.6.38-rc8 with the acks posted earlier. Then Ben, please feel free to queue it after you get the rebased series. We've had this series applied for testing for a while. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
* Cousson, Benoit [110309 06:00]: > Hi Tony, > > On 3/9/2011 12:38 AM, Tony Lindgren wrote: > >* Cousson, Benoit [110308 13:34]: > >>Hi Andy, > >> > >>Thanks for that really fast update. That looks pretty good at first > >>glance. I still have to review in details. > > > >Yes nice job! > > > >>And we need to find some volunteers for OMAP1& 2 testing. > > > >I gave it a quick try on osk5912, seems to work just fine. > >Will apply these for testing purposes to linux-omap tree while > >waiting for the minor fixes. > > > >Looks like Benoit should take the arch/arm/*omap*/*hwmod* > >patches, the rest should go throug Ben. So for all of them: > > Paul and I already acked the hwmod data, but the whole series should > maybe go through Ben, because the hwmod files will need some defines > added in the i2c header file. So we cannot separate the hwmod* > patches from the driver files patches. Unfortunately the hwmod patches depend on omap-for-linus branch.. Considering this, it's probably best that I queue the whole series assuming we get acks from Ben for the driver related changes. > I just have one minor comment to keep the OMAP4 data in sync with > the autogen, but if Andy does not have any important update to do on > that series, I can potentially fix that later. OK Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
Hi Tony, On 3/9/2011 12:38 AM, Tony Lindgren wrote: * Cousson, Benoit [110308 13:34]: Hi Andy, Thanks for that really fast update. That looks pretty good at first glance. I still have to review in details. Yes nice job! And we need to find some volunteers for OMAP1& 2 testing. I gave it a quick try on osk5912, seems to work just fine. Will apply these for testing purposes to linux-omap tree while waiting for the minor fixes. Looks like Benoit should take the arch/arm/*omap*/*hwmod* patches, the rest should go throug Ben. So for all of them: Paul and I already acked the hwmod data, but the whole series should maybe go through Ben, because the hwmod files will need some defines added in the i2c header file. So we cannot separate the hwmod* patches from the driver files patches. I just have one minor comment to keep the OMAP4 data in sync with the autogen, but if Andy does not have any important update to do on that series, I can potentially fix that later. Regards Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
* Cousson, Benoit [110308 13:34]: > Hi Andy, > > Thanks for that really fast update. That looks pretty good at first > glance. I still have to review in details. Yes nice job! > And we need to find some volunteers for OMAP1 & 2 testing. I gave it a quick try on osk5912, seems to work just fine. Will apply these for testing purposes to linux-omap tree while waiting for the minor fixes. Looks like Benoit should take the arch/arm/*omap*/*hwmod* patches, the rest should go throug Ben. So for all of them: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
Hi Andy, Thanks for that really fast update. That looks pretty good at first glance. I still have to review in details. And we need to find some volunteers for OMAP1 & 2 testing. Thanks, Benoit On 3/8/2011 12:07 PM, Andy Green wrote: The following series removes cpu_...() usage completely from the omap-i2c driver by having decisions about functional implementation choices in the SoC held in cpu-specific hwmod tables that are already established, or for OMAP1 where there is no hwmod, set at OMAP1-specific i2c bus addition time. Along the way it solves two issues with the existing implementation, that only 16-bit accesses are documented to be allowed to the I2C peripheral unit, and that due to a confusion in the existing driver about whether it is faced with a newer IP version on OMAP3530, currently it writes to a random non-existent I2C register at times on that platform. The patch series is quite extended from the first try thanks to comments from Benoit Cousson. Patches are tested on OMAP3530 and OMAP4430 I have but will need confirming they don't break anything on OMAP1xxx and OMAP2xxx as agreed with Benoit. Cc: patc...@linaro.org Cc: Ben Dooks Reported-by: Peter Maydell --- Andy Green (18): I2C: OMAP1/OMAP2+: prepend I2C IP version to probed version shown in dev_info I2C: OMAP2+: Convert omap I2C driver to use feature implementation flags from platform data I2C: OMAP1: set i2c unit feature implementation flags in platform data I2C: OMAP2+: add correct functionality flags to all omap2plus i2c dev_attr I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test I2C: OMAP2+: Pass flags up to omap i2c platform_data as well I2C: OMAP1/OMAP2+: add flags field to omap i2c platform data I2C: OMAP2+: increase omap_i2c_dev_attr flags from u8 to u32 I2C: OMAP2+: address confused probed version naming I2C: OMAP2+: Solve array bounds overflow error on i2c idle I2C: OMAP2+: use platform_data ip revision to select register map I2C: OMAP2+: Pass hwmod rev knowledge via platform_data when i2c bus added I2C: OMAP1: set IP revision in platform data I2C: OMAP: add rev to omap i2c platform data I2C: OMAP2+: Tag all OMAP2+ hwmod defintions with I2C IP revision I2C: OMAP2+: Introduce I2C IP versioning constants I2C: OMAP2+: Name registers in I2C IP V2 only accordingly I2C: OMAP2+: Set hwmod flags to only allow 16-bit accesses to i2c arch/arm/mach-omap2/omap_hwmod_2420_data.c |8 ++ arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 13 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 18 - arch/arm/plat-omap/i2c.c | 27 arch/arm/plat-omap/include/plat/i2c.h |3 + drivers/i2c/busses/i2c-omap.c | 98 +++- include/linux/i2c-omap.h | 29 8 files changed, 151 insertions(+), 51 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
The following series removes cpu_...() usage completely from the omap-i2c driver by having decisions about functional implementation choices in the SoC held in cpu-specific hwmod tables that are already established, or for OMAP1 where there is no hwmod, set at OMAP1-specific i2c bus addition time. Along the way it solves two issues with the existing implementation, that only 16-bit accesses are documented to be allowed to the I2C peripheral unit, and that due to a confusion in the existing driver about whether it is faced with a newer IP version on OMAP3530, currently it writes to a random non-existent I2C register at times on that platform. The patch series is quite extended from the first try thanks to comments from Benoit Cousson. Patches are tested on OMAP3530 and OMAP4430 I have but will need confirming they don't break anything on OMAP1xxx and OMAP2xxx as agreed with Benoit. Cc: patc...@linaro.org Cc: Ben Dooks Reported-by: Peter Maydell --- Andy Green (18): I2C: OMAP1/OMAP2+: prepend I2C IP version to probed version shown in dev_info I2C: OMAP2+: Convert omap I2C driver to use feature implementation flags from platform data I2C: OMAP1: set i2c unit feature implementation flags in platform data I2C: OMAP2+: add correct functionality flags to all omap2plus i2c dev_attr I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test I2C: OMAP2+: Pass flags up to omap i2c platform_data as well I2C: OMAP1/OMAP2+: add flags field to omap i2c platform data I2C: OMAP2+: increase omap_i2c_dev_attr flags from u8 to u32 I2C: OMAP2+: address confused probed version naming I2C: OMAP2+: Solve array bounds overflow error on i2c idle I2C: OMAP2+: use platform_data ip revision to select register map I2C: OMAP2+: Pass hwmod rev knowledge via platform_data when i2c bus added I2C: OMAP1: set IP revision in platform data I2C: OMAP: add rev to omap i2c platform data I2C: OMAP2+: Tag all OMAP2+ hwmod defintions with I2C IP revision I2C: OMAP2+: Introduce I2C IP versioning constants I2C: OMAP2+: Name registers in I2C IP V2 only accordingly I2C: OMAP2+: Set hwmod flags to only allow 16-bit accesses to i2c arch/arm/mach-omap2/omap_hwmod_2420_data.c |8 ++ arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 13 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 18 - arch/arm/plat-omap/i2c.c | 27 arch/arm/plat-omap/include/plat/i2c.h |3 + drivers/i2c/busses/i2c-omap.c | 98 +++- include/linux/i2c-omap.h | 29 8 files changed, 151 insertions(+), 51 deletions(-) -- Signature -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
