Re: [PATCH 22/30] mfd: build twl6030 only on omap2
On Tuesday 04 October 2011, Samuel Ortiz wrote: > On Sun, Oct 02, 2011 at 04:45:52PM +0200, Arnd Bergmann wrote: > > We can only have one pwm driver built into the kernel, > I seem to remember that Bill Gatliff was working on a PWM subsystem that would > get rid of the current pwm.h ugliness. Do we have any updates on this one ? I don't know if the work on the pwm subsystem is progressing right now, there were at one point two competing patches, but so far neither of them has made it into linux-next. > The patch below looks like a hack to me, trying to work around the current > lack of such subsystem. Absolutely. I'll clarify this in the patch description when I fix the bug pointed out by Balaji T Krishnamoorthy. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 22/30] mfd: build twl6030 only on omap2
Hi Arnd, On Sun, Oct 02, 2011 at 04:45:52PM +0200, Arnd Bergmann wrote: > We can only have one pwm driver built into the kernel, I seem to remember that Bill Gatliff was working on a PWM subsystem that would get rid of the current pwm.h ugliness. Do we have any updates on this one ? The patch below looks like a hack to me, trying to work around the current lack of such subsystem. Cheers, Samuel. > so make sure > that this one is only available on omap2 to avoid conflicts with > pwm drivers of other platforms. > > Signed-off-by: Arnd Bergmann > Cc: Samuel Ortiz > Cc: Peter Ujfalusi > Cc: Balaji T K > Cc: Hemanth V > --- > drivers/mfd/Kconfig |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 48cce35..26bebe8 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -256,8 +256,8 @@ config MFD_TWL4030_AUDIO > default n > > config TWL6030_PWM > - tristate "TWL6030 PWM (Pulse Width Modulator) Support" > - depends on TWL4030_CORE > + bool "TWL6030 PWM (Pulse Width Modulator) Support" > + depends on TWL4030_CORE && ARCH_OMAP2 > select HAVE_PWM > default n > help > -- > 1.7.5.4 > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 22/30] mfd: build twl6030 only on omap2
We can only have one pwm driver built into the kernel, so make sure that this one is only available on omap2 to avoid conflicts with pwm drivers of other platforms. Signed-off-by: Arnd Bergmann Cc: Samuel Ortiz Cc: Peter Ujfalusi Cc: Balaji T K Cc: Hemanth V --- drivers/mfd/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 48cce35..26bebe8 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -256,8 +256,8 @@ config MFD_TWL4030_AUDIO default n config TWL6030_PWM - tristate "TWL6030 PWM (Pulse Width Modulator) Support" - depends on TWL4030_CORE + bool "TWL6030 PWM (Pulse Width Modulator) Support" + depends on TWL4030_CORE && ARCH_OMAP2 select HAVE_PWM default n help -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
