RE: [PATCH 3/3] omap: zoom3: add zoom3 board support
-Original Message- From: Felipe Balbi [mailto:m...@felipebalbi.com] Sent: Friday, October 23, 2009 6:04 PM To: Pandita, Vikram Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] omap: zoom3: add zoom3 board support Hi, On Fri, Oct 23, 2009 at 02:23:26PM -0500, Vikram Pandita wrote: diff --git a/arch/arm/mach-omap2/board-zoom2-zoom3.c b/arch/arm/mach-omap2/board-zoom2-zoom3.c index 4ad9b94..d806dbf 100644 --- a/arch/arm/mach-omap2/board-zoom2-zoom3.c +++ b/arch/arm/mach-omap2/board-zoom2-zoom3.c @@ -281,7 +281,11 @@ static void __init omap_zoom2_map_io(void) omap2_map_common_io(); } +#ifdef CONFIG_MACH_OMAP_ZOOM3 +MACHINE_START(OMAP_ZOOM3, OMAP ZOOM3 board) +#else MACHINE_START(OMAP_ZOOM2, OMAP Zoom2 board) +#endif what happens if you want to build a kernel for both boards ? how about just adding a new MACHINE_START() declaration without ifdeferry ? Take a look at arch/arm/mach-omap2/board-n8x0.c for an example ;-) Yes I will have a look at this. Thanks for all the comments. My zoom3 board has gone bad and so could not look into this yet. Will keep posted. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] omap: zoom3: add zoom3 board support
Add machine type support for zoom3 board Add board type in Kconfig and Makefile Reused the zoom board file for zoom2 and zoom3 Signed-off-by: Vikram Pandita vikram.pand...@ti.com --- arch/arm/mach-omap2/Kconfig |4 arch/arm/mach-omap2/Makefile|3 +++ arch/arm/mach-omap2/board-zoom2-zoom3.c |4 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 8685df5..fa20996 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -97,6 +97,10 @@ config MACH_OMAP_ZOOM2 bool OMAP3 Zoom2 board depends on ARCH_OMAP3 ARCH_OMAP34XX +config MACH_OMAP_ZOOM3 + bool OMAP3630 Zoom3 board + depends on ARCH_OMAP3 ARCH_OMAP34XX + config MACH_CM_T35 bool CompuLab CM-T35 module depends on ARCH_OMAP3 ARCH_OMAP34XX diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 68f7419..fac13ba 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -74,6 +74,9 @@ obj-$(CONFIG_MACH_NOKIA_RX51) += board-rx51.o \ obj-$(CONFIG_MACH_OMAP_ZOOM2) += board-zoom2-zoom3.o \ mmc-twl4030.o \ board-zoom-debugboard.o +obj-$(CONFIG_MACH_OMAP_ZOOM3) += board-zoom2-zoom3.o \ + mmc-twl4030.o \ + board-zoom-debugboard.o obj-$(CONFIG_MACH_CM_T35) += board-cm-t35.o \ mmc-twl4030.o diff --git a/arch/arm/mach-omap2/board-zoom2-zoom3.c b/arch/arm/mach-omap2/board-zoom2-zoom3.c index 4ad9b94..d806dbf 100644 --- a/arch/arm/mach-omap2/board-zoom2-zoom3.c +++ b/arch/arm/mach-omap2/board-zoom2-zoom3.c @@ -281,7 +281,11 @@ static void __init omap_zoom2_map_io(void) omap2_map_common_io(); } +#ifdef CONFIG_MACH_OMAP_ZOOM3 +MACHINE_START(OMAP_ZOOM3, OMAP ZOOM3 board) +#else MACHINE_START(OMAP_ZOOM2, OMAP Zoom2 board) +#endif .phys_io= 0x4800, .io_pg_offst= ((0xfa00) 18) 0xfffc, .boot_params= 0x8100, -- 1.6.5.rc1.19.g8426 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/3] omap: zoom3: add zoom3 board support
Vikram, Just some comments I came across below. From: linux-omap-ow...@vger.kernel.org [linux-omap-ow...@vger.kernel.org] On Behalf Of Pandita, Vikram Sent: Friday, October 23, 2009 2:23 PM Add machine type support for zoom3 board Add board type in Kconfig and Makefile Reused the zoom board file for zoom2 and zoom3 Signed-off-by: Vikram Pandita vikram.pand...@ti.com --- arch/arm/mach-omap2/Kconfig |4 arch/arm/mach-omap2/Makefile|3 +++ arch/arm/mach-omap2/board-zoom2-zoom3.c |4 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 8685df5..fa20996 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -97,6 +97,10 @@ config MACH_OMAP_ZOOM2 bool OMAP3 Zoom2 board How about also clarifying here ^^ the chip version: bool OMAP3430 Zoom2 board I mean, just to stick to the convention you're putting below. depends on ARCH_OMAP3 ARCH_OMAP34XX +config MACH_OMAP_ZOOM3 + bool OMAP3630 Zoom3 board + depends on ARCH_OMAP3 ARCH_OMAP34XX Shouldn't this be: depends on ARCH_OMAP3 ARCH_OMAP36XX ? + config MACH_CM_T35 bool CompuLab CM-T35 module depends on ARCH_OMAP3 ARCH_OMAP34XX diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 68f7419..fac13ba 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -74,6 +74,9 @@ obj-$(CONFIG_MACH_NOKIA_RX51) += board-rx51.o \ obj-$(CONFIG_MACH_OMAP_ZOOM2) += board-zoom2-zoom3.o \ mmc-twl4030.o \ board-zoom-debugboard.o +obj-$(CONFIG_MACH_OMAP_ZOOM3) += board-zoom2-zoom3.o \ + mmc-twl4030.o \ + board-zoom-debugboard.o obj-$(CONFIG_MACH_CM_T35) += board-cm-t35.o \ mmc-twl4030.o diff --git a/arch/arm/mach-omap2/board-zoom2-zoom3.c b/arch/arm/mach-omap2/board-zoom2-zoom3.c index 4ad9b94..d806dbf 100644 --- a/arch/arm/mach-omap2/board-zoom2-zoom3.c +++ b/arch/arm/mach-omap2/board-zoom2-zoom3.c @@ -281,7 +281,11 @@ static void __init omap_zoom2_map_io(void) omap2_map_common_io(); } +#ifdef CONFIG_MACH_OMAP_ZOOM3 +MACHINE_START(OMAP_ZOOM3, OMAP ZOOM3 board) Case consistency? MACHINE_START(OMAP_ZOOM3, OMAP Zoom3 board) Regards, Sergio +#else MACHINE_START(OMAP_ZOOM2, OMAP Zoom2 board) +#endif .phys_io= 0x4800, .io_pg_offst= ((0xfa00) 18) 0xfffc, .boot_params= 0x8100, -- 1.6.5.rc1.19.g8426 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] omap: zoom3: add zoom3 board support
Aguirre Rodriguez, Sergio Alberto had written, on 10/23/2009 02:39 PM, the following: Vikram, Just some comments I came across below. From: linux-omap-ow...@vger.kernel.org [linux-omap-ow...@vger.kernel.org] On Behalf Of Pandita, Vikram Sent: Friday, October 23, 2009 2:23 PM Add machine type support for zoom3 board Add board type in Kconfig and Makefile Reused the zoom board file for zoom2 and zoom3 Signed-off-by: Vikram Pandita vikram.pand...@ti.com --- arch/arm/mach-omap2/Kconfig |4 arch/arm/mach-omap2/Makefile|3 +++ arch/arm/mach-omap2/board-zoom2-zoom3.c |4 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 8685df5..fa20996 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -97,6 +97,10 @@ config MACH_OMAP_ZOOM2 bool OMAP3 Zoom2 board How about also clarifying here ^^ the chip version: bool OMAP3430 Zoom2 board I mean, just to stick to the convention you're putting below. depends on ARCH_OMAP3 ARCH_OMAP34XX +config MACH_OMAP_ZOOM3 + bool OMAP3630 Zoom3 board + depends on ARCH_OMAP3 ARCH_OMAP34XX Shouldn't this be: depends on ARCH_OMAP3 ARCH_OMAP36XX is there an ARCH_OMAP36XX? i believe not ;).. Linux-OMAP build allows for both boards to be defined at the same time.. so in theory you could have a single uImage. the strategy followed here will fail it.. since the board file is the same one.. it could be made to work though.. ? + config MACH_CM_T35 bool CompuLab CM-T35 module depends on ARCH_OMAP3 ARCH_OMAP34XX diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 68f7419..fac13ba 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -74,6 +74,9 @@ obj-$(CONFIG_MACH_NOKIA_RX51) += board-rx51.o \ obj-$(CONFIG_MACH_OMAP_ZOOM2) += board-zoom2-zoom3.o \ mmc-twl4030.o \ board-zoom-debugboard.o +obj-$(CONFIG_MACH_OMAP_ZOOM3) += board-zoom2-zoom3.o \ + mmc-twl4030.o \ + board-zoom-debugboard.o obj-$(CONFIG_MACH_CM_T35) += board-cm-t35.o \ mmc-twl4030.o diff --git a/arch/arm/mach-omap2/board-zoom2-zoom3.c b/arch/arm/mach-omap2/board-zoom2-zoom3.c index 4ad9b94..d806dbf 100644 --- a/arch/arm/mach-omap2/board-zoom2-zoom3.c +++ b/arch/arm/mach-omap2/board-zoom2-zoom3.c @@ -281,7 +281,11 @@ static void __init omap_zoom2_map_io(void) omap2_map_common_io(); } +#ifdef CONFIG_MACH_OMAP_ZOOM3 +MACHINE_START(OMAP_ZOOM3, OMAP ZOOM3 board) Case consistency? MACHINE_START(OMAP_ZOOM3, OMAP Zoom3 board) Regards, Sergio +#else MACHINE_START(OMAP_ZOOM2, OMAP Zoom2 board) +#endif .phys_io= 0x4800, .io_pg_offst= ((0xfa00) 18) 0xfffc, .boot_params= 0x8100, -- 1.6.5.rc1.19.g8426 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/3] omap: zoom3: add zoom3 board support
From: Menon, Nishanth Sent: Friday, October 23, 2009 2:46 PM Aguirre Rodriguez, Sergio Alberto had written, on 10/23/2009 02:39 PM, the following: Vikram, Just some comments I came across below. From: linux-omap-ow...@vger.kernel.org [linux-omap-ow...@vger.kernel.org] On Behalf Of Pandita, Vikram Sent: Friday, October 23, 2009 2:23 PM Add machine type support for zoom3 board Add board type in Kconfig and Makefile Reused the zoom board file for zoom2 and zoom3 Signed-off-by: Vikram Pandita vikram.pand...@ti.com --- arch/arm/mach-omap2/Kconfig |4 arch/arm/mach-omap2/Makefile|3 +++ arch/arm/mach-omap2/board-zoom2-zoom3.c |4 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 8685df5..fa20996 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -97,6 +97,10 @@ config MACH_OMAP_ZOOM2 bool OMAP3 Zoom2 board How about also clarifying here ^^ the chip version: bool OMAP3430 Zoom2 board I mean, just to stick to the convention you're putting below. depends on ARCH_OMAP3 ARCH_OMAP34XX +config MACH_OMAP_ZOOM3 + bool OMAP3630 Zoom3 board + depends on ARCH_OMAP3 ARCH_OMAP34XX Shouldn't this be: depends on ARCH_OMAP3 ARCH_OMAP36XX is there an ARCH_OMAP36XX? i believe not ;).. Hmm... (Had this discussion before, not going there...) Linux-OMAP build allows for both boards to be defined at the same time.. so in theory you could have a single uImage. the strategy followed here will fail it.. since the board file is the same one.. it could be made to work though.. Not with this approach :) How about making board-zoom3.c separate from board-zoom2.c, and do a smarter way to share as much as possible? To modularize, I'll suggest taking a look at RX51 board files. That way you can have board-zoom2.c, board-zoom3.c, with the modules shared accordingly in Makefile. Camera is already doing that ;) What do you think? Regards, Sergio -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] omap: zoom3: add zoom3 board support
Aguirre Rodriguez, Sergio Alberto had written, on 10/23/2009 03:07 PM, the following: [...] Linux-OMAP build allows for both boards to be defined at the same time.. so in theory you could have a single uImage. the strategy followed here will fail it.. since the board file is the same one.. it could be made to work though.. Not with this approach :) How about making board-zoom3.c separate from board-zoom2.c, and do a smarter way to share as much as possible? To modularize, I'll suggest taking a look at RX51 board files. That way you can have board-zoom2.c, board-zoom3.c, with the modules shared accordingly in Makefile. Camera is already doing that ;) What do you think? Ack. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] omap: zoom3: add zoom3 board support
Hi, On Fri, Oct 23, 2009 at 02:23:26PM -0500, Vikram Pandita wrote: diff --git a/arch/arm/mach-omap2/board-zoom2-zoom3.c b/arch/arm/mach-omap2/board-zoom2-zoom3.c index 4ad9b94..d806dbf 100644 --- a/arch/arm/mach-omap2/board-zoom2-zoom3.c +++ b/arch/arm/mach-omap2/board-zoom2-zoom3.c @@ -281,7 +281,11 @@ static void __init omap_zoom2_map_io(void) omap2_map_common_io(); } +#ifdef CONFIG_MACH_OMAP_ZOOM3 +MACHINE_START(OMAP_ZOOM3, OMAP ZOOM3 board) +#else MACHINE_START(OMAP_ZOOM2, OMAP Zoom2 board) +#endif what happens if you want to build a kernel for both boards ? how about just adding a new MACHINE_START() declaration without ifdeferry ? Take a look at arch/arm/mach-omap2/board-n8x0.c for an example ;-) -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] omap: zoom3: add zoom3 board support
On Fri, Oct 23, 2009 at 04:17:08PM -0500, Nishanth Menon wrote: Aguirre Rodriguez, Sergio Alberto had written, on 10/23/2009 03:07 PM, the following: [...] Linux-OMAP build allows for both boards to be defined at the same time.. so in theory you could have a single uImage. the strategy followed here will fail it.. since the board file is the same one.. it could be made to work though.. Not with this approach :) How about making board-zoom3.c separate from board-zoom2.c, and do a smarter way to share as much as possible? To modularize, I'll suggest taking a look at RX51 board files. That way you can have board-zoom2.c, board-zoom3.c, with the modules shared accordingly in Makefile. Camera is already doing that ;) What do you think? Ack. I guess this would only add a file with a MACHINE_START() for zoom3, right ? I'd rather go, for this case, board-n8x0.c-ish. -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
