RE: [PATCH 4/13] dmtimer: hwmod: OMAP: api to read omap_hwmod _clk
-Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Tuesday, August 24, 2010 4:45 PM To: DebBarma, Tarun Kanti Cc: linux-omap@vger.kernel.org; Basak, Partha; Shilimkar, Santosh; Gopinath, Thara; Paul Walmsley; Kevin Hilman; Tony Lindgren Subject: Re: [PATCH 4/13] dmtimer: hwmod: OMAP: api to read omap_hwmod _clk On Sat, Aug 14, 2010 at 6:38 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This patch adds the omap_hwmod_get_clk() to access the _clk field needed while setting clock sources of the timers. Signed-off-by: Partha Basak p-bas...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Thara Gopinath th...@ti.com Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/omap_hwmod.c | 21 + arch/arm/plat-omap/include/plat/omap_hwmod.h | 1 + 2 files changed, 22 insertions(+), 0 deletions(-) mode change 100644 = 100755 arch/arm/mach-omap2/omap_hwmod.c mode change 100644 = 100755 arch/arm/plat- omap/include/plat/omap_hwmod.h watch out for the mode changes.. Sure, I have taken serious note of this. Thanks. -tarun -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/13] dmtimer: hwmod: OMAP: api to read omap_hwmod _clk
Tarun Kanti DebBarma tarun.ka...@ti.com writes:
This patch adds the omap_hwmod_get_clk() to access the _clk
field needed while setting clock sources of the timers.
Signed-off-by: Partha Basak p-bas...@ti.com
Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Thara Gopinath th...@ti.com
Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
Cc: Paul Walmsley p...@pwsan.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Tony Lindgren t...@atomide.com
To help understand the motivation for the change, please explain in the
changelog the intended usage of the API, e.g. what drivers/devices will
use this API and why.
Also, this patch (with a more descriptive changelog) should be separate
from this series as it affects the omap_hwmod core.
I see it's usage later in this series, but this change (if accepted)
would upstream separately from the dmtimer series.
Kevin
---
arch/arm/mach-omap2/omap_hwmod.c | 21 +
arch/arm/plat-omap/include/plat/omap_hwmod.h |1 +
2 files changed, 22 insertions(+), 0 deletions(-)
mode change 100644 = 100755 arch/arm/mach-omap2/omap_hwmod.c
mode change 100644 = 100755 arch/arm/plat-omap/include/plat/omap_hwmod.h
diff --git a/arch/arm/mach-omap2/omap_hwmod.c
b/arch/arm/mach-omap2/omap_hwmod.c
index 7f3c023..7188f0c
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -1759,6 +1759,27 @@ void __iomem *omap_hwmod_get_mpu_rt_va(struct
omap_hwmod *oh)
}
/**
+ * omap_hwmod_get_clk - returns pointer to this module's struct clk
+ * @oh: struct omap_hwmod *
+ *
+ * Return the struct clk pointer associated with the OMAP module
+ * Returns NULL on error, or a struct clk * on success.
+ */
+struct clk *omap_hwmod_get_clk(struct omap_hwmod *oh)
+{
+ if (!oh)
+ return NULL;
+
+ if (oh-_int_flags _HWMOD_NO_MPU_PORT)
+ return NULL;
+
+ if (oh-_state == _HWMOD_STATE_UNKNOWN)
+ return NULL;
+
+ return oh-_clk;
+}
+
+/**
* omap_hwmod_add_initiator_dep - add sleepdep from @init_oh to @oh
* @oh: struct omap_hwmod *
* @init_oh: struct omap_hwmod * (initiator)
diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h
b/arch/arm/plat-omap/include/plat/omap_hwmod.h
index 6adbb63..a2b85a5
--- a/arch/arm/plat-omap/include/plat/omap_hwmod.h
+++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h
@@ -538,6 +538,7 @@ int omap_hwmod_fill_resources(struct omap_hwmod *oh,
struct resource *res);
struct powerdomain *omap_hwmod_get_pwrdm(struct omap_hwmod *oh);
void __iomem *omap_hwmod_get_mpu_rt_va(struct omap_hwmod *oh);
+struct clk *omap_hwmod_get_clk(struct omap_hwmod *oh);
int omap_hwmod_add_initiator_dep(struct omap_hwmod *oh,
struct omap_hwmod *init_oh);
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/13] dmtimer: hwmod: OMAP: api to read omap_hwmod _clk
This patch adds the omap_hwmod_get_clk() to access the _clk
field needed while setting clock sources of the timers.
Signed-off-by: Partha Basak p-bas...@ti.com
Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Thara Gopinath th...@ti.com
Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
Cc: Paul Walmsley p...@pwsan.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Tony Lindgren t...@atomide.com
---
arch/arm/mach-omap2/omap_hwmod.c | 21 +
arch/arm/plat-omap/include/plat/omap_hwmod.h |1 +
2 files changed, 22 insertions(+), 0 deletions(-)
mode change 100644 = 100755 arch/arm/mach-omap2/omap_hwmod.c
mode change 100644 = 100755 arch/arm/plat-omap/include/plat/omap_hwmod.h
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 7f3c023..7188f0c
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -1759,6 +1759,27 @@ void __iomem *omap_hwmod_get_mpu_rt_va(struct omap_hwmod
*oh)
}
/**
+ * omap_hwmod_get_clk - returns pointer to this module's struct clk
+ * @oh: struct omap_hwmod *
+ *
+ * Return the struct clk pointer associated with the OMAP module
+ * Returns NULL on error, or a struct clk * on success.
+ */
+struct clk *omap_hwmod_get_clk(struct omap_hwmod *oh)
+{
+ if (!oh)
+ return NULL;
+
+ if (oh-_int_flags _HWMOD_NO_MPU_PORT)
+ return NULL;
+
+ if (oh-_state == _HWMOD_STATE_UNKNOWN)
+ return NULL;
+
+ return oh-_clk;
+}
+
+/**
* omap_hwmod_add_initiator_dep - add sleepdep from @init_oh to @oh
* @oh: struct omap_hwmod *
* @init_oh: struct omap_hwmod * (initiator)
diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h
b/arch/arm/plat-omap/include/plat/omap_hwmod.h
index 6adbb63..a2b85a5
--- a/arch/arm/plat-omap/include/plat/omap_hwmod.h
+++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h
@@ -538,6 +538,7 @@ int omap_hwmod_fill_resources(struct omap_hwmod *oh, struct
resource *res);
struct powerdomain *omap_hwmod_get_pwrdm(struct omap_hwmod *oh);
void __iomem *omap_hwmod_get_mpu_rt_va(struct omap_hwmod *oh);
+struct clk *omap_hwmod_get_clk(struct omap_hwmod *oh);
int omap_hwmod_add_initiator_dep(struct omap_hwmod *oh,
struct omap_hwmod *init_oh);
--
1.6.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
