Re: [PATCH 4/5] OMAP: Add support for setting the divider for sys_clkout2 using clk_set_rate

[Paul Walmsley]

On Thu, 22 Apr 2010, Paul Walmsley wrote:

> Hello Laine,
> 
> two minor comments:
> 
> On Tue, 6 Apr 2010, Laine Walker-Avina wrote:
> 
> > 
> > Signed-off-by: Laine Walker-Avina 
> 
> Please add a brief changelog.  Nothing fancy needed...
> 
> > ---
> >  arch/arm/mach-omap2/clock3xxx_data.c |1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
> > b/arch/arm/mach-omap2/clock3xxx_data.c
> > index d5153b6..2a62779 100644
> > --- a/arch/arm/mach-omap2/clock3xxx_data.c
> > +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> > @@ -,6 +,7 @@ static struct clk sys_clkout2 = {
> > .clksel_mask= OMAP3430_CLKOUT2_DIV_MASK,
> > .clksel = sys_clkout2_clksel,
> > .recalc = &omap2_clksel_recalc,
> 
> Please add a .round_rate function pointer here also, pointing to 
> omap2_clksel_round_rate.
> 
> > +   .set_rate   = &omap2_clksel_set_rate,
> >  };
> >  
> >  /* CM OUTPUT CLOCKS */

Haven't heard anything further on this.  The changes needed are 
straightforward enough that I'll make them here and queue it for 2.6.35.


- Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] OMAP: Add support for setting the divider for sys_clkout2 using clk_set_rate

[Paul Walmsley]

Hello Laine,

two minor comments:

On Tue, 6 Apr 2010, Laine Walker-Avina wrote:

> 
> Signed-off-by: Laine Walker-Avina 

Please add a brief changelog.  Nothing fancy needed...

> ---
>  arch/arm/mach-omap2/clock3xxx_data.c |1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
> b/arch/arm/mach-omap2/clock3xxx_data.c
> index d5153b6..2a62779 100644
> --- a/arch/arm/mach-omap2/clock3xxx_data.c
> +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> @@ -,6 +,7 @@ static struct clk sys_clkout2 = {
>   .clksel_mask= OMAP3430_CLKOUT2_DIV_MASK,
>   .clksel = sys_clkout2_clksel,
>   .recalc = &omap2_clksel_recalc,

Please add a .round_rate function pointer here also, pointing to 
omap2_clksel_round_rate.

> + .set_rate   = &omap2_clksel_set_rate,
>  };
>  
>  /* CM OUTPUT CLOCKS */
> -- 
> 1.6.3.3


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/5] OMAP: Add support for setting the divider for sys_clkout2 using clk_set_rate

[Laine Walker-Avina]

Signed-off-by: Laine Walker-Avina 
---
 arch/arm/mach-omap2/clock3xxx_data.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
b/arch/arm/mach-omap2/clock3xxx_data.c
index d5153b6..2a62779 100644
--- a/arch/arm/mach-omap2/clock3xxx_data.c
+++ b/arch/arm/mach-omap2/clock3xxx_data.c
@@ -,6 +,7 @@ static struct clk sys_clkout2 = {
.clksel_mask= OMAP3430_CLKOUT2_DIV_MASK,
.clksel = sys_clkout2_clksel,
.recalc = &omap2_clksel_recalc,
+   .set_rate   = &omap2_clksel_set_rate,
 };
 
 /* CM OUTPUT CLOCKS */
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html