RE: [PATCH 4/6] omap4: dpll: Enable all DPLL autoidle at boot
Hi Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Tuesday, February 01, 2011 4:47 AM > To: rna...@ti.com; Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; khil...@ti.com; b-cous...@ti.com; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH 4/6] omap4: dpll: Enable all DPLL autoidle at boot > > Hi guys > > On Fri, 28 Jan 2011, Santosh Shilimkar wrote: > > > From: Rajendra Nayak > > > > Enable all DPLL autoidle at boot on OMAP4. > > Is there some reason why we can't do this in the OMAP4 PM code? At some > point, I think it would be good to essentially disable all PM at boot, and > then let the PM code specifically enable autoidle later in the boot > process, etc. The idea being that !CONFIG_PM would result in a chip > programmed for lowest latency, etc. I guess it makes sense to do this late in boot and only if CONFIG_PM is enabled. Will make the necessary changes and repost. Regards, Rajendra > > > Signed-off-by: Rajendra Nayak > > --- > > arch/arm/mach-omap2/clock44xx_data.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c > > index e8cb32f..e5c59a0 100644 > > --- a/arch/arm/mach-omap2/clock44xx_data.c > > +++ b/arch/arm/mach-omap2/clock44xx_data.c > > @@ -3300,6 +3300,8 @@ int __init omap4xxx_clk_init(void) > > clkdev_add(&c->lk); > > clk_register(c->lk.clk); > > omap2_init_clk_clkdm(c->lk.clk); > > + if (c->lk.clk->dpll_data) > > + omap3_dpll_allow_idle(c->lk.clk); > > } > > > > recalculate_root_clocks(); > > -- > > 1.6.0.4 > > > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/6] omap4: dpll: Enable all DPLL autoidle at boot
Hi guys On Fri, 28 Jan 2011, Santosh Shilimkar wrote: > From: Rajendra Nayak > > Enable all DPLL autoidle at boot on OMAP4. Is there some reason why we can't do this in the OMAP4 PM code? At some point, I think it would be good to essentially disable all PM at boot, and then let the PM code specifically enable autoidle later in the boot process, etc. The idea being that !CONFIG_PM would result in a chip programmed for lowest latency, etc. > Signed-off-by: Rajendra Nayak > --- > arch/arm/mach-omap2/clock44xx_data.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock44xx_data.c > b/arch/arm/mach-omap2/clock44xx_data.c > index e8cb32f..e5c59a0 100644 > --- a/arch/arm/mach-omap2/clock44xx_data.c > +++ b/arch/arm/mach-omap2/clock44xx_data.c > @@ -3300,6 +3300,8 @@ int __init omap4xxx_clk_init(void) > clkdev_add(&c->lk); > clk_register(c->lk.clk); > omap2_init_clk_clkdm(c->lk.clk); > + if (c->lk.clk->dpll_data) > + omap3_dpll_allow_idle(c->lk.clk); > } > > recalculate_root_clocks(); > -- > 1.6.0.4 > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/6] omap4: dpll: Enable all DPLL autoidle at boot
From: Rajendra Nayak Enable all DPLL autoidle at boot on OMAP4. Signed-off-by: Rajendra Nayak --- arch/arm/mach-omap2/clock44xx_data.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index e8cb32f..e5c59a0 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -3300,6 +3300,8 @@ int __init omap4xxx_clk_init(void) clkdev_add(&c->lk); clk_register(c->lk.clk); omap2_init_clk_clkdm(c->lk.clk); + if (c->lk.clk->dpll_data) + omap3_dpll_allow_idle(c->lk.clk); } recalculate_root_clocks(); -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html