RE: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Wednesday, June 30, 2010 12:55 PM > To: Shilimkar, Santosh > Cc: linux-arm-ker...@lists.infradead.org; linux-omap@vger.kernel.org > Subject: Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in > typical omap features > > * Shilimkar, Santosh [100630 09:41]: > > > -Original Message- > > > From: Tony Lindgren [mailto:t...@atomide.com] > > > Sent: Wednesday, June 30, 2010 11:47 AM > > > To: Shilimkar, Santosh > > > Cc: linux-arm-ker...@lists.infradead.org; linux-omap@vger.kernel.org > > > Subject: Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in > > > typical omap features > > > > > > * Shilimkar, Santosh [100629 17:40]: > > > > > > > > > > > With your series OMAP4 build breaks because of PM and SMP > > > dependencies. > > > > > To ensure that build doesn't break on OMAP4, I needed below > change. > > > With > > > > > This change I tried your series and it boots OK on OMAP4430 SDP > > > > > > Hmm the build does not break for me? > > > > > Looks like I am missing something here. How do you build OMAP4 alone > with > > these new changes ?? > > Use your old config file, or just unselect CONFIG_ARCH_OMAP2 > and CONFIG_ARCH_OMAP3. Note that if you now do: > > $ yes "" | ARCH=arm make oldconfig > > with your old omap4 only config file, then by default the > typical features get added by default. So what you probably > want to do is (untested): > > $ echo "# CONFIG_ARCH_OMAP2PLUS_TYPICAL is not set" >> .config > $ yes "" | ARCH=arm make oldconfig > > Then it should not change your old config file. > The above method works Tony. The series boot tested with 4430 SDP Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
* Shilimkar, Santosh [100630 09:41]: > > -Original Message- > > From: Tony Lindgren [mailto:t...@atomide.com] > > Sent: Wednesday, June 30, 2010 11:47 AM > > To: Shilimkar, Santosh > > Cc: linux-arm-ker...@lists.infradead.org; linux-omap@vger.kernel.org > > Subject: Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in > > typical omap features > > > > * Shilimkar, Santosh [100629 17:40]: > > > > > > > > > With your series OMAP4 build breaks because of PM and SMP > > dependencies. > > > > To ensure that build doesn't break on OMAP4, I needed below change. > > With > > > > This change I tried your series and it boots OK on OMAP4430 SDP > > > > Hmm the build does not break for me? > > > Looks like I am missing something here. How do you build OMAP4 alone with > these new changes ?? Use your old config file, or just unselect CONFIG_ARCH_OMAP2 and CONFIG_ARCH_OMAP3. Note that if you now do: $ yes "" | ARCH=arm make oldconfig with your old omap4 only config file, then by default the typical features get added by default. So what you probably want to do is (untested): $ echo "# CONFIG_ARCH_OMAP2PLUS_TYPICAL is not set" >> .config $ yes "" | ARCH=arm make oldconfig Then it should not change your old config file. To see how the boards and features show up, you can also play with it with make xconfig: System Type -> TI OMAP2/3/4 Specific Features Uncheck TI OMAP2 and TI OMAP3 so only TI OMAP4 is selected. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Wednesday, June 30, 2010 11:47 AM > To: Shilimkar, Santosh > Cc: linux-arm-ker...@lists.infradead.org; linux-omap@vger.kernel.org > Subject: Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in > typical omap features > > * Shilimkar, Santosh [100629 17:40]: > > > > > > > With your series OMAP4 build breaks because of PM and SMP > dependencies. > > > To ensure that build doesn't break on OMAP4, I needed below change. > With > > > This change I tried your series and it boots OK on OMAP4430 SDP > > Hmm the build does not break for me? > Looks like I am missing something here. How do you build OMAP4 alone with these new changes ?? > > Also tested the multi-omap build on OMAP3430 SDP and OMAP4430 SDP. Both > boots OK. > > > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > > index 84fecd0..f48f275 100644 > > > --- a/arch/arm/mach-omap2/Kconfig > > > +++ b/arch/arm/mach-omap2/Kconfig > > > @@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL > > > default y > > > select AEABI > > > select REGULATOR > > > - select PM > > > - select PM_RUNTIME > > > + select PM if !ARCH_OMAP4 > > > + select PM_RUNTIME if !ARCH_OMAP4 > > > select VFP > > > select NEON if ARCH_OMAP3 || ARCH_OMAP4 > > > select SERIAL_8250 > > Let's rather fix whatever the issue is for booting (or building?) > omap4 with CONFIG_PM and CONFIG_PM_RUNTIME. If we can't implement > PM yet for omap4, we can just return early if cpu_is_omap44xx. > > CONFIG_SMP we can't enable as that requires various ARM changes > to work on unicore systems. But hopefully we can enable that too > at some point with select SMP if ARCH_OMAP4. > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
* Shilimkar, Santosh [100629 17:40]: > > > > > With your series OMAP4 build breaks because of PM and SMP dependencies. > > To ensure that build doesn't break on OMAP4, I needed below change. With > > This change I tried your series and it boots OK on OMAP4430 SDP Hmm the build does not break for me? > Also tested the multi-omap build on OMAP3430 SDP and OMAP4430 SDP. Both boots > OK. > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index 84fecd0..f48f275 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL > > default y > > select AEABI > > select REGULATOR > > - select PM > > - select PM_RUNTIME > > + select PM if !ARCH_OMAP4 > > + select PM_RUNTIME if !ARCH_OMAP4 > > select VFP > > select NEON if ARCH_OMAP3 || ARCH_OMAP4 > > select SERIAL_8250 Let's rather fix whatever the issue is for booting (or building?) omap4 with CONFIG_PM and CONFIG_PM_RUNTIME. If we can't implement PM yet for omap4, we can just return early if cpu_is_omap44xx. CONFIG_SMP we can't enable as that requires various ARM changes to work on unicore systems. But hopefully we can enable that too at some point with select SMP if ARCH_OMAP4. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Shilimkar, Santosh > Sent: Tuesday, June 29, 2010 7:23 PM > To: Tony Lindgren; linux-arm-ker...@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Subject: RE: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in > typical omap features > > Tony, > > -Original Message- > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > > Sent: Tuesday, June 29, 2010 5:18 PM > > To: linux-arm-ker...@lists.infradead.org > > Cc: linux-omap@vger.kernel.org > > Subject: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical > > omap features > > > > This produces a sane config that's suitable for using as the > > base for most omap2/3/4 boards. > > > > Signed-off-by: Tony Lindgren > > --- > > arch/arm/mach-omap2/Kconfig | 21 + > > 1 files changed, 21 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index 4802988..84fecd0 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -2,6 +2,27 @@ if ARCH_OMAP2PLUS > > > > menu "TI OMAP2/3/4 Specific Features" > > > > +config ARCH_OMAP2PLUS_TYPICAL > > + bool "Typical OMAP configuration" > > + default y > > + select AEABI > > + select REGULATOR > > + select PM > > + select PM_RUNTIME > > + select VFP > > + select NEON if ARCH_OMAP3 || ARCH_OMAP4 > > + select SERIAL_8250 > > + select SERIAL_CORE_CONSOLE > > + select SERIAL_8250_CONSOLE > > + select I2C > > + select I2C_OMAP > > + select MFD > > + select MENELAUS if ARCH_OMAP2 > > + select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4 > > + select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4 > > + help > > + Compile a kernel suitable for booting most boards > > + > > config ARCH_OMAP2 > > bool "TI OMAP2" > > depends on ARCH_OMAP2PLUS > > > With your series OMAP4 build breaks because of PM and SMP dependencies. > To ensure that build doesn't break on OMAP4, I needed below change. With > This change I tried your series and it boots OK on OMAP4430 SDP > Also tested the multi-omap build on OMAP3430 SDP and OMAP4430 SDP. Both boots OK. > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 84fecd0..f48f275 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL > default y > select AEABI > select REGULATOR > - select PM > - select PM_RUNTIME > + select PM if !ARCH_OMAP4 > + select PM_RUNTIME if !ARCH_OMAP4 > select VFP > select NEON if ARCH_OMAP3 || ARCH_OMAP4 > select SERIAL_8250 > > Regards > Santosh > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
Tony, > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Tuesday, June 29, 2010 5:18 PM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Subject: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical > omap features > > This produces a sane config that's suitable for using as the > base for most omap2/3/4 boards. > > Signed-off-by: Tony Lindgren > --- > arch/arm/mach-omap2/Kconfig | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 4802988..84fecd0 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -2,6 +2,27 @@ if ARCH_OMAP2PLUS > > menu "TI OMAP2/3/4 Specific Features" > > +config ARCH_OMAP2PLUS_TYPICAL > + bool "Typical OMAP configuration" > + default y > + select AEABI > + select REGULATOR > + select PM > + select PM_RUNTIME > + select VFP > + select NEON if ARCH_OMAP3 || ARCH_OMAP4 > + select SERIAL_8250 > + select SERIAL_CORE_CONSOLE > + select SERIAL_8250_CONSOLE > + select I2C > + select I2C_OMAP > + select MFD > + select MENELAUS if ARCH_OMAP2 > + select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4 > + select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4 > + help > + Compile a kernel suitable for booting most boards > + > config ARCH_OMAP2 > bool "TI OMAP2" > depends on ARCH_OMAP2PLUS > With your series OMAP4 build breaks because of PM and SMP dependencies. To ensure that build doesn't break on OMAP4, I needed below change. With This change I tried your series and it boots OK on OMAP4430 SDP diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 84fecd0..f48f275 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL default y select AEABI select REGULATOR - select PM - select PM_RUNTIME + select PM if !ARCH_OMAP4 + select PM_RUNTIME if !ARCH_OMAP4 select VFP select NEON if ARCH_OMAP3 || ARCH_OMAP4 select SERIAL_8250 Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
This produces a sane config that's suitable for using as the base for most omap2/3/4 boards. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/Kconfig | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 4802988..84fecd0 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -2,6 +2,27 @@ if ARCH_OMAP2PLUS menu "TI OMAP2/3/4 Specific Features" +config ARCH_OMAP2PLUS_TYPICAL + bool "Typical OMAP configuration" + default y + select AEABI + select REGULATOR + select PM + select PM_RUNTIME + select VFP + select NEON if ARCH_OMAP3 || ARCH_OMAP4 + select SERIAL_8250 + select SERIAL_CORE_CONSOLE + select SERIAL_8250_CONSOLE + select I2C + select I2C_OMAP + select MFD + select MENELAUS if ARCH_OMAP2 + select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4 + select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4 + help + Compile a kernel suitable for booting most boards + config ARCH_OMAP2 bool "TI OMAP2" depends on ARCH_OMAP2PLUS -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
