Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
* Tony Lindgren [091229 12:00]: > * Felipe Balbi [091229 11:54]: > > On Tue, 2009-12-29 at 21:53 +0200, Felipe Balbi wrote: > > > On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote: > > > > * Felipe Balbi [091228 03:10]: > > > > > each board might have a different charge pump and > > > > > thus able to source more or less current on vbus > > > > > so let power be easily configurable. > > > > > > > > In order to justify merging this as a fix, can you please update > > > > the subject and description to describe that this fixes the > > > > the power value ? > > > > > > for sure, doing it right now. > > > > How about now ? (did the same to the board mode) > > > > commit 860a17d3dc78cc8c640a83ade83dd0ec4f1217f1 > > Author: Felipe Balbi > > Date: Mon Dec 28 00:46:19 2009 +0200 > > > > arm: omap: musb: fix board mode by passing it to usb_musb_init > > > > each board will have a different mode which is peculiar > > to that board. > > > > Signed-off-by: Felipe Balbi > > > > commit 86b92c438109a95c20fad62804b4b8040f3676b7 > > Author: Felipe Balbi > > Date: Mon Dec 28 00:30:42 2009 +0200 > > > > arm: omap: musb: fix board power budget by passing it to > > usb_musb_init > > > > each board might have a different charge pump and > > thus able to source more or less current on vbus > > so let power be easily configurable. > > > > Signed-off-by: Felipe Balbi > > Sounds good to me. Oh one more thing: Can you please repost the series one more time with LAKML Cc'd? We should have all the arch/arm/*omap*/ patches reviewed there too. Maybe Cc linux-usb too? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
* Felipe Balbi [091229 11:54]: > On Tue, 2009-12-29 at 21:53 +0200, Felipe Balbi wrote: > > On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote: > > > * Felipe Balbi [091228 03:10]: > > > > each board might have a different charge pump and > > > > thus able to source more or less current on vbus > > > > so let power be easily configurable. > > > > > > In order to justify merging this as a fix, can you please update > > > the subject and description to describe that this fixes the > > > the power value ? > > > > for sure, doing it right now. > > How about now ? (did the same to the board mode) > > commit 860a17d3dc78cc8c640a83ade83dd0ec4f1217f1 > Author: Felipe Balbi > Date: Mon Dec 28 00:46:19 2009 +0200 > > arm: omap: musb: fix board mode by passing it to usb_musb_init > > each board will have a different mode which is peculiar > to that board. > > Signed-off-by: Felipe Balbi > > commit 86b92c438109a95c20fad62804b4b8040f3676b7 > Author: Felipe Balbi > Date: Mon Dec 28 00:30:42 2009 +0200 > > arm: omap: musb: fix board power budget by passing it to > usb_musb_init > > each board might have a different charge pump and > thus able to source more or less current on vbus > so let power be easily configurable. > > Signed-off-by: Felipe Balbi Sounds good to me. Thanks, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
On Tue, 2009-12-29 at 21:53 +0200, Felipe Balbi wrote: > On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote: > > * Felipe Balbi [091228 03:10]: > > > each board might have a different charge pump and > > > thus able to source more or less current on vbus > > > so let power be easily configurable. > > > > In order to justify merging this as a fix, can you please update > > the subject and description to describe that this fixes the > > the power value ? > > for sure, doing it right now. How about now ? (did the same to the board mode) commit 860a17d3dc78cc8c640a83ade83dd0ec4f1217f1 Author: Felipe Balbi Date: Mon Dec 28 00:46:19 2009 +0200 arm: omap: musb: fix board mode by passing it to usb_musb_init each board will have a different mode which is peculiar to that board. Signed-off-by: Felipe Balbi commit 86b92c438109a95c20fad62804b4b8040f3676b7 Author: Felipe Balbi Date: Mon Dec 28 00:30:42 2009 +0200 arm: omap: musb: fix board power budget by passing it to usb_musb_init each board might have a different charge pump and thus able to source more or less current on vbus so let power be easily configurable. Signed-off-by: Felipe Balbi -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote: > * Felipe Balbi [091228 03:10]: > > each board might have a different charge pump and > > thus able to source more or less current on vbus > > so let power be easily configurable. > > In order to justify merging this as a fix, can you please update > the subject and description to describe that this fixes the > the power value ? for sure, doing it right now. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
* Felipe Balbi [091228 03:10]: > each board might have a different charge pump and > thus able to source more or less current on vbus > so let power be easily configurable. In order to justify merging this as a fix, can you please update the subject and description to describe that this fixes the the power value? Regards, Tony > Signed-off-by: Felipe Balbi > --- > arch/arm/mach-omap2/board-2430sdp.c |2 +- > arch/arm/mach-omap2/board-3430sdp.c |2 +- > arch/arm/mach-omap2/board-cm-t35.c |2 +- > arch/arm/mach-omap2/board-igep0020.c |2 +- > arch/arm/mach-omap2/board-ldp.c |2 +- > arch/arm/mach-omap2/board-omap3beagle.c |2 +- > arch/arm/mach-omap2/board-omap3evm.c |2 +- > arch/arm/mach-omap2/board-omap3pandora.c |2 +- > arch/arm/mach-omap2/board-omap3touchbook.c |2 +- > arch/arm/mach-omap2/board-overo.c|2 +- > arch/arm/mach-omap2/board-rx51.c |2 +- > arch/arm/mach-omap2/board-zoom-peripherals.c |2 +- > arch/arm/mach-omap2/usb-musb.c | 12 > arch/arm/plat-omap/include/plat/usb.h|2 +- > 14 files changed, 17 insertions(+), 21 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-2430sdp.c > b/arch/arm/mach-omap2/board-2430sdp.c > index e508904..d3857d6 100644 > --- a/arch/arm/mach-omap2/board-2430sdp.c > +++ b/arch/arm/mach-omap2/board-2430sdp.c > @@ -203,7 +203,7 @@ static void __init omap_2430sdp_init(void) > platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices)); > omap_serial_init(); > twl4030_mmc_init(mmc); > - usb_musb_init(); > + usb_musb_init(100); > board_smc91x_init(); > > /* Turn off secondary LCD backlight */ > diff --git a/arch/arm/mach-omap2/board-3430sdp.c > b/arch/arm/mach-omap2/board-3430sdp.c > index c90b0d0..1d52fd1 100644 > --- a/arch/arm/mach-omap2/board-3430sdp.c > +++ b/arch/arm/mach-omap2/board-3430sdp.c > @@ -664,7 +664,7 @@ static void __init omap_3430sdp_init(void) > ARRAY_SIZE(sdp3430_spi_board_info)); > ads7846_dev_init(); > omap_serial_init(); > - usb_musb_init(); > + usb_musb_init(100); > board_smc91x_init(); > sdp3430_display_init(); > enable_board_wakeup_source(); > diff --git a/arch/arm/mach-omap2/board-cm-t35.c > b/arch/arm/mach-omap2/board-cm-t35.c > index 2626a9f..56922f4 100644 > --- a/arch/arm/mach-omap2/board-cm-t35.c > +++ b/arch/arm/mach-omap2/board-cm-t35.c > @@ -585,7 +585,7 @@ static void __init cm_t35_init(void) > cm_t35_init_ethernet(); > cm_t35_init_led(); > > - usb_musb_init(); > + usb_musb_init(100); > } > > MACHINE_START(CM_T35, "Compulab CM-T35") > diff --git a/arch/arm/mach-omap2/board-igep0020.c > b/arch/arm/mach-omap2/board-igep0020.c > index 117b8fd..16be1d5 100644 > --- a/arch/arm/mach-omap2/board-igep0020.c > +++ b/arch/arm/mach-omap2/board-igep0020.c > @@ -216,7 +216,7 @@ static void __init igep2_init(void) > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > igep2_i2c_init(); > omap_serial_init(); > - usb_musb_init(); > + usb_musb_init(100); > > igep2_init_smsc911x(); > > diff --git a/arch/arm/mach-omap2/board-ldp.c b/arch/arm/mach-omap2/board-ldp.c > index 995d4a2..ca2acd2 100644 > --- a/arch/arm/mach-omap2/board-ldp.c > +++ b/arch/arm/mach-omap2/board-ldp.c > @@ -394,7 +394,7 @@ static void __init omap_ldp_init(void) > ARRAY_SIZE(ldp_spi_board_info)); > ads7846_dev_init(); > omap_serial_init(); > - usb_musb_init(); > + usb_musb_init(100); > > twl4030_mmc_init(mmc); > /* link regulators to MMC adapters */ > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c > b/arch/arm/mach-omap2/board-omap3beagle.c > index 231cb4e..52f65e6 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -443,7 +443,7 @@ static void __init omap3_beagle_init(void) > /* REVISIT leave DVI powered down until it's needed ... */ > gpio_direction_output(170, true); > > - usb_musb_init(); > + usb_musb_init(100); > usb_ehci_init(&ehci_pdata); > omap3beagle_flash_init(); > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c > b/arch/arm/mach-omap2/board-omap3evm.c > index 34de178..c5fd85d 100644 > --- a/arch/arm/mach-omap2/board-omap3evm.c > +++ b/arch/arm/mach-omap2/board-omap3evm.c > @@ -469,7 +469,7 @@ static void __init omap3_evm_init(void) > omap_mux_init_gpio(135, OMAP_PIN_OUTPUT); > ehci_pdata.reset_gpio_port[1] = 135; > } > - usb_musb_init(); > + usb_musb_init(100); > usb_ehci_init(&ehci_pdata); > ads7846_dev_init(); > omap3evm_init_smsc911x(); > diff --git a/arch/arm/mach-omap2/board-omap3pandora.c > b/arch/arm/mach-omap2/board-omap3pandora.c > index ef17cf1..b0cdf77 100644 > --- a/arch/
[PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
each board might have a different charge pump and thus able to source more or less current on vbus so let power be easily configurable. Signed-off-by: Felipe Balbi --- arch/arm/mach-omap2/board-2430sdp.c |2 +- arch/arm/mach-omap2/board-3430sdp.c |2 +- arch/arm/mach-omap2/board-cm-t35.c |2 +- arch/arm/mach-omap2/board-igep0020.c |2 +- arch/arm/mach-omap2/board-ldp.c |2 +- arch/arm/mach-omap2/board-omap3beagle.c |2 +- arch/arm/mach-omap2/board-omap3evm.c |2 +- arch/arm/mach-omap2/board-omap3pandora.c |2 +- arch/arm/mach-omap2/board-omap3touchbook.c |2 +- arch/arm/mach-omap2/board-overo.c|2 +- arch/arm/mach-omap2/board-rx51.c |2 +- arch/arm/mach-omap2/board-zoom-peripherals.c |2 +- arch/arm/mach-omap2/usb-musb.c | 12 arch/arm/plat-omap/include/plat/usb.h|2 +- 14 files changed, 17 insertions(+), 21 deletions(-) diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c index e508904..d3857d6 100644 --- a/arch/arm/mach-omap2/board-2430sdp.c +++ b/arch/arm/mach-omap2/board-2430sdp.c @@ -203,7 +203,7 @@ static void __init omap_2430sdp_init(void) platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices)); omap_serial_init(); twl4030_mmc_init(mmc); - usb_musb_init(); + usb_musb_init(100); board_smc91x_init(); /* Turn off secondary LCD backlight */ diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c index c90b0d0..1d52fd1 100644 --- a/arch/arm/mach-omap2/board-3430sdp.c +++ b/arch/arm/mach-omap2/board-3430sdp.c @@ -664,7 +664,7 @@ static void __init omap_3430sdp_init(void) ARRAY_SIZE(sdp3430_spi_board_info)); ads7846_dev_init(); omap_serial_init(); - usb_musb_init(); + usb_musb_init(100); board_smc91x_init(); sdp3430_display_init(); enable_board_wakeup_source(); diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 2626a9f..56922f4 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -585,7 +585,7 @@ static void __init cm_t35_init(void) cm_t35_init_ethernet(); cm_t35_init_led(); - usb_musb_init(); + usb_musb_init(100); } MACHINE_START(CM_T35, "Compulab CM-T35") diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c index 117b8fd..16be1d5 100644 --- a/arch/arm/mach-omap2/board-igep0020.c +++ b/arch/arm/mach-omap2/board-igep0020.c @@ -216,7 +216,7 @@ static void __init igep2_init(void) omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); igep2_i2c_init(); omap_serial_init(); - usb_musb_init(); + usb_musb_init(100); igep2_init_smsc911x(); diff --git a/arch/arm/mach-omap2/board-ldp.c b/arch/arm/mach-omap2/board-ldp.c index 995d4a2..ca2acd2 100644 --- a/arch/arm/mach-omap2/board-ldp.c +++ b/arch/arm/mach-omap2/board-ldp.c @@ -394,7 +394,7 @@ static void __init omap_ldp_init(void) ARRAY_SIZE(ldp_spi_board_info)); ads7846_dev_init(); omap_serial_init(); - usb_musb_init(); + usb_musb_init(100); twl4030_mmc_init(mmc); /* link regulators to MMC adapters */ diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index 231cb4e..52f65e6 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -443,7 +443,7 @@ static void __init omap3_beagle_init(void) /* REVISIT leave DVI powered down until it's needed ... */ gpio_direction_output(170, true); - usb_musb_init(); + usb_musb_init(100); usb_ehci_init(&ehci_pdata); omap3beagle_flash_init(); diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c index 34de178..c5fd85d 100644 --- a/arch/arm/mach-omap2/board-omap3evm.c +++ b/arch/arm/mach-omap2/board-omap3evm.c @@ -469,7 +469,7 @@ static void __init omap3_evm_init(void) omap_mux_init_gpio(135, OMAP_PIN_OUTPUT); ehci_pdata.reset_gpio_port[1] = 135; } - usb_musb_init(); + usb_musb_init(100); usb_ehci_init(&ehci_pdata); ads7846_dev_init(); omap3evm_init_smsc911x(); diff --git a/arch/arm/mach-omap2/board-omap3pandora.c b/arch/arm/mach-omap2/board-omap3pandora.c index ef17cf1..b0cdf77 100644 --- a/arch/arm/mach-omap2/board-omap3pandora.c +++ b/arch/arm/mach-omap2/board-omap3pandora.c @@ -413,7 +413,7 @@ static void __init omap3pandora_init(void) omap3pandora_ads7846_init(); usb_ehci_init(&ehci_pdata); pandora_keys_gpio_init(); - usb_musb_init(); + usb_musb_init(100); /* Ensure SDRC pins are mux'
