Re: [PATCH 6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code

2013-02-21 Thread Sergei Shtylyov

Hello.

On 20-02-2013 19:18, Santosh Shilimkar wrote:


The smp_wmb() here is out of placed


   s/placed/place/


and redundant. So remove it. It is
a left over of the pain_release


  Sure it's not 'pen_release'?


cleanup mostly.



Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com


WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code

2013-02-21 Thread Santosh Shilimkar

On Thursday 21 February 2013 06:25 PM, Sergei Shtylyov wrote:

Hello.

On 20-02-2013 19:18, Santosh Shilimkar wrote:


The smp_wmb() here is out of placed


s/placed/place/


and redundant. So remove it. It is
a left over of the pain_release


   Sure it's not 'pen_release'?


cleanup mostly.



Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com



Yes... Will fix.

Regards,
Santosh

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code

2013-02-20 Thread Santosh Shilimkar
The smp_wmb() here is out of placed and redundant. So remove it. It is
a left over of the pain_release cleanup mostly.

Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
---
 arch/arm/mach-omap2/omap-smp.c |2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-omap2/omap-smp.c
index 81fd489..7d29a74 100644
--- a/arch/arm/mach-omap2/omap-smp.c
+++ b/arch/arm/mach-omap2/omap-smp.c
@@ -186,8 +186,6 @@ static void __init wakeup_secondary(void)
__raw_writel(virt_to_phys(omap5_secondary_startup),
base + OMAP_AUX_CORE_BOOT_1);
 
-   smp_wmb();
-
/*
 * Send a 'sev' to wake the secondary core from WFE.
 * Drain the outstanding writes to memory
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html