Re: [PATCH 8/8] memory: emif: Load the correct custom config values from dt

2013-03-10 Thread Santosh Shilimkar
On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> of_get_property returns value in Big Endian format.
> Before using this value it should be converted to little endian
> using be32_to_cpup().
> Custom configs of emif are read from dt using of_get_property,
> but these are not converted to litte endian format.
> Correcting the same here.
> 
> Signed-off-by: Lokesh Vutla 
> ---
Looks fine.
Acked-by: Santosh Shilimkar 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 8/8] memory: emif: Load the correct custom config values from dt

2013-03-10 Thread Lokesh Vutla
of_get_property returns value in Big Endian format.
Before using this value it should be converted to little endian
using be32_to_cpup().
Custom configs of emif are read from dt using of_get_property,
but these are not converted to litte endian format.
Correcting the same here.

Signed-off-by: Lokesh Vutla 
---
 drivers/memory/emif.c |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 119503a..4866f1b 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -1258,7 +1258,7 @@ static void __init_or_module of_get_custom_configs(struct 
device_node *np_emif,
 {
struct emif_custom_configs  *cust_cfgs = NULL;
int len;
-   const int   *lpmode, *poll_intvl;
+   const __be32*lpmode, *poll_intvl;
 
lpmode = of_get_property(np_emif, "low-power-mode", &len);
poll_intvl = of_get_property(np_emif, "temp-alert-poll-interval", &len);
@@ -1272,7 +1272,7 @@ static void __init_or_module of_get_custom_configs(struct 
device_node *np_emif,
 
if (lpmode) {
cust_cfgs->mask |= EMIF_CUSTOM_CONFIG_LPMODE;
-   cust_cfgs->lpmode = *lpmode;
+   cust_cfgs->lpmode = be32_to_cpup(lpmode);
of_property_read_u32(np_emif,
"low-power-mode-timeout-performance",
&cust_cfgs->lpmode_timeout_performance);
@@ -1287,7 +1287,8 @@ static void __init_or_module of_get_custom_configs(struct 
device_node *np_emif,
if (poll_intvl) {
cust_cfgs->mask |=
EMIF_CUSTOM_CONFIG_TEMP_ALERT_POLL_INTERVAL;
-   cust_cfgs->temp_alert_poll_interval_ms = *poll_intvl;
+   cust_cfgs->temp_alert_poll_interval_ms =
+   be32_to_cpup(poll_intvl);
}
 
if (of_find_property(np_emif, "extended-temp-part", &len))
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html