Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
On Mon, Mar 01, 2010 at 04:02:36PM +0100, ext Enric Balletbo i Serra wrote:
From: Enric Balletbo i Serra
IGEP v2 uses EHCI port 1 instead of EHCI port 2.
Signed-off-by: Enric Balletbo i Serra
I'm happy with the explanation:
Acked-by: Felipe Balbi
---
arch/arm/mach-omap2/board-igep0020.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board-igep0020.c
b/arch/arm/mach-omap2/board-igep0020.c
index 3c7789d..d55c57b 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
};
static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
- .port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
- .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
+ .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
+ .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
.phy_reset = true,
- .reset_gpio_port[0] = -EINVAL,
- .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
+ .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
+ .reset_gpio_port[1] = -EINVAL,
.reset_gpio_port[2] = -EINVAL,
};
--
1.5.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
Hi, On Mon, Mar 15, 2010 at 07:20:29PM +0100, Enric Balletb? i Serra wrote: > > please don't top-post. Read more at [1]. > > Sorry np > Yes, IGEP v1 is available but it's a different platform with different > processor > and aren't compatible. > > See http://www.igep-platform.com. > > - IGEPv1 is low-power and fan-less single board computer based on ATMEL > ARM9 processor. > > - IGEPv2 is low-power and fan-less single board computer based on > OMAP35x processor. now I get it. Thanks for the info :-) cool boards. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
Hi, 2010/3/15 Felipe Balbi : > Hi, > > please don't top-post. Read more at [1]. Sorry > is there a IGEP v1 board available ? Are there any developers around > using it ? If true, you should try to be backwards compatible. Yes, IGEP v1 is available but it's a different platform with different processor and aren't compatible. See http://www.igep-platform.com. - IGEPv1 is low-power and fan-less single board computer based on ATMEL ARM9 processor. - IGEPv2 is low-power and fan-less single board computer based on OMAP35x processor. Regards, -- Enric -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
Hi, please don't top-post. Read more at [1]. On Mon, Mar 15, 2010 at 06:07:48PM +0100, Enric Balletb? i Serra wrote: > Felipe, sorry but I don't understand your questions,m maybe I'm > missing something. is there a IGEP v1 board available ? Are there any developers around using it ? If true, you should try to be backwards compatible. [1] http://www.elinux.org/Netiquette -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
Hello,
Felipe, sorry but I don't understand your questions,m maybe I'm
missing something.
All IGEP v2 boards uses USB1HS EHCI port. My mistake was suppose that
port_mode[1] --> EHCI USB1HS but this is not correct, the EHCI USB1HS
is port_mode[0]. This patch only fixes this.
Best regards,
Enric
>> 2010/3/15 Felipe Balbi
>>>
>>> Hi,
>>>
>>> On Mon, Mar 01, 2010 at 04:02:36PM +0100, Enric Balletbo i Serra wrote:
>>> > @@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data
>>> > = {
>>> > };
>>> >
>>> > static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst =
>>> > {
>>> > - .port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>>> > - .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
>>> > + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
>>> > + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>>> > .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>>> >
>>> > .phy_reset = true,
>>> > - .reset_gpio_port[0] = -EINVAL,
>>> > - .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
>>> > + .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
>>> > + .reset_gpio_port[1] = -EINVAL,
>>>
>>> no way to be backwards compatible ? Is it worth to be backwards
>>> compatible ?
>>>
>>> --
>>> balbi
>>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
Hi,
On Mon, Mar 01, 2010 at 04:02:36PM +0100, Enric Balletbo i Serra wrote:
> @@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
> };
>
> static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
> - .port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> - .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
> + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
> + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>
> .phy_reset = true,
> - .reset_gpio_port[0] = -EINVAL,
> - .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
> + .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
> + .reset_gpio_port[1] = -EINVAL,
no way to be backwards compatible ? Is it worth to be backwards
compatible ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
From: Enric Balletbo i Serra
IGEP v2 uses EHCI port 1 instead of EHCI port 2.
Signed-off-by: Enric Balletbo i Serra
---
arch/arm/mach-omap2/board-igep0020.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board-igep0020.c
b/arch/arm/mach-omap2/board-igep0020.c
index 3c7789d..d55c57b 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
};
static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
- .port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
- .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
+ .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
+ .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
.phy_reset = true,
- .reset_gpio_port[0] = -EINVAL,
- .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
+ .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
+ .reset_gpio_port[1] = -EINVAL,
.reset_gpio_port[2] = -EINVAL,
};
--
1.5.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
