[PATCH RESEND v2 1/2] mfd: TPS65910: Make usable even if interrupt unused

2011-11-08 Thread Afzal Mohammed 
TPS65910 can be used even if interrupt is unused.
Hence let probe succeed in case interrupt can't be
configured and let Kernel only to complain about it

Signed-off-by: Afzal Mohammed af...@ti.com
---
v2: Remove driver simplification that should not have been done

 drivers/mfd/tps65910.c |6 +-
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 25d5d72..f3c9be4 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -187,15 +187,11 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
 
tps65910_gpio_init(tps65910, pmic_plat_data-gpio_base);
 
-   ret = tps65910_irq_init(tps65910, init_data-irq, init_data);
-   if (ret  0)
-   goto err2;
+   tps65910_irq_init(tps65910, init_data-irq, init_data);
 
kfree(init_data);
return ret;
 
-err2:
-   mfd_remove_devices(tps65910-dev);
 err:
kfree(tps65910);
kfree(init_data);
-- 
1.7.0.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND v2 1/2] mfd: TPS65910: Make usable even if interrupt unused

2011-11-08 Thread Mark Brown 
On Tue, Nov 08, 2011 at 06:54:03PM +0530, Afzal Mohammed wrote:
 TPS65910 can be used even if interrupt is unused.
 Hence let probe succeed in case interrupt can't be
 configured and let Kernel only to complain about it
 
 Signed-off-by: Afzal Mohammed af...@ti.com

Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html