Re: [PATCH v12 00/11] DMA Engine support for AM33XX
* Benoit Cousson b-cous...@ti.com [130624 07:42]: Hi Tony, On 06/24/2013 12:19 PM, Tony Lindgren wrote: Hi, For merging this series, I suggest the following sets: * Joel A Fernandes joelag...@ti.com [130620 14:13]: Joel A Fernandes (3): edma: config: Enable config options for EDMA da8xx: config: Enable MMC and FS options ARM: davinci: Fix compiler warnings in devices-da8xx Matt Porter (8): dmaengine: edma: Add TI EDMA device tree binding ARM: edma: Add DT and runtime PM support to the private EDMA API ARM: edma: Add EDMA crossbar event mux support dmaengine: edma: enable build for AM33XX Sekhar should queue the above patches, I've acked the mach-omap2/Kconfig change. spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. ARM: dts: add AM33XX EDMA support ARM: dts: add AM33XX SPI DMA support Benoit should queue the .dts changes. I'll do that, but do you consider them for 3.11? Yes right after -rc1 if it makes the DMA work. We almost certainly need to send few branches of fixes after -rc1 once we find out what might have broken by the removal of the hwmod data.. But let's stick to minimal changes for the -rc series naturally. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
On 6/25/2013 12:24 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [130624 07:42]: Hi Tony, On 06/24/2013 12:19 PM, Tony Lindgren wrote: Hi, For merging this series, I suggest the following sets: * Joel A Fernandes joelag...@ti.com [130620 14:13]: Joel A Fernandes (3): edma: config: Enable config options for EDMA da8xx: config: Enable MMC and FS options ARM: davinci: Fix compiler warnings in devices-da8xx Matt Porter (8): dmaengine: edma: Add TI EDMA device tree binding ARM: edma: Add DT and runtime PM support to the private EDMA API ARM: edma: Add EDMA crossbar event mux support dmaengine: edma: enable build for AM33XX Sekhar should queue the above patches, I've acked the mach-omap2/Kconfig change. spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. ARM: dts: add AM33XX EDMA support ARM: dts: add AM33XX SPI DMA support Benoit should queue the .dts changes. I'll do that, but do you consider them for 3.11? Yes right after -rc1 if it makes the DMA work. We almost certainly need to send few branches of fixes after -rc1 once we find out what might have broken by the removal of the hwmod data.. The DMA related changes went into arm-soc yesterday. So it should be safe to send the DT patches in before the merge window opens. If Tony is done with sending his pull requests may be Benoit can send to arm-soc directly? Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
On Tuesday 25 June 2013 10:16 AM, Sekhar Nori wrote: On 6/25/2013 12:24 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [130624 07:42]: Hi Tony, On 06/24/2013 12:19 PM, Tony Lindgren wrote: Hi, For merging this series, I suggest the following sets: * Joel A Fernandes joelag...@ti.com [130620 14:13]: Joel A Fernandes (3): edma: config: Enable config options for EDMA da8xx: config: Enable MMC and FS options ARM: davinci: Fix compiler warnings in devices-da8xx Matt Porter (8): dmaengine: edma: Add TI EDMA device tree binding ARM: edma: Add DT and runtime PM support to the private EDMA API ARM: edma: Add EDMA crossbar event mux support dmaengine: edma: enable build for AM33XX Sekhar should queue the above patches, I've acked the mach-omap2/Kconfig change. spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. ARM: dts: add AM33XX EDMA support ARM: dts: add AM33XX SPI DMA support Benoit should queue the .dts changes. I'll do that, but do you consider them for 3.11? Yes right after -rc1 if it makes the DMA work. We almost certainly need to send few branches of fixes after -rc1 once we find out what might have broken by the removal of the hwmod data.. The DMA related changes went into arm-soc yesterday. So it should be safe to send the DT patches in before the merge window opens. If Tony is done with sending his pull requests may be Benoit can send to arm-soc directly? I was just typing the same thing. Even if Tony send them during rc's, thats fine. Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
Hi, For merging this series, I suggest the following sets: * Joel A Fernandes joelag...@ti.com [130620 14:13]: Joel A Fernandes (3): edma: config: Enable config options for EDMA da8xx: config: Enable MMC and FS options ARM: davinci: Fix compiler warnings in devices-da8xx Matt Porter (8): dmaengine: edma: Add TI EDMA device tree binding ARM: edma: Add DT and runtime PM support to the private EDMA API ARM: edma: Add EDMA crossbar event mux support dmaengine: edma: enable build for AM33XX Sekhar should queue the above patches, I've acked the mach-omap2/Kconfig change. spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. ARM: dts: add AM33XX EDMA support ARM: dts: add AM33XX SPI DMA support Benoit should queue the .dts changes. Documentation/devicetree/bindings/dma/ti-edma.txt | 34 +++ Documentation/devicetree/bindings/spi/omap-spi.txt | 27 ++- arch/arm/Kconfig |1 + arch/arm/boot/dts/am33xx.dtsi | 22 ++ arch/arm/common/edma.c | 242 ++-- arch/arm/configs/da8xx_omapl_defconfig |3 + arch/arm/mach-davinci/devices-da8xx.c |8 +- arch/arm/mach-omap2/Kconfig|2 + drivers/dma/Kconfig|4 +- drivers/spi/spi-omap2-mcspi.c | 64 -- include/linux/platform_data/edma.h |5 +- 11 files changed, 369 insertions(+), 43 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
Sourav, On 6/24/2013 3:49 PM, Tony Lindgren wrote: Hi, For merging this series, I suggest the following sets: * Joel A Fernandes joelag...@ti.com [130620 14:13]: spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. Can you please send just the DT binding patch above to Mark's correct address with the relevant lists copied. Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
On Monday 24 June 2013 05:09 PM, Sekhar Nori wrote: Sourav, On 6/24/2013 3:49 PM, Tony Lindgren wrote: Hi, For merging this series, I suggest the following sets: * Joel A Fernandesjoelag...@ti.com [130620 14:13]: spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. Can you please send just the DT binding patch above to Mark's correct address with the relevant lists copied. Thanks, Sekhar Sure. Will send that. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
Hi Tony, On 06/24/2013 12:19 PM, Tony Lindgren wrote: Hi, For merging this series, I suggest the following sets: * Joel A Fernandes joelag...@ti.com [130620 14:13]: Joel A Fernandes (3): edma: config: Enable config options for EDMA da8xx: config: Enable MMC and FS options ARM: davinci: Fix compiler warnings in devices-da8xx Matt Porter (8): dmaengine: edma: Add TI EDMA device tree binding ARM: edma: Add DT and runtime PM support to the private EDMA API ARM: edma: Add EDMA crossbar event mux support dmaengine: edma: enable build for AM33XX Sekhar should queue the above patches, I've acked the mach-omap2/Kconfig change. spi: omap2-mcspi: add generic DMA request support to the DT binding spi: omap2-mcspi: convert to dma_request_slave_channel_compat() The spi changes should get merged via the driver list. ARM: dts: add AM33XX EDMA support ARM: dts: add AM33XX SPI DMA support Benoit should queue the .dts changes. I'll do that, but do you consider them for 3.11? Thanks, Benoit -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
Joel, On 6/21/2013 2:36 AM, Joel A Fernandes wrote: From: Joel A Fernandes agnel.j...@gmail.com This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support with changes for few pending review comments on v11 series. I have posted a branch with fixes for patches accepted by me in this series (also posted inline as replies to specific patches). https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/log/?h=v3.11/soc-2 Can you please give it a good test - especially on AM335x? I will send a pull request after you confirm. If you find bugs please send incremental patches so I can merge into the original patch. Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
Hi Sekhar, On Fri, Jun 21, 2013 at 5:27 AM, Sekhar Nori nsek...@ti.com wrote: Joel, On 6/21/2013 2:36 AM, Joel A Fernandes wrote: From: Joel A Fernandes agnel.j...@gmail.com This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support with changes for few pending review comments on v11 series. I have posted a branch with fixes for patches accepted by me in this series (also posted inline as replies to specific patches). https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/log/?h=v3.11/soc-2 Can you please give it a good test - especially on AM335x? I will send a pull request after you confirm. If you find bugs please send incremental patches so I can merge into the original patch. This breaks on AM33XX due to dangling pointer, I sent a follow up patch addressing it. However, with this branch I still get.. mmc: unable to obtain RX DMA engine channel 25 Is there anything obvious you might have changed that is causing this? Thanks, Joel -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 00/11] DMA Engine support for AM33XX
On Fri, Jun 21, 2013 at 7:07 PM, Joel A Fernandes agnel.j...@gmail.com wrote: Hi Sekhar, On Fri, Jun 21, 2013 at 5:27 AM, Sekhar Nori nsek...@ti.com wrote: Joel, On 6/21/2013 2:36 AM, Joel A Fernandes wrote: From: Joel A Fernandes agnel.j...@gmail.com This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support with changes for few pending review comments on v11 series. I have posted a branch with fixes for patches accepted by me in this series (also posted inline as replies to specific patches). https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/log/?h=v3.11/soc-2 Can you please give it a good test - especially on AM335x? I will send a pull request after you confirm. If you find bugs please send incremental patches so I can merge into the original patch. [Joel] This breaks on AM33XX due to dangling pointer, I sent a follow up patch addressing it. However, with this branch I still get.. mmc: unable to obtain RX DMA engine channel 25 [Joel] Fixed. I posted a v2 patch. With this, on v3.11/soc-2 branch - AM33xx MMC is working (root fs mount). Tested-by: Joel A Fernandes joelag...@ti.com Thanks, Joel -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v12 00/11] DMA Engine support for AM33XX
From: Joel A Fernandes agnel.j...@gmail.com This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support with changes for few pending review comments on v11 series. Also included are EDMA config and build options for OMAP2PLUS and Davinci by selecting DMADEVICES, and options to enable MMCSD on Davinci (da8xx_omapl). Currently this is required for AM33XX (Beaglebone or EVM) to access MMC and be able mount to rootfs and boot till command prompt over MMC. Unless there are other pending review comments, I hope this series can make it into 3.11 merge window, the dependent series has been posted at [1] and completed review. Tested EDMA on AM1808 EVM and AM33XX Beaglebone with MMC. Sekhar Nori has posted a GIT PULL [1] which has 2 patches this series depends on: [1] http://www.spinics.net/lists/arm-kernel/msg251503.html Changes since v11: - Fixed several style issues and warnings - Broke up the build option patch into smaller ones - Various miscellaneous fixups addressed from v10 feedback Changes since v10: - Reworked documentation based on Arnd's feedback - Moved EDMA bindings documentation earlier in series - Dropped mention on am33xx on 2/8 and 3/8 in the series Changes since v9: - Droped reserved and queue DT entries from Documentation for now from the original patch series. - Drop DT entries that are non-hardware-description - Split EDMA xbar support out of original EDMA DT parsing patch to keep it easier for review. - Rewrite shift and offset calculation xbar event mapping. - Setup default one-to-one mapping for queue_priority and queue_tc mapping as discussed in. - Split out xbar stuff to separate patch. Reference discussion: https://patchwork.kernel.org/patch/2226761/ Changes since v8: - Removed edma node interrupt-parent property, it is inherited Changes since v7: - Dropped dmaengine compat() patch. It is upstream. - Submitted edma_alloc_slot() error checking bug fix separately, now a dependency - Fixed bisect issues due to 3/10 hunks that went into 1/10 - Fixed incorrect IS_ERRVALUE() use in 3/10 Changes since v6: - Converted edma_of_read_*() to wrappers around of_property_read_*() - Fixed wording on the omap-spi generic DMA properties - Added comment/check to clarify that the driver only supports a single EDMA instance when booting from DT Changes since v5: - Dropped mmc portion and moved it to a separate series - Incorporate corrected version of dma_request_slave_channel_compat() - Fix #defines and enablement of TI_PRIV_EDMA option Changes since v4: - Fixed debug section mismatch in private edma api [01/14] - Respun format-patch to catch the platform_data/edma.h rename [01/14] - Removed address/size-cells from the EDMA binding [05/14] Changes since v3: - Rebased on 3.8-rc3 - No longer an RFC - Fixed bugs in DT/pdata parsing reported by Vaibhav Bedia - Restored all the Davinci pdata to const - Removed max_segs hack in favor of using dma_get_channel_caps() - Fixed extra parens, __raw_* accessors and, ioremap error checks in xbar handling - Removed excess license info in platform_data/edma.h - Removed unneeded reserved channels data for AM33xx - Removed test-specific pinmuxing from dts files - Adjusted mmc1 node to be disabled by default in the dtsi Changes since v2: - Rebased on 3.7-rc1 - Fixed bug in DT/pdata parsing first found by Gururaja that turned out to be masked by some toolchains - Dropped unused mach-omap2/devices.c hsmmc patch - Added AM33XX crossbar DMA event mux support - Added am335x-evm support Changes since v1: - Rebased on top of mainline from 12250d8 - Dropped the feature removal schedule patch - Implemented dma_request_slave_channel_compat() and converted the mmc and spi drivers to use it - Dropped unneeded #address-cells and #size-cells from EDMA DT support - Moved private EDMA header to linux/platform_data/ and removed some unneeded definitions - Fixed parsing of optional properties This series adds DMA Engine support for AM33xx, which uses an EDMA DMAC. The EDMA DMAC has been previously supported by only a private API implementation (much like the situation with OMAP DMA) found on the DaVinci family of SoCs. The series applies on top of 3.10-rc4. The approach taken is similar to how OMAP DMA is being converted to DMA Engine support. With the functional EDMA private API already existing in mach-davinci/dma.c, we first move that to an ARM common area so it can be shared. Adding DT and runtime PM support to the private EDMA API implementation allows it to run on AM33xx. AM33xx *only* boots using DT so the
