Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

2011-01-06 Thread Nishanth Menon 

Koen,
Apologies on a late response.

Koen Kooi had written, on 12/19/2010 08:42 AM, the following:
[...]

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
b/arch/arm/mach-omap2/board-omap3beagle.c
index f1a8ede..4756ac7 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,

[..]

+
+/* Power on DVI, Serial and PWR led */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
+   gpio_request(gpio + 1, nDVI_PWR_EN);
+   gpio_direction_output(gpio + 1, 0);
+   }

earlier in this function, we do:
gpio_request(gpio + 1, EHCI_nOC);
gpio_direction_input(gpio + 1);
here we do
gpio_request(gpio + 1, nDVI_PWR_EN);
gpio_direction_output(gpio + 1, 0);

I am confused. is gpio+1 input or output line? and what level should it 
be on?


--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

2011-01-06 Thread Koen Kooi 

Op 6 jan 2011, om 19:29 heeft Nishanth Menon het volgende geschreven:

 Koen,
 Apologies on a late response.
 
 Koen Kooi had written, on 12/19/2010 08:42 AM, the following:
 [...]
 diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
 b/arch/arm/mach-omap2/board-omap3beagle.c
 index f1a8ede..4756ac7 100644
 --- a/arch/arm/mach-omap2/board-omap3beagle.c
 +++ b/arch/arm/mach-omap2/board-omap3beagle.c
 @@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
 [..]
 +
 + /* Power on DVI, Serial and PWR led */
 +if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
 +gpio_request(gpio + 1, nDVI_PWR_EN);
 +gpio_direction_output(gpio + 1, 0);
 +}
 earlier in this function, we do:
   gpio_request(gpio + 1, EHCI_nOC);
   gpio_direction_input(gpio + 1);
 here we do
 gpio_request(gpio + 1, nDVI_PWR_EN);
 gpio_direction_output(gpio + 1, 0);
 
 I am confused. is gpio+1 input or output line? and what level should it be on?

On early revB prototypes it was used to sense USB overcurrent, I'm not sure 
what the current status is for that pin on revB and revC, but on xM it controls 
the DVI, serial and led block.

Adding Gerald to CC: to see if he has some pearls of wisdom on this :)

regards,

Koen--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

2011-01-06 Thread Coley, Gerald 
You are correct. On the -xM over current is from the USB HUB driver as there 
are four ports. So that gets detected by the USB hub device and reported back.


Gerald


-Original Message-
From: Koen Kooi [mailto:k...@dominion.thruhere.net]
Sent: Thursday, January 06, 2011 12:33 PM
To: Menon, Nishanth
Cc: Koen Kooi; l-o Mailing List; Coley, Gerald
Subject: Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on 
beagleboard-xM


Op 6 jan 2011, om 19:29 heeft Nishanth Menon het volgende geschreven:

 Koen,
 Apologies on a late response.

 Koen Kooi had written, on 12/19/2010 08:42 AM, the following:
 [...]
 diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
 b/arch/arm/mach-omap2/board-omap3beagle.c
 index f1a8ede..4756ac7 100644
 --- a/arch/arm/mach-omap2/board-omap3beagle.c
 +++ b/arch/arm/mach-omap2/board-omap3beagle.c
 @@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
 [..]
 +
 + /* Power on DVI, Serial and PWR led */
 +if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
 +gpio_request(gpio + 1, nDVI_PWR_EN);
 +gpio_direction_output(gpio + 1, 0);
 +}
 earlier in this function, we do:
   gpio_request(gpio + 1, EHCI_nOC);
   gpio_direction_input(gpio + 1);
 here we do
 gpio_request(gpio + 1, nDVI_PWR_EN);
 gpio_direction_output(gpio + 1, 0);

 I am confused. is gpio+1 input or output line? and what level should it be on?

On early revB prototypes it was used to sense USB overcurrent, I'm not sure 
what the current status is for that pin on revB and revC, but on xM it controls 
the DVI, serial and led block.

Adding Gerald to CC: to see if he has some pearls of wisdom on this :)

regards,

Koen
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

2010-12-20 Thread Kevin Hilman 
Koen Kooi koen.k...@gmail.com writes:

 Signed-off-by: Koen Kooi k...@beagleboard.org

-ENO_DESCRIPTIVE_CHANGELOG

Also, please Cc linux-arm-kernel for patches intended for upstream.

Thanks,

Kevin

 ---

 Changes since v1:
   * Reenable the PMU stat LED

  arch/arm/mach-omap2/board-omap3beagle.c |   26 --
  1 files changed, 24 insertions(+), 2 deletions(-)

 diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
 b/arch/arm/mach-omap2/board-omap3beagle.c
 index f1a8ede..4756ac7 100644
 --- a/arch/arm/mach-omap2/board-omap3beagle.c
 +++ b/arch/arm/mach-omap2/board-omap3beagle.c
 @@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
   gpio_request(gpio + 1, EHCI_nOC);
   gpio_direction_input(gpio + 1);
  
 - /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
 + /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, XM active
 +  * high / others active low) */
   gpio_request(gpio + TWL4030_GPIO_MAX, nEN_USB_PWR);
 - gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
 + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
 + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
 + else
 + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
 +
 + /* DVI reset GPIO is different between revisions */
 + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
 + beagle_dvi_device.reset_gpio = 129;
 + else
 + beagle_dvi_device.reset_gpio = 170;
 +
 +  /* Power on DVI, Serial and PWR led */
 + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
 + gpio_request(gpio + 1, nDVI_PWR_EN);
 + gpio_direction_output(gpio + 1, 0);
 + }
  
   /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
   gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
  
 + /* Power on camera interface on P7/P8 or DVI on A2 and beyond */
 + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
 + gpio_request(gpio + 2, CAM_EN);
 + gpio_direction_output(gpio + 2, 1);
 + }
 +
   return 0;
  }
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

2010-12-19 Thread Koen Kooi 
Signed-off-by: Koen Kooi k...@beagleboard.org

---

Changes since v1:
* Reenable the PMU stat LED

 arch/arm/mach-omap2/board-omap3beagle.c |   26 --
 1 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
b/arch/arm/mach-omap2/board-omap3beagle.c
index f1a8ede..4756ac7 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
gpio_request(gpio + 1, EHCI_nOC);
gpio_direction_input(gpio + 1);
 
-   /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
+   /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, XM active
+* high / others active low) */
gpio_request(gpio + TWL4030_GPIO_MAX, nEN_USB_PWR);
-   gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
+   gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+   else
+   gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
+
+   /* DVI reset GPIO is different between revisions */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
+   beagle_dvi_device.reset_gpio = 129;
+   else
+   beagle_dvi_device.reset_gpio = 170;
+
+/* Power on DVI, Serial and PWR led */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
+   gpio_request(gpio + 1, nDVI_PWR_EN);
+   gpio_direction_output(gpio + 1, 0);
+   }
 
/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
 
+   /* Power on camera interface on P7/P8 or DVI on A2 and beyond */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
+   gpio_request(gpio + 2, CAM_EN);
+   gpio_direction_output(gpio + 2, 1);
+   }
+
return 0;
 }
 
-- 
1.6.6.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

2010-12-19 Thread Nishanth Menon 

Koen Kooi wrote, on 12/19/2010 08:42 AM:
$subject - should'nt you be doing this in separate patches? easier to 
track with git bisect at a later date than a whole sale change?


also could you reword it as:
omap3: beagleboard: power on ECHI

and so on?

btw, why are we enabling camera here? should'nt that be done in camera's 
probe function? no?



Signed-off-by: Koen Kooik...@beagleboard.org

---

Changes since v1:
* Reenable the PMU stat LED

  arch/arm/mach-omap2/board-omap3beagle.c |   26 --
  1 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
b/arch/arm/mach-omap2/board-omap3beagle.c
index f1a8ede..4756ac7 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
gpio_request(gpio + 1, EHCI_nOC);
gpio_direction_input(gpio + 1);

-   /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
+   /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, XM active
+* high / others active low) */
gpio_request(gpio + TWL4030_GPIO_MAX, nEN_USB_PWR);
-   gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
+   gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+   else
+   gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
+
+   /* DVI reset GPIO is different between revisions */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
+   beagle_dvi_device.reset_gpio = 129;
+   else
+   beagle_dvi_device.reset_gpio = 170;
+
+/* Power on DVI, Serial and PWR led */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
+   gpio_request(gpio + 1, nDVI_PWR_EN);
+   gpio_direction_output(gpio + 1, 0);
+   }

/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;

+   /* Power on camera interface on P7/P8 or DVI on A2 and beyond */
+   if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
+   gpio_request(gpio + 2, CAM_EN);
+   gpio_direction_output(gpio + 2, 1);
+   }
+
return 0;
  }




--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html