Re: [PATCH v2] OMAP2/3: DMA errata correction

2009-08-13 Thread Kevin Hilman 
Vikram Pandita vikram.pand...@ti.com writes:

 This errata is valid for:
 OMAP2420 Errata 1.85 Impacts all 2420 ES rev
 OMAP2430 Errata 1.10 Impacts only ES1.0
 Description: DMA may hang when several channels are used in parallel

 OMAP3430: Not impacted, so remove the errata fix for omap3

 Signed-off-by: Vikram Pandita vikram.pand...@ti.com
 Reviewed-by: Kamat, Nishant nska...@ti.com

Acked-by: Kevin Hilman khil...@deeprootsystems.com

 ---
 [Note: Respin of - 
 http://patchwork.kernel.org/patch/32513/
 Incorporated Nishant's review comment]
  arch/arm/plat-omap/dma.c |4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

 diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
 index 34939bf..bf08634 100644
 --- a/arch/arm/plat-omap/dma.c
 +++ b/arch/arm/plat-omap/dma.c
 @@ -946,7 +946,9 @@ void omap_start_dma(int lch)
  
   cur_lch = next_lch;
   } while (next_lch != -1);
 - } else if (cpu_class_is_omap2()) {
 + } else if (cpu_is_omap242x() ||
 + (cpu_is_omap243x()   omap_type() = OMAP2430_REV_ES1_0)) {
 +
   /* Errata: Need to write lch even if not using chaining */
   dma_write(lch, CLNK_CTRL(lch));
   }
 -- 
 1.6.3.3.334.g916e1

 --
 To unsubscribe from this list: send the line unsubscribe linux-omap in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] OMAP2/3: DMA errata correction

2009-08-12 Thread Vikram Pandita 
This errata is valid for:
OMAP2420 Errata 1.85 Impacts all 2420 ES rev
OMAP2430 Errata 1.10 Impacts only ES1.0
Description: DMA may hang when several channels are used in parallel

OMAP3430: Not impacted, so remove the errata fix for omap3

Signed-off-by: Vikram Pandita vikram.pand...@ti.com
Reviewed-by: Kamat, Nishant nska...@ti.com
---
[Note: Respin of - 
http://patchwork.kernel.org/patch/32513/
Incorporated Nishant's review comment]
 arch/arm/plat-omap/dma.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 34939bf..bf08634 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -946,7 +946,9 @@ void omap_start_dma(int lch)
 
cur_lch = next_lch;
} while (next_lch != -1);
-   } else if (cpu_class_is_omap2()) {
+   } else if (cpu_is_omap242x() ||
+   (cpu_is_omap243x()   omap_type() = OMAP2430_REV_ES1_0)) {
+
/* Errata: Need to write lch even if not using chaining */
dma_write(lch, CLNK_CTRL(lch));
}
-- 
1.6.3.3.334.g916e1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[APPLIED] [PATCH v2] OMAP2/3: DMA errata correction

2009-08-05 Thread Tony Lindgren 
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 8b865a1ee739b9057e14637ff4f42cc8dfa2239b

PatchWorks
http://patchwork.kernel.org/patch/32946/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=8b865a1ee739b9057e14637ff4f42cc8dfa2239b


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] OMAP2/3: DMA errata correction

2009-06-29 Thread Vikram Pandita 
This errata is valid for:
OMAP2420 Errata 1.85 Impacts all 2420 ES rev
OMAP2430 Errata 1.10 Impacts only ES1.0
Description: DMA may hang when several channels are used in parallel
OMAP3430: Not impacted, so remove the errata fix for omap3

Fixed issue reported on cpu_is_omap24xx check reported by Nishant Kamat

Signed-off-by: Vikram Pandita vikram.pand...@ti.com
Reviewed-by: Nishant Kamat nska...@ti.com
---
 arch/arm/plat-omap/dma.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 7677a4a..e3ac94f 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -946,7 +946,9 @@ void omap_start_dma(int lch)
 
cur_lch = next_lch;
} while (next_lch != -1);
-   } else if (cpu_class_is_omap2()) {
+   } else if (cpu_is_omap242x() ||
+   (cpu_is_omap243x()   omap_type() = OMAP2430_REV_ES1_0)) {
+
/* Errata: Need to write lch even if not using chaining */
dma_write(lch, CLNK_CTRL(lch));
}
-- 
1.6.3.3.334.g916e1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html