Re: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
25 нояб. 2014 г., в 22:13, Kevin Hilman khil...@kernel.org написал(а): I'll test your patch on all my OMAP boards. Put whatever debug output you want, and I'll send you links to all the boot output. Hello, Kevin! I've sent the patch[1]. Could you be so kind to run it on all your OMAP boards? Thank you very much! It is not urgent at all. What is the preferred way for giving patches for you (for future)? I have one more fixes for i2c-omap (I think final). I don't want to break tests anymore. And I found, that n900 boot test PASS, but in fact it doesn't[2]. Alexander. [1] http://marc.info/?l=linux-i2cm=141702877518332w=2 [2] http://status.armcloud.us/boot/omap3-n900/job/next/kernel/next-20141124/defconfig/arm-omap2plus_defconfig/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
Alexander Kochetkov al.koc...@gmail.com writes: 25 нояб. 2014 г., в 22:13, Kevin Hilman khil...@kernel.org написал(а): I'll test your patch on all my OMAP boards. Put whatever debug output you want, and I'll send you links to all the boot output. Hello, Kevin! I've sent the patch[1]. Could you be so kind to run it on all your OMAP boards? Thank you very much! It is not urgent at all. Done. Built for omap2plus_defconfig, boot reports for all my OMAP boards here: http://people.linaro.org/~khilman/tmp/next-20141126-1-g760388ee02e4/arm-omap2plus_defconfig/ What is the preferred way for giving patches for you (for future)? Email is fine. I have things fully automated for primary upstream trees (mainline, linux-next, stable, etc.) but for stuff like this, I can trigger one-off tests. However, if Tony wants to have a branch (besides the one already goes to linux-next) which I would add to the automation cycle, I'm willing to do that. I have one more fixes for i2c-omap (I think final). I don't want to break tests anymore. And I found, that n900 boot test PASS, but in fact it doesn't[2]. [2] http://status.armcloud.us/boot/omap3-n900/job/next/kernel/next-20141124/defconfig/arm-omap2plus_defconfig/ Right. For these boot tests, PASS means it got to a userspace shell, which it did. The kernel got some warnings etc. during boot, but it still booted up to a shell. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
On Tue, Nov 25, 2014 at 02:20:55AM +0400, Alexander Kochetkov wrote: Commit 903c3859f77f9b0aace551da03267ef7a211dbc4 (i2c: omap: implement workaround for handling invalid BB-bit values) introduce the error result in boot test fault on OMAP3530 boards The patch fix the error (disable i2c bus test for OMAP3530). Signed-off-by: Alexander Kochetkov al.koc...@gmail.com Fixes: 903c3859f77f9b0aace551da03267ef7a211dbc4 Reported-by: Kevin Hilman khil...@kernel.org Tested-by: Tony Lindgren t...@atomide.com Applied to for-next, thanks! I'll push out this evening to make the boot tests work again. If there is more to be investigated, either hurry up and post v3 ;) or let me know that you need more time. signature.asc Description: Digital signature
Re: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
25 нояб. 2014 г., в 17:19, Wolfram Sang w...@the-dreams.de написал(а): I'll push out this evening to make the boot tests work again. If there is more to be investigated, either hurry up and post v3 ;) or let me know that you need more time. Ok, thank you. Let the fix go to the kernel-next. Maybe small fix to subject omap: i2c: to i2c: omap: I still guessing what some boards have broken i2c pull-ups. And real fix must go in the board file. http://www.spinics.net/lists/linux-i2c/msg17750.html I could create a patch to confirm this. But I don't have omap3530 boards to run. I'll be very appreciated if someone could run the patch. Regards, Alexander. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
Alexander Kochetkov al.koc...@gmail.com writes: Commit 903c3859f77f9b0aace551da03267ef7a211dbc4 (i2c: omap: implement workaround for handling invalid BB-bit values) introduce the error result in boot test fault on OMAP3530 boards The patch fix the error (disable i2c bus test for OMAP3530). Signed-off-by: Alexander Kochetkov al.koc...@gmail.com Fixes: 903c3859f77f9b0aace551da03267ef7a211dbc4 Reported-by: Kevin Hilman khil...@kernel.org Tested-by: Tony Lindgren t...@atomide.com Tested-by: Kevin Hilman khil...@linaro.org I tested DT and legacy boot on 3430/n900, 3530/beagle and 3530/overo-tobi. All boot fine. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
Alexander Kochetkov al.koc...@gmail.com writes: 25 нояб. 2014 г., в 17:19, Wolfram Sang w...@the-dreams.de написал(а): I'll push out this evening to make the boot tests work again. If there is more to be investigated, either hurry up and post v3 ;) or let me know that you need more time. Ok, thank you. Let the fix go to the kernel-next. Maybe small fix to subject omap: i2c: to i2c: omap: I still guessing what some boards have broken i2c pull-ups. And real fix must go in the board file. http://www.spinics.net/lists/linux-i2c/msg17750.html I could create a patch to confirm this. But I don't have omap3530 boards to run. I'll be very appreciated if someone could run the patch. I'll test your patch on all my OMAP boards. Put whatever debug output you want, and I'll send you links to all the boot output. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
Commit 903c3859f77f9b0aace551da03267ef7a211dbc4 (i2c: omap: implement
workaround for handling invalid BB-bit values) introduce the error result
in boot test fault on OMAP3530 boards
The patch fix the error (disable i2c bus test for OMAP3530).
Signed-off-by: Alexander Kochetkov al.koc...@gmail.com
Fixes: 903c3859f77f9b0aace551da03267ef7a211dbc4
Reported-by: Kevin Hilman khil...@kernel.org
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 5d92d0e..4563200 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -344,8 +344,10 @@ static int omap_i2c_reset(struct omap_i2c_dev *dev)
/* SYSC register is cleared by the reset; rewrite it */
omap_i2c_write_reg(dev, OMAP_I2C_SYSC_REG, sysc);
- /* Schedule I2C-bus monitoring on the next transfer */
- dev-bb_valid = 0;
+ if (dev-rev OMAP_I2C_REV_ON_3430_3530) {
+ /* Schedule I2C-bus monitoring on the next transfer */
+ dev-bb_valid = 0;
+ }
}
return 0;
@@ -460,7 +462,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
dev-scllstate = scll;
dev-sclhstate = sclh;
- if (dev-rev OMAP_I2C_OMAP1_REV_2) {
+ if (dev-rev = OMAP_I2C_REV_ON_3430_3530) {
/* Not implemented */
dev-bb_valid = 1;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
