Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Mon, 2010-07-26 at 21:30 +0200, ext John W. Linville wrote: On Wed, Jul 21, 2010 at 08:33:34PM +0300, Ohad Ben-Cohen wrote: This patch series adds native support for wl1271 on ZOOM. Just for the record, I'm fine with the wl1271 bits here going through the omap tree with the rest of the series. Yeah, I agree. This is probably the best way to keep things in sync. -- Cheers, Luca. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
* Luciano Coelho luciano.coe...@nokia.com [100802 11:10]: On Mon, 2010-07-26 at 21:30 +0200, ext John W. Linville wrote: On Wed, Jul 21, 2010 at 08:33:34PM +0300, Ohad Ben-Cohen wrote: This patch series adds native support for wl1271 on ZOOM. Just for the record, I'm fine with the wl1271 bits here going through the omap tree with the rest of the series. Yeah, I agree. This is probably the best way to keep things in sync. OK, let's do that then. Nicolas Pitre made a comment saying he wants to look at these patches more, are there other pending comments? Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Mon, Aug 2, 2010 at 2:42 PM, Tony Lindgren t...@atomide.com wrote: Nicolas Pitre made a comment saying he wants to look at these patches more, are there other pending comments? I plan to post a v3 series this week with some of the comments that were already discussed after v2. Thanks everyone for the attention, Ohad. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Mon, Aug 2, 2010 at 1:42 PM, Tony Lindgren t...@atomide.com wrote: Nicolas Pitre made a comment saying he wants to look at these patches more, are there other pending comments? Yep, I'm feeling quite uncomfortable with the way platform data is being passed over to sdio device now. Also, specifically to 12xx, I'd like to see REF_CLOCK moved on and have this set by platform too (I haven't found anything like that in the patches but maybe I've overlooked that). Thanks, Vitaly -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Mon, Aug 2, 2010 at 6:12 PM, Vitaly Wool vitalyw...@gmail.com wrote: Also, specifically to 12xx, I'd like to see REF_CLOCK moved on and have this set by platform too (I haven't found anything like that in the patches but maybe I've overlooked that). Check out patch no. 9: http://www.spinics.net/lists/arm-kernel/msg93836.html Thanks, Vitaly -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
Hi Ohad, On Mon, Aug 2, 2010 at 5:59 PM, Ohad Ben-Cohen o...@wizery.com wrote: Check out patch no. 9: sorry for the confusion. However, I guess if the platform doesn't supply this value, we'll just consider it 0? Without any warning, right? The problem is, we can't really distinguish between this field not set and value zero, and that means something is wrong with the design. The easiest way is probably changing the clock ids to start with 1. Thanks, Vitaly -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
Hi Vitaly, On Mon, Aug 2, 2010 at 7:19 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Mon, Aug 2, 2010 at 5:59 PM, Ohad Ben-Cohen o...@wizery.com wrote: Check out patch no. 9: sorry for the confusion. However, I guess if the platform doesn't supply this value, we'll just consider it 0? Without any warning, right? The problem is, we can't really distinguish between this field not set and value zero, and that means something is wrong with the design. The easiest way is probably changing the clock ids to start with 1. I don't think it's a huge deal as adding new devices on board files is anyway something that is done carefully and not so often. Btw, we have this kind of mechanism in other locations of the kernel as well and it doesn't seem to be problematic (e.g. spi-chip_select, spi-mode, spi-irq, ...). Having said that I don't mind applying your proposal either and pushing those defines by 1 in the driver. Luca what do you think ? Thanks, Ohad. Thanks, Vitaly -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Mon, Jul 26, 2010 at 10:30 PM, John W. Linville linvi...@tuxdriver.com wrote: On Wed, Jul 21, 2010 at 08:33:34PM +0300, Ohad Ben-Cohen wrote: This patch series adds native support for wl1271 on ZOOM. Just for the record, I'm fine with the wl1271 bits here going through the omap tree with the rest of the series. Thanks, John. John -- John W. Linville Someday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Wed, Jul 21, 2010 at 08:33:34PM +0300, Ohad Ben-Cohen wrote: This patch series adds native support for wl1271 on ZOOM. Just for the record, I'm fine with the wl1271 bits here going through the omap tree with the rest of the series. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Wed, 21 Jul 2010, Ohad Ben-Cohen wrote: This patch series adds native support for wl1271 on ZOOM. Changes since v1: - introduce a fixed regulator device to control the power of wl1271 - allow to propagate private board-specific data to SDIO function drivers - allow SDIO function driver to control the card's power via new API - make it possible to keep the card's power down (without depending on an explicit SDIO function driver power-down request) Thanks to these changes, we no longer need a separate platform device (carrying e.g. the external irq information of the device), and no longer need to emulate virtual card detect events. The two board muxing pathces were already taken by Tony, and are resent here just to make it easier for people to use/test these pathces. The changes to the MMC core really needs careful review; there still might be some pitfalls that haven't been covered. E.g., one thing we plan to look at next is their bahvior together with SDIO Suspend/Resume. Special thanks to Roger Quadros and Nicolas Pitre for their extensive review and helpful suggestions. FYI, I do intend to review those patches, but I'll be flying home in a couple hours, and once there I'll be gone on vacation for 2 weeks. So this review won't happen right away. Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/20] native support for wl1271 on ZOOM
On Fri, Jul 23, 2010 at 1:56 AM, Nicolas Pitre n...@fluxnic.net wrote: On Wed, 21 Jul 2010, Ohad Ben-Cohen wrote: This patch series adds native support for wl1271 on ZOOM. Changes since v1: - introduce a fixed regulator device to control the power of wl1271 - allow to propagate private board-specific data to SDIO function drivers - allow SDIO function driver to control the card's power via new API - make it possible to keep the card's power down (without depending on an explicit SDIO function driver power-down request) Thanks to these changes, we no longer need a separate platform device (carrying e.g. the external irq information of the device), and no longer need to emulate virtual card detect events. The two board muxing pathces were already taken by Tony, and are resent here just to make it easier for people to use/test these pathces. The changes to the MMC core really needs careful review; there still might be some pitfalls that haven't been covered. E.g., one thing we plan to look at next is their bahvior together with SDIO Suspend/Resume. Special thanks to Roger Quadros and Nicolas Pitre for their extensive review and helpful suggestions. FYI, I do intend to review those patches, but I'll be flying home in a couple hours, and once there I'll be gone on vacation for 2 weeks. So this review won't happen right away. Thanks, Nicolas. Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
